[11/21] tests: qemuxml2argv: remove unused DO_TEST_CAPS* macros

Message ID e24e50ecc650d9c6044e15a81dd090d50d70d247.1552574299.git.crobinso@redhat.com
State Accepted
Commit 0ea2bd054fc685d1186dabeb4bd9e14f8f33ce69
Headers show
Series
  • tests: qemuxml2argv: support optional arguments
Related show

Commit Message

Cole Robinson March 14, 2019, 2:44 p.m.
They are potentially useful at the moment, but we will be making
things much more flexible

Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
 tests/qemuxml2argvtest.c | 10 ----------
 1 file changed, 10 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Andrea Bolognani March 19, 2019, 1:31 p.m. | #1
On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote:
[...]
> -# define DO_TEST_CAPS(name, ver) \

> -    DO_TEST_CAPS_FULL(name, 0, 0, ver)


I fail to see why this one existed in the first place - isn't it
basically the same as DO_TEST_CAPS_VER()?

Reviewed-by: Andrea Bolognani <abologna@redhat.com>


-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Ján Tomko March 19, 2019, 2:21 p.m. | #2
On Tue, Mar 19, 2019 at 02:31:47PM +0100, Andrea Bolognani wrote:
>On Thu, 2019-03-14 at 10:44 -0400, Cole Robinson wrote:

>[...]

>> -# define DO_TEST_CAPS(name, ver) \

>> -    DO_TEST_CAPS_FULL(name, 0, 0, ver)

>

>I fail to see why this one existed in the first place - isn't it

>basically the same as DO_TEST_CAPS_VER()?

>


Probably a leftover from earlier versions.
It is unused since its introduction in:
commit 976fbb98c8dbccbba93fb5f5a8bb2f94df0be346
    tests: qemuxml2argv: Add infrastructure for testing with real qemuCaps

Jano

>Reviewed-by: Andrea Bolognani <abologna@redhat.com>

>

>-- 

>Andrea Bolognani / Red Hat / Virtualization

>

>--

>libvir-list mailing list

>libvir-list@redhat.com

>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patch

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 1ce8bade48..130ab29d6e 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -832,16 +832,6 @@  mymain(void)
 # define DO_TEST_CAPS_LATEST_PARSE_ERROR(name) \
     DO_TEST_CAPS_ARCH_LATEST_FULL(name, "x86_64", FLAG_EXPECT_PARSE_ERROR, 0)
 
-/**
- * The following test macros should be used only in cases when the tests require
- * testing of some non-standard combination of capability flags
- */
-# define DO_TEST_CAPS_FULL(name, flags, parseFlags, ver) \
-    DO_TEST_CAPS_ARCH(name, NULL, flags, parseFlags, GIC_NONE, "x86_64", ver)
-
-# define DO_TEST_CAPS(name, ver) \
-    DO_TEST_CAPS_FULL(name, 0, 0, ver)
-
 # define DO_TEST_FULL(name, ...) \
     do { \
         static struct testInfo info = { \