[4/5] ARM: dts: imx7s-warp: add csi and mipi_csi node

Message ID 20190319170003.21261-5-rui.silva@linaro.org
State New
Headers show
Series
  • ARM: imx7s: add media nodes
Related show

Commit Message

Rui Miguel Silva March 19, 2019, 5 p.m.
Add and enable csi and mipi_csi nodes.

Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>

---
 arch/arm/boot/dts/imx7s-warp.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
2.21.0

Comments

Shawn Guo March 26, 2019, 8:25 a.m. | #1
On Tue, Mar 19, 2019 at 05:00:02PM +0000, Rui Miguel Silva wrote:
> Add and enable csi and mipi_csi nodes.

> 

> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>

> ---

>  arch/arm/boot/dts/imx7s-warp.dts | 10 ++++++++++

>  1 file changed, 10 insertions(+)

> 

> diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts

> index 23431faecaf4..5158c2d958a7 100644

> --- a/arch/arm/boot/dts/imx7s-warp.dts

> +++ b/arch/arm/boot/dts/imx7s-warp.dts

> @@ -277,6 +277,16 @@

>  	status = "okay";

>  };

>  

> +&csi {


Please keep the labeled nodes sort alphabetically.

> +	status = "okay";

> +};

> +

> +&mipi_csi {

> +	clock-frequency = <166000000>;

> +	status = "okay";


We usually end property list with 'status'.

Shawn

> +	fsl,csis-hs-settle = <3>;

> +};

> +

>  &wdog1 {

>  	pinctrl-names = "default";

>  	pinctrl-0 = <&pinctrl_wdog>;

> -- 

> 2.21.0

>

Patch

diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
index 23431faecaf4..5158c2d958a7 100644
--- a/arch/arm/boot/dts/imx7s-warp.dts
+++ b/arch/arm/boot/dts/imx7s-warp.dts
@@ -277,6 +277,16 @@ 
 	status = "okay";
 };
 
+&csi {
+	status = "okay";
+};
+
+&mipi_csi {
+	clock-frequency = <166000000>;
+	status = "okay";
+	fsl,csis-hs-settle = <3>;
+};
+
 &wdog1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wdog>;