| Message ID | 20190321124240.901884-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | ca1438dcb34c7fcad63b6ce14ea63a870b92a69b |
| Headers | show |
| Series | spi: export tracepoint symbols to modules | expand |
On Thu, Mar 21, 2019 at 01:42:25PM +0100, Arnd Bergmann wrote: > The newly added tracepoints in the spi-mxs driver cause a link > error when the driver is a loadable module: > > ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined! > ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined! > > I'm not quite sure where to put the export statements, but > directly after the inclusion of the header seems as good as > any other place. I agree it looks a bit ugly, but I don't have a better idea either. > > Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Looks right: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks for finding and fixing that. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 93986f879b09..e5d38152888a 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -36,6 +36,8 @@ #define CREATE_TRACE_POINTS #include <trace/events/spi.h> +EXPORT_TRACEPOINT_SYMBOL(spi_transfer_start); +EXPORT_TRACEPOINT_SYMBOL(spi_transfer_stop); #include "internals.h"
The newly added tracepoints in the spi-mxs driver cause a link error when the driver is a loadable module: ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined! ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined! I'm not quite sure where to put the export statements, but directly after the inclusion of the header seems as good as any other place. Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/spi/spi.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.0