diff mbox series

.travis.yml: reduce number of targets built while disabling things

Message ID 20190321124857.28132-1-alex.bennee@linaro.org
State Superseded
Headers show
Series .travis.yml: reduce number of targets built while disabling things | expand

Commit Message

Alex Bennée March 21, 2019, 12:48 p.m. UTC 
This build keeps timing out on Travis and it's unlikely including the
additional guest front-ends will catch any failures in the fallback
code.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Stefano Garzarella March 21, 2019, 3:06 p.m. UTC | #1 
Hi Alex,
thanks also for the other patch series that I'm testing right now to speed
up Travis :)

Just a comment below:

On Thu, Mar 21, 2019 at 12:48:57PM +0000, Alex Bennée wrote:
> This build keeps timing out on Travis and it's unlikely including the

> additional guest front-ends will catch any failures in the fallback

> code.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  .travis.yml | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/.travis.yml b/.travis.yml

> index 3fb3dab46e..2e06aee9d0 100644

> --- a/.travis.yml

> +++ b/.travis.yml

> @@ -107,7 +107,7 @@ matrix:

>  

>  

>      - env:

> -        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication"

> +        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}"

>  


Is removing --disable-user intentional here?

Thanks,
Stefano
Alex Bennée March 21, 2019, 3:57 p.m. UTC | #2 
Stefano Garzarella <sgarzare@redhat.com> writes:

> Hi Alex,

> thanks also for the other patch series that I'm testing right now to speed

> up Travis :)

>

> Just a comment below:

>

> On Thu, Mar 21, 2019 at 12:48:57PM +0000, Alex Bennée wrote:

>> This build keeps timing out on Travis and it's unlikely including the

>> additional guest front-ends will catch any failures in the fallback

>> code.

>>

>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>> ---

>>  .travis.yml | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/.travis.yml b/.travis.yml

>> index 3fb3dab46e..2e06aee9d0 100644

>> --- a/.travis.yml

>> +++ b/.travis.yml

>> @@ -107,7 +107,7 @@ matrix:

>>

>>

>>      - env:

>> -        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication"

>> +        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}"

>>

>

> Is removing --disable-user intentional here?


Yes - --disable-user just removes all user mode targets from the default
target list. However as we are now explicitly listing the softmmu
targets it is redundant.

>

> Thanks,

> Stefano



--
Alex Bennée
Stefano Garzarella March 21, 2019, 4:22 p.m. UTC | #3 
On Thu, Mar 21, 2019 at 03:57:43PM +0000, Alex Bennée wrote:
> 

> Stefano Garzarella <sgarzare@redhat.com> writes:

> 

> > Hi Alex,

> > thanks also for the other patch series that I'm testing right now to speed

> > up Travis :)

> >

> > Just a comment below:

> >

> > On Thu, Mar 21, 2019 at 12:48:57PM +0000, Alex Bennée wrote:

> >> This build keeps timing out on Travis and it's unlikely including the

> >> additional guest front-ends will catch any failures in the fallback

> >> code.

> >>

> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> >> ---

> >>  .travis.yml | 2 +-

> >>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>

> >> diff --git a/.travis.yml b/.travis.yml

> >> index 3fb3dab46e..2e06aee9d0 100644

> >> --- a/.travis.yml

> >> +++ b/.travis.yml

> >> @@ -107,7 +107,7 @@ matrix:

> >>

> >>

> >>      - env:

> >> -        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication"

> >> +        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}"

> >>

> >

> > Is removing --disable-user intentional here?

> 

> Yes - --disable-user just removes all user mode targets from the default

> target list. However as we are now explicitly listing the softmmu

> targets it is redundant.

> 


Clear! Sorry for the stupid question!

Acked-by: Stefano Garzarella <sgarzare@redhat.com>


Thanks,
Stefano
Alex Bennée March 21, 2019, 4:36 p.m. UTC | #4 
Stefano Garzarella <sgarzare@redhat.com> writes:

> On Thu, Mar 21, 2019 at 03:57:43PM +0000, Alex Bennée wrote:

>>

>> Stefano Garzarella <sgarzare@redhat.com> writes:

>>

>> > Hi Alex,

>> > thanks also for the other patch series that I'm testing right now to speed

>> > up Travis :)

>> >

>> > Just a comment below:

>> >

>> > On Thu, Mar 21, 2019 at 12:48:57PM +0000, Alex Bennée wrote:

>> >> This build keeps timing out on Travis and it's unlikely including the

>> >> additional guest front-ends will catch any failures in the fallback

>> >> code.

>> >>

>> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>> >> ---

>> >>  .travis.yml | 2 +-

>> >>  1 file changed, 1 insertion(+), 1 deletion(-)

>> >>

>> >> diff --git a/.travis.yml b/.travis.yml

>> >> index 3fb3dab46e..2e06aee9d0 100644

>> >> --- a/.travis.yml

>> >> +++ b/.travis.yml

>> >> @@ -107,7 +107,7 @@ matrix:

>> >>

>> >>

>> >>      - env:

>> >> -        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication"

>> >> +        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}"

>> >>

>> >

>> > Is removing --disable-user intentional here?

>>

>> Yes - --disable-user just removes all user mode targets from the default

>> target list. However as we are now explicitly listing the softmmu

>> targets it is redundant.

>>

>

> Clear! Sorry for the stupid question!


There are no stupid questions ;-)

>

> Acked-by: Stefano Garzarella <sgarzare@redhat.com>


Thanks.

>

> Thanks,

> Stefano



--
Alex Bennée
Wainer dos Santos Moschetta March 21, 2019, 5:28 p.m. UTC | #5 
On 03/21/2019 09:48 AM, Alex Bennée wrote:
> This build keeps timing out on Travis and it's unlikely including the

> additional guest front-ends will catch any failures in the fallback

> code.

>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   .travis.yml | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>

> diff --git a/.travis.yml b/.travis.yml

> index 3fb3dab46e..2e06aee9d0 100644

> --- a/.travis.yml

> +++ b/.travis.yml

> @@ -107,7 +107,7 @@ matrix:

>   

>   

>       - env:

> -        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication"

> +        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}"

>   

>   

>       # Module builds are mostly of interest to major distros
diff mbox series

Patch

diff --git a/.travis.yml b/.travis.yml
index 3fb3dab46e..2e06aee9d0 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -107,7 +107,7 @@  matrix:
 
 
     - env:
-        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-user --disable-replication"
+        - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr --disable-brlapi --disable-libusb --disable-replication --target-list=${MAIN_SOFTMMU_TARGETS}"
 
 
     # Module builds are mostly of interest to major distros