From patchwork Mon Mar 25 09:39:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 161065 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp3750452jan; Mon, 25 Mar 2019 02:43:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPLigUEv+r0r+aP1RxTHzO3MZJSZ0RTT/pOFfQKRqihXTebLbJPTyjY0l9f0PmDuApRrTT X-Received: by 2002:a62:1d8c:: with SMTP id d134mr23055438pfd.185.1553507009698; Mon, 25 Mar 2019 02:43:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553507009; cv=none; d=google.com; s=arc-20160816; b=tlL1P3Uivlih1v/fwU90U7kNXw0WaCU5hK/HXbpI4NKSYOOkYX8nTFWaUg/k1t1BBQ WNQeSiHm2WYrwIg+P/QkOT8STal9QEtc3KNXlnOrSGtdP9UE0+i2G+CVKl8vFieGupzm ZZM0nNSw2C73rREUxTjVx0h94PF73Zi6ciZ/X228rGEOa0+U8+54WTcNtjGsUCztaVHF tyW2VQrLML401UDhL4LkQXsKnzXtlyJRy42pRtVG3/p6/ttV+v8RN2fhJmBUTLT5fXvj V4ycjFjuhvvD4fE85JQeuSj/2z9ORbhtKYYjUkARHlgS6IIgPjuv9GKrd66zS4XkBXlk 8uIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=9+2eOM3oSY0oLj93leiipPk6vycQ1SmzvQwVGhiyl5g=; b=yW+/nR3wVnuZ+9YvB9YaZ5rf6ocMoLclRKoKSDUK3KGUQSU41HuRcxV645J0wdEzXk jJmjbniwXm0yAtCSVnAUSekgeVnKOFVyBfnvET9dWYC1NKnLLGfPLqbrH0nhlaQP40TR tT5V5SkS7WNmqOi+O/+qUzJBstkGG3/Z0kAzPUENSlgJsIkHS88k4dw71bR5pFHI9nOC ZOcf7I0dn6kO6p3PRDdccWf5oun4DdKtKqBrQ78hBvhNJgrGWtMwdEZFxwuRF+mDTkkd saCDVYG4959bj7HUJpqai4PspfH7O/C/UkWTsmFR45BKZTa8GHontoRq53cdfRk93ptr 9c7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=YO9CTCdC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k91si14007095pld.87.2019.03.25.02.43.29; Mon, 25 Mar 2019 02:43:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=YO9CTCdC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730688AbfCYJn2 (ORCPT + 31 others); Mon, 25 Mar 2019 05:43:28 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:45026 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730435AbfCYJnW (ORCPT ); Mon, 25 Mar 2019 05:43:22 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2P9h8n3068127; Mon, 25 Mar 2019 04:43:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1553506988; bh=9+2eOM3oSY0oLj93leiipPk6vycQ1SmzvQwVGhiyl5g=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=YO9CTCdCJSieMAZhaoTOAlkvr0OIWpR2ryFIhDLMmlp659M9YnWOFIsUdrGcxM2DD TT4IQHI3GzypY70iWRApg6vS2EwHccc84Zd2z+GdYq7tFAd/KpqSV5/nK6qnjiqvbd htKq/Yh+Nck8AXW/CcGTh2MiCr2IGOEV/rl6vbu0= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2P9h8MB049310 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 25 Mar 2019 04:43:08 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 25 Mar 2019 04:43:08 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Mon, 25 Mar 2019 04:43:08 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x2P9feaU028077; Mon, 25 Mar 2019 04:43:02 -0500 From: Kishon Vijay Abraham I To: Gustavo Pimentel , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Arnd Bergmann , Murali Karicheri CC: Kishon Vijay Abraham I , Jingoo Han , Greg Kroah-Hartman , , , , , , , Minghuan Lian , Mingkai Hu , Roy Zang , Jesper Nilsson Subject: [PATCH v3 15/26] PCI: keystone: Invoke phy_reset API before enabling PHY Date: Mon, 25 Mar 2019 15:09:36 +0530 Message-ID: <20190325093947.32633-16-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190325093947.32633-1-kishon@ti.com> References: <20190325093947.32633-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SERDES connected to the PCIe controller in AM654 requires power on reset enable (POR_EN) to be set in the SERDES. The SERDES driver sets POR_EN in the reset ops and it has to be invoked before init or enable ops. In order for SERDES driver to set POR_EN, invoke phy_reset API in pci-keystone driver. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.17.1 diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index a6a482bd648f..e4a816f53b8e 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -897,6 +897,10 @@ static int ks_pcie_enable_phy(struct keystone_pcie *ks_pcie) int num_lanes = ks_pcie->num_lanes; for (i = 0; i < num_lanes; i++) { + ret = phy_reset(ks_pcie->phy[i]); + if (ret < 0) + goto err_phy; + ret = phy_init(ks_pcie->phy[i]); if (ret < 0) goto err_phy;