diff mbox series

[1/5] dt-bindings: mfd: Update the ramp up/down property

Message ID 20190325142403.30447-2-dmurphy@ti.com
State Superseded
Headers show
Series TI LMU rework | expand

Commit Message

Dan Murphy March 25, 2019, 2:23 p.m. UTC
Modify the ramp-up/down property and add the property description
to the binding.

Signed-off-by: Dan Murphy <dmurphy@ti.com>

---
 .../devicetree/bindings/mfd/ti-lmu.txt        | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

-- 
2.19.0

Comments

Lee Jones April 4, 2019, 8:19 a.m. UTC | #1
On Mon, 25 Mar 2019, Dan Murphy wrote:

> Modify the ramp-up/down property and add the property description

> to the binding.


This is the 'what', but where is the 'why'?

> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> ---

>  .../devicetree/bindings/mfd/ti-lmu.txt        | 20 ++++++++++++-------

>  1 file changed, 13 insertions(+), 7 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/mfd/ti-lmu.txt b/Documentation/devicetree/bindings/mfd/ti-lmu.txt

> index 980394d701a7..d9d529de6dc1 100644

> --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt

> +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt

> @@ -25,6 +25,12 @@ Required properties:

>  

>  Optional property:

>    - enable-gpios: A GPIO specifier for hardware enable pin.

> +  - ramp-up-ms: Current ramping from one brightness level to

> +		the a higher brightness level.

> +		Range from 2048 us - 117.44 s

> +  - ramp-down-ms: Current ramping from one brightness level to

> +		  the a lower brightness level.

> +		  Range from 2048 us - 117.44 s

>  

>  Required node:

>    - backlight: All LMU devices have backlight child nodes.

> @@ -90,7 +96,7 @@ lm3631@29 {

>  

>  		lcd_bl {

>  			led-sources = <0 1>;

> -			ramp-up-msec = <300>;

> +			ramp-up-ms = <300>;

>  		};

>  	};

>  };

> @@ -152,15 +158,15 @@ lm3633@36 {

>  		main {

>  			label = "main_lcd";

>  			led-sources = <1 2>;

> -			ramp-up-msec = <500>;

> -			ramp-down-msec = <500>;

> +			ramp-up-ms = <500>;

> +			ramp-down-ms = <500>;

>  		};

>  

>  		front {

>  			label = "front_lcd";

>  			led-sources = <0>;

> -			ramp-up-msec = <1000>;

> -			ramp-down-msec = <0>;

> +			ramp-up-ms = <1000>;

> +			ramp-down-ms = <0>;

>  		};

>  	};

>  

> @@ -212,8 +218,8 @@ lm3697@36 {

>  

>  		lcd {

>  			led-sources = <0 1 2>;

> -			ramp-up-msec = <200>;

> -			ramp-down-msec = <200>;

> +			ramp-up-ms = <200>;

> +			ramp-down-ms = <200>;

>  		};

>  	};

>  


-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/ti-lmu.txt b/Documentation/devicetree/bindings/mfd/ti-lmu.txt
index 980394d701a7..d9d529de6dc1 100644
--- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt
+++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt
@@ -25,6 +25,12 @@  Required properties:
 
 Optional property:
   - enable-gpios: A GPIO specifier for hardware enable pin.
+  - ramp-up-ms: Current ramping from one brightness level to
+		the a higher brightness level.
+		Range from 2048 us - 117.44 s
+  - ramp-down-ms: Current ramping from one brightness level to
+		  the a lower brightness level.
+		  Range from 2048 us - 117.44 s
 
 Required node:
   - backlight: All LMU devices have backlight child nodes.
@@ -90,7 +96,7 @@  lm3631@29 {
 
 		lcd_bl {
 			led-sources = <0 1>;
-			ramp-up-msec = <300>;
+			ramp-up-ms = <300>;
 		};
 	};
 };
@@ -152,15 +158,15 @@  lm3633@36 {
 		main {
 			label = "main_lcd";
 			led-sources = <1 2>;
-			ramp-up-msec = <500>;
-			ramp-down-msec = <500>;
+			ramp-up-ms = <500>;
+			ramp-down-ms = <500>;
 		};
 
 		front {
 			label = "front_lcd";
 			led-sources = <0>;
-			ramp-up-msec = <1000>;
-			ramp-down-msec = <0>;
+			ramp-up-ms = <1000>;
+			ramp-down-ms = <0>;
 		};
 	};
 
@@ -212,8 +218,8 @@  lm3697@36 {
 
 		lcd {
 			led-sources = <0 1 2>;
-			ramp-up-msec = <200>;
-			ramp-down-msec = <200>;
+			ramp-up-ms = <200>;
+			ramp-down-ms = <200>;
 		};
 	};