[edk2,edk2-platforms] Platform/Hisilicon: update D06 system firmware description

Message ID 20190326202245.15061-1-leif.lindholm@linaro.org
State New
Headers show
Series
  • [edk2,edk2-platforms] Platform/Hisilicon: update D06 system firmware description
Related show

Commit Message

Leif Lindholm March 26, 2019, 8:22 p.m.
Since the D06 port now depends on updated IMP firmware to function
properly, there needs to be a one-way upgrade path. Upgrade to the
current state of things must happen via .hpm. Subsequent capsule updates
cannot be permitted to go below this version.

So update the firmware descriptor to Version: 3 and
LowestSupportedFirmwareVersion: 3.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---

Ming: I would also be cherry-picking this patch into RPF 19.03.

 Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel March 27, 2019, 6:57 a.m. | #1
On Tue, 26 Mar 2019 at 21:22, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>

> Since the D06 port now depends on updated IMP firmware to function

> properly, there needs to be a one-way upgrade path. Upgrade to the

> current state of things must happen via .hpm. Subsequent capsule updates

> cannot be permitted to go below this version.

>

> So update the firmware descriptor to Version: 3 and

> LowestSupportedFirmwareVersion: 3.

>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>


Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


> ---

>

> Ming: I would also be cherry-picking this patch into RPF 19.03.

>

>  Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

>

> diff --git a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc

> index 36175338dd..1287dfd834 100644

> --- a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc

> +++ b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc

> @@ -22,9 +22,9 @@

>  #define PACKAGE_VERSION                     0xFFFFFFFF

>  #define PACKAGE_VERSION_STRING              L"Unknown"

>

> -#define CURRENT_FIRMWARE_VERSION            0x00000002

> -#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000002"

> -#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000001

> +#define CURRENT_FIRMWARE_VERSION            0x00000003

> +#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000003"

> +#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000003

>

>  #define IMAGE_ID                            SIGNATURE_64('H','W','A', 'R', 'M', '_', 'F', 'd')

>  #define IMAGE_ID_STRING                     L"ARMPlatformFd"

> --

> 2.11.0

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
index 36175338dd..1287dfd834 100644
--- a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
+++ b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
@@ -22,9 +22,9 @@ 
 #define PACKAGE_VERSION                     0xFFFFFFFF
 #define PACKAGE_VERSION_STRING              L"Unknown"
 
-#define CURRENT_FIRMWARE_VERSION            0x00000002
-#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000002"
-#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000001
+#define CURRENT_FIRMWARE_VERSION            0x00000003
+#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000003"
+#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000003
 
 #define IMAGE_ID                            SIGNATURE_64('H','W','A', 'R', 'M', '_', 'F', 'd')
 #define IMAGE_ID_STRING                     L"ARMPlatformFd"