From patchwork Fri Mar 29 13:35:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 161436 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp2051997jan; Fri, 29 Mar 2019 06:38:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwbEit/2/L4Kcl1tegqb9qy/b6xivlmD2sYVbRrSYhhFQZy6mXAGYaK6izWJe0D4SShtKKN X-Received: by 2002:a17:902:1102:: with SMTP id d2mr46630061pla.329.1553866728847; Fri, 29 Mar 2019 06:38:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553866728; cv=none; d=google.com; s=arc-20160816; b=yoj1d2u6yuPDOhYJlSj/yinWVnFJunsg8y0EqSeBumsIMP+TGQQH+ycRDYMutq7IsO m8G7AGPfq94MZyJXuYVoY9iocapyXya+0q5h+vk1rQLBvwdHYaPevugLHbQYdRdmZUun 63pEEkJMV+Vpxlx0N4hPOBYK6lYHCDjYtpAuiPwvccX6SyXYgL3Rauu/pS6M8fwi464x UjGbZlcmL9JixTVoWrmbwjGoYAX+TFqk9AF93PCzgpm0N+spW6Fd7dg92Nz7+Qj57Zi7 Q5+GYYAjj0EXJ0VP3LdnZq5Pb5xy3tRQlXKM/YSKbIMjN/lFFDWowWwHzQkS0MZEo0jO +tUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=ZEkYwtszPa4+qOt5HcIDNp8sjxw2NpsJc0S5o4LA7uc=; b=CP2k+XlLuFk9uXfCffhpBZEQaOQ90/E3lGjOHVZWk/asl9rUskxUWBn3UsVX86Xrfx eaws9pAN5SQ3M3DHSvyGEH8+zz6+2AxGJp1WTo9onDrMsiOP+U57f5LB1vAlIM6wLyW3 EhoqP63C+pFjxOASNcZZE3mkqYREiOQCTVSuAqR+D9Akvswql8ueaClqq4+xLJqK35ZG Ux4pMEvi7AJHjvhwixFiXDEGGxa+9vluVD0xCUdN+LTlVZlvHEDYL77Mt2x0iOfXjmtY VoIzCZ3G7xHc5yJPsroJEWxb9P4x0onIhigLhgXiGG6KsWSZ64K3IDS616+JgbePOHHu mzfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=gR2iA3Qw; dkim=pass header.i=@linaro.org header.s=google header.b=HXD7LsDd; spf=pass (google.com: domain of libc-alpha-return-101005-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-101005-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id w3si1938376plp.35.2019.03.29.06.38.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 06:38:48 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-101005-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=gR2iA3Qw; dkim=pass header.i=@linaro.org header.s=google header.b=HXD7LsDd; spf=pass (google.com: domain of libc-alpha-return-101005-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-101005-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=jnN9MJ/RvOl1QTYQ/p/MKCqPo+CvOS9 OleGx1LD1BX8R9wgUVCSHOdRFXO4YE75Dzi5kYubS2FXTAY4cma3JoICWsSzM0PI vtoj73isaEXMVG7Xu22y5tjLCFuAAi6FeLzriWpw3EO36u1qUe+ZjktwUqLxx3mI 7By9YUcdgLaw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=G4pImbN4+cTVG6vtVKX4ZUJJbnI=; b=gR2iA 3QwoKC4dVmxNb0gyT7Nf/WIXZQ25M4NuUI3V1B0EOInhOkBUQRTjeS+8GISjIU7O bMMv/I1hTrpriu0RSTNuJkAcAmfFWp2NwJcTzhYs/hHBlqG7vsz2M3WT+t5Lg8/3 XFDLl4xtWmIeU1Tohy3Qyq8Z/OX/wvSVJTV0P4= Received: (qmail 120741 invoked by alias); 29 Mar 2019 13:36:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 119957 invoked by uid 89); 29 Mar 2019 13:35:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=2318, 1815 X-HELO: mail-vs1-f65.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=ZEkYwtszPa4+qOt5HcIDNp8sjxw2NpsJc0S5o4LA7uc=; b=HXD7LsDdshmxfZnm4ebtJ8OURx5yFEL9VMQOqenGsP/v6hrXx4VfIMCbA7LS2EghO/ 8e/FrU2OZnrxI5hKSNy+myvxHc3e2h6xCzHl2Z0aKNmmdWC3Rtkb0AGaLViaWwi0QkFG moHlkuemLgROyUq9cXp9qenMdAQEkWt2XYyIOcq50GutyR8KGbkqC46Nu5EiK+QtDLWo Au6BS9YMvy18hNtrYaUMip1UFANghoSuXVL1U3Ja9x+0+jSya+pm8ZpmwAaOC/quSyfJ EPSJ9ZjPSN8lmO+cQAhZQpZv+mLtRd+/i7G4/WQIMf65Xu16IldNfOW6FdBF1oTnkhKf zOig== Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 16/28] math: Use wordsize-64 version for finite Date: Fri, 29 Mar 2019 10:35:17 -0300 Message-Id: <20190329133529.22523-17-adhemerval.zanella@linaro.org> In-Reply-To: <20190329133529.22523-1-adhemerval.zanella@linaro.org> References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> - math.h will use compiler builtin for gcc 4.4+ when built without -fsignaling-nans and the builtin is expanded inline for all supported architectures. As an example, there is no intra finite call on libm for the architecture I checked (x86, arm, aarch64, and powerpc). - The resulting binary difference on 32 bits architecture is minimum for the non hotspot symbol. - It helps wordsize-64 architectures that use ldbl-opt. - It add some code simplification with reduction of duplicated implementations. Checked on powerpc-linux-gnu (built without --with-cpu, with --with-cpu=power4 and with --with-cpu=power5+ and --disable-multi-arch), powerpc64-linux-gnu (built without --with-cp and with --with-cpu=power5+ and --disable-multi-arch). * sysdeps/ieee754/dbl-64/wordsize-64/s_finite.c: Move to ... * sysdeps/ieee754/dbl-64/s_finite.c: ... here and format code. --- sysdeps/ieee754/dbl-64/s_finite.c | 22 +++------- sysdeps/ieee754/dbl-64/wordsize-64/s_finite.c | 43 ------------------- 2 files changed, 7 insertions(+), 58 deletions(-) delete mode 100644 sysdeps/ieee754/dbl-64/wordsize-64/s_finite.c -- 2.17.1 diff --git a/sysdeps/ieee754/dbl-64/s_finite.c b/sysdeps/ieee754/dbl-64/s_finite.c index da1519b1d0..98a40fbff6 100644 --- a/sysdeps/ieee754/dbl-64/s_finite.c +++ b/sysdeps/ieee754/dbl-64/s_finite.c @@ -1,4 +1,3 @@ -/* @(#)s_finite.c 5.1 93/09/24 */ /* * ==================================================== * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. @@ -10,10 +9,6 @@ * ==================================================== */ -#if defined(LIBM_SCCS) && !defined(lint) -static char rcsid[] = "$NetBSD: s_finite.c,v 1.8 1995/05/10 20:47:17 jtc Exp $"; -#endif - /* * finite(x) returns 1 is x is finite, else 0; * no branching! @@ -23,18 +18,15 @@ static char rcsid[] = "$NetBSD: s_finite.c,v 1.8 1995/05/10 20:47:17 jtc Exp $"; #include #include #include +#include -#undef __finite - -#ifndef FINITE -# define FINITE __finite -#endif - -int FINITE(double x) +int +__finite (double x) { - int32_t hx; - GET_HIGH_WORD (hx, x); - return (int) ((uint32_t) ((hx & 0x7ff00000) - 0x7ff00000) >> 31); + int64_t lx; + EXTRACT_WORDS64 (lx,x); + return (int)((uint64_t)((lx & INT64_C(0x7ff0000000000000)) + - INT64_C (0x7ff0000000000000)) >> 63); } hidden_def (__finite) weak_alias (__finite, finite) diff --git a/sysdeps/ieee754/dbl-64/wordsize-64/s_finite.c b/sysdeps/ieee754/dbl-64/wordsize-64/s_finite.c deleted file mode 100644 index 40676924fe..0000000000 --- a/sysdeps/ieee754/dbl-64/wordsize-64/s_finite.c +++ /dev/null @@ -1,43 +0,0 @@ -/* - * ==================================================== - * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. - * - * Developed at SunPro, a Sun Microsystems, Inc. business. - * Permission to use, copy, modify, and distribute this - * software is freely granted, provided that this notice - * is preserved. - * ==================================================== - */ - -/* - * finite(x) returns 1 is x is finite, else 0; - * no branching! - */ - -#include -#include -#include -#include -#include - -#undef __finite -int -__finite(double x) -{ - int64_t lx; - EXTRACT_WORDS64(lx,x); - return (int)((uint64_t)((lx&INT64_C(0x7ff0000000000000))-INT64_C(0x7ff0000000000000))>>63); -} -hidden_def (__finite) -weak_alias (__finite, finite) -#ifdef NO_LONG_DOUBLE -# if LDBL_CLASSIFY_COMPAT -# if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_23) -compat_symbol (libc, __finite, __finitel, GLIBC_2_0); -# endif -# if SHLIB_COMPAT (libm, GLIBC_2_1, GLIBC_2_23) -compat_symbol (libm, __finite, __finitel, GLIBC_2_1); -# endif -# endif -weak_alias (__finite, finitel) -#endif