diff mbox series

[v2,1/3] dt-bindings: gpu: Add ASPEED GFX bindings document

Message ID 20190402021933.13071-2-joel@jms.id.au
State Superseded
Headers show
Series drm: Add ASPEED BMC 'GFX' driver | expand

Commit Message

Joel Stanley April 2, 2019, 2:19 a.m. UTC
This describes the ASPEED BMC SoC's display controller.

Signed-off-by: Joel Stanley <joel@jms.id.au>

---
 .../devicetree/bindings/gpu/aspeed-gfx.txt    | 41 +++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpu/aspeed-gfx.txt

-- 
2.20.1

Comments

Andrew Jeffery April 2, 2019, 3:08 a.m. UTC | #1
On Tue, 2 Apr 2019, at 12:49, Joel Stanley wrote:
> This describes the ASPEED BMC SoC's display controller.

> 

> Signed-off-by: Joel Stanley <joel@jms.id.au>

> ---

>  .../devicetree/bindings/gpu/aspeed-gfx.txt    | 41 +++++++++++++++++++

>  1 file changed, 41 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/gpu/aspeed-gfx.txt

> 

> diff --git a/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt 

> b/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt

> new file mode 100644

> index 000000000000..a74033332668

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt

> @@ -0,0 +1,41 @@

> +Device tree configuration for the GFX display deivce on the AST2500 

> SoCs.

> +

> +Required properties:

> +  - compatible

> +    * Must be one of the following:

> +      + aspeed,ast2500-gfx

> +      + aspeed,ast2400-gfx

> +    * In addition, the ASPEED pinctrl bindings require the 'syscon' 

> property to

> +      be present


Lets remove [1] now that we have this document as what you've described
here is a super-set. Happy for that to be a follow-up patch, so:

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>


[1] Documentation/devicetree/bindings/mfd/aspeed-gfx.txt

> +

> +  - reg: Physical base address and length of the GFX registers

> +

> +  - interrupts: interrupt number for the GFX device

> +

> +  - clocks: clock number used to generate the pixel clock

> +

> +  - resets: reset line that must be released to use the GFX device

> +

> +  - memory-region:

> +    Phandle to a memory region to allocate from, as defined in

> +    

> Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt

> +

> +

> +Example:

> +

> +gfx: display@1e6e6000 {

> +	compatible = "aspeed,ast2500-gfx", "syscon";

> +	reg = <0x1e6e6000 0x1000>;

> +	reg-io-width = <4>;

> +	clocks = <&syscon ASPEED_CLK_GATE_D1CLK>;

> +	resets = <&syscon ASPEED_RESET_CRT1>;

> +	interrupts = <0x19>;

> +	memory-region = <&gfx_memory>;

> +};

> +

> +gfx_memory: framebuffer {

> +	size = <0x01000000>;

> +	alignment = <0x01000000>;

> +	compatible = "shared-dma-pool";

> +	reusable;

> +};

> -- 

> 2.20.1

> 

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt b/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt
new file mode 100644
index 000000000000..a74033332668
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpu/aspeed-gfx.txt
@@ -0,0 +1,41 @@ 
+Device tree configuration for the GFX display deivce on the AST2500 SoCs.
+
+Required properties:
+  - compatible
+    * Must be one of the following:
+      + aspeed,ast2500-gfx
+      + aspeed,ast2400-gfx
+    * In addition, the ASPEED pinctrl bindings require the 'syscon' property to
+      be present
+
+  - reg: Physical base address and length of the GFX registers
+
+  - interrupts: interrupt number for the GFX device
+
+  - clocks: clock number used to generate the pixel clock
+
+  - resets: reset line that must be released to use the GFX device
+
+  - memory-region:
+    Phandle to a memory region to allocate from, as defined in
+    Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
+
+
+Example:
+
+gfx: display@1e6e6000 {
+	compatible = "aspeed,ast2500-gfx", "syscon";
+	reg = <0x1e6e6000 0x1000>;
+	reg-io-width = <4>;
+	clocks = <&syscon ASPEED_CLK_GATE_D1CLK>;
+	resets = <&syscon ASPEED_RESET_CRT1>;
+	interrupts = <0x19>;
+	memory-region = <&gfx_memory>;
+};
+
+gfx_memory: framebuffer {
+	size = <0x01000000>;
+	alignment = <0x01000000>;
+	compatible = "shared-dma-pool";
+	reusable;
+};