From patchwork Tue Apr 2 04:03:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 161599 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp1257265jan; Mon, 1 Apr 2019 21:04:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyrkO+vQER9yqA2jbLPH1Y6hdLAwhA2/Ti0IU6qwFGbRo52Xfn/PQiTIU16cogPBHEtQHyB X-Received: by 2002:a62:3583:: with SMTP id c125mr24496759pfa.169.1554177863629; Mon, 01 Apr 2019 21:04:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554177863; cv=none; d=google.com; s=arc-20160816; b=y+XiZ98ikKfDC0iIqXZPIIgYdzNwJxe/ft486PB+iss8/FQMWpabzy6IPoFy7atCWu Gv7MWripa7PNHa2sqzyllMiCkZHWTzL8KdngCjdcnpvrXy2MT+eS5nEaB0bdpHBnQKJV lxdmSocZrFpuf6qlqszmPF/S46C1qmGBoUOildGcMlw6q3fgkxk8Cm0C0Ywt/5a6ueoe ZCvg1zIFSJpCpVPawzXYUvTQFEl581xEIVUgLLaLfkrHQE5z+1B+aOcLp1qe6eJAF0e+ x1EpuFHm5nbL9LjXSUt6YiBNNBYLsnoxIdNJyhS8A2+PvI3Phj+9GRX2B95bRZMQo+sX Jmqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter:dkim-signature; bh=W8TLWvrLBsyxjczJ0E+m66g5/PlSU12vnrjz2amdpG4=; b=cjt96ON8SgLdc/vBCy7C1A+aTZtCiEYTBUgF2CIX9WCCHI7+c2oHy77IjK4Q7iM/vS TDsQCTwkVWZTEeptKTdw76YW3f0beFFTeM81S8IiZA/vqKzjZcCGh9djZVxiG4HaDmG1 reenj0SENQu9nVYVdDVbkpZLQrGj8skK7as5ov5+wXQISfT/uu3W8f/pLtO47Vb3TTrZ ZznMvLPkuBY3rXSQIbLyhfOegnL27ykUbhAnYbI9mM0mbp0kzvDDbMO5dbg7gH72wKl8 ZoJYBQccQ02wk+X1q6OyVejvTe4DzY1xWIUhVSJdLxvAGeHJHnTfli5AcZBbuY7a1LpF 4AMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=JI+aMpJC; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=fGhsNWLk; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id o4si10281901pgr.158.2019.04.01.21.04.23 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 21:04:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=JI+aMpJC; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=fGhsNWLk; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=W8TLWvrLBsyxjczJ0E+m66g5/PlSU12vnrjz2amdpG4=; b=JI+aMpJC0OOhX0F2ySf9Md0Mxh +TxoKlnUL72/X2eAR1eoiOHp+xwKTT5HS3AJ1ykSWMT3iZzMlNBO7HZZchBGnU/gzH3EMHpXL8/Aj OrDc7ZYLrrjCNQ3XUJ4Ns2rmi3+agqetHeVRuhoIuriYEvlEm83nzN+5mFBQwcQj3l6yZff3UlC5E kMJcAlYGbIthznFFIoQSCeYx83ehcR13kYEpmSYat+kwuFS/pnVQu998Ko1cEuVYmXniMR5xOz7T2 znYnB3VDpuHp/HV2NmkkzXfAjoXpOGe2oVQWLgvtkVqgmph4yVujvmLPJ65LR8f18iqQdcoEftYtm pgR82DGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBAej-0000PX-S7; Tue, 02 Apr 2019 04:04:13 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBAeG-0008D0-1G for linux-mtd@lists.infradead.org; Tue, 02 Apr 2019 04:03:47 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3243HaZ021871; Tue, 2 Apr 2019 13:03:23 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3243HaZ021871 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1554177804; bh=dTKU5woaZ+/VtCj4y62Lf6G8K4/FvWqomirsTxXN8f8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fGhsNWLkf9bQ52JgYGLYvF/50waWpHpGFxUAHW+l9uv1T2vdI6WLZmNHH/x2C1nov pVKVjHeUZOig3mam//M442LqP3WCsWla01BagPi072LzZe5/U73BeLZcAEQnQiYFJT pJQahn9G6WIiSrQ/+APrJ3/MKg4tGhZ4x9za25ul+L8bwHCdF3SvcKr/XzuDkWOXUB hOd1BDpzu3chPIh1hQeNUfzhhIQeMwUlYPzF9J0xVkMvHzV6tp5pQ65h0aZlzgnIYI WkOnGIF4QXT+ebwbGQ+GQHzmGMR2pGWMkL1rBNNdmylEBlbsRNkGkINC/4c9qYGxdh reycrB+VJVgVQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Subject: [PATCH v5 6/9] mtd: rawnand: denali_pci: rename goto labels Date: Tue, 2 Apr 2019 13:03:06 +0900 Message-Id: <1554177789-15414-7-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1554177789-15414-1-git-send-email-yamada.masahiro@socionext.com> References: <1554177789-15414-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_210344_382236_FACB898D X-CRM114-Status: GOOD ( 11.35 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [210.131.2.74 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [210.131.2.74 listed in wl.mailspike.net] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org As Documentation/process/coding-style.rst says, choose label names which say what the goto does. The out_ label style is already used in denali_dt.c. Rename likewise for denali_pci.c Signed-off-by: Masahiro Yamada --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/denali_pci.c index 48e9ac5..02eb599 100644 --- a/drivers/mtd/nand/raw/denali_pci.c +++ b/drivers/mtd/nand/raw/denali_pci.c @@ -84,20 +84,20 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) if (!denali->host) { dev_err(&dev->dev, "Spectra: ioremap_nocache failed!"); ret = -ENOMEM; - goto failed_remap_reg; + goto out_unmap_reg; } ret = denali_init(denali); if (ret) - goto failed_remap_mem; + goto out_unmap_host; pci_set_drvdata(dev, denali); return 0; -failed_remap_mem: +out_unmap_host: iounmap(denali->host); -failed_remap_reg: +out_unmap_reg: iounmap(denali->reg); return ret; }