[v4,2/4] coresight: replicator: Add new device id for static replicator

Message ID 20190406112145.15184-3-leo.yan@linaro.org
State New
Headers show
Series
  • Untitled series #19724
Related show

Commit Message

Leo Yan April 6, 2019, 11:21 a.m.
This patch adds a device id for the new static replicator compatible
string; it changes the driver name from "coresight-replicator" to
"coresight-static-replicator" as well.

Signed-off-by: Leo Yan <leo.yan@linaro.org>

---
 drivers/hwtracing/coresight/coresight-replicator.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.1

Comments

Suzuki K Poulose April 8, 2019, 10:46 a.m. | #1
On 04/06/2019 12:21 PM, Leo Yan wrote:
> This patch adds a device id for the new static replicator compatible

> string; it changes the driver name from "coresight-replicator" to

> "coresight-static-replicator" as well.

> 

> Signed-off-by: Leo Yan <leo.yan@linaro.org>

> ---

>   drivers/hwtracing/coresight/coresight-replicator.c | 3 ++-

>   1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c

> index 4e0da85efd2d..e6a03642bbdb 100644

> --- a/drivers/hwtracing/coresight/coresight-replicator.c

> +++ b/drivers/hwtracing/coresight/coresight-replicator.c

> @@ -285,13 +285,14 @@ static const struct dev_pm_ops replicator_dev_pm_ops = {

>   

>   static const struct of_device_id static_replicator_match[] = {

>   	{.compatible = "arm,coresight-replicator"},

> +	{.compatible = "arm,coresight-static-replicator"},

>   	{}


As mentioned in the previous patch, please could you add a warning if
you encounter the old binding, mentioning that it is OBSOLETE.
pr_warn_once() is sufficient.

Otherwise, looks good.

Suzuki

Patch

diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
index 4e0da85efd2d..e6a03642bbdb 100644
--- a/drivers/hwtracing/coresight/coresight-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-replicator.c
@@ -285,13 +285,14 @@  static const struct dev_pm_ops replicator_dev_pm_ops = {
 
 static const struct of_device_id static_replicator_match[] = {
 	{.compatible = "arm,coresight-replicator"},
+	{.compatible = "arm,coresight-static-replicator"},
 	{}
 };
 
 static struct platform_driver static_replicator_driver = {
 	.probe          = static_replicator_probe,
 	.driver         = {
-		.name   = "coresight-replicator",
+		.name   = "coresight-static-replicator",
 		.of_match_table = static_replicator_match,
 		.pm	= &replicator_dev_pm_ops,
 		.suppress_bind_attrs = true,