| Message ID | dfb046a881d254f5133e6a1f86a04f49e73c56f9.1554718622.git.viresh.kumar@linaro.org |
|---|---|
| State | Accepted |
| Commit | c1d1090c3c7674c965552e22a65b29423aa4f090 |
| Headers | show |
| Series | cpufreq: maple: Remove redundant code from maple_cpufreq_init() | expand |
On Monday, April 8, 2019 12:17:06 PM CEST Viresh Kumar wrote: > The success path and error path both look the same, don't duplicate the > code. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/maple-cpufreq.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/cpufreq/maple-cpufreq.c > b/drivers/cpufreq/maple-cpufreq.c index a05f1342ec02..a94355723ef8 100644 > --- a/drivers/cpufreq/maple-cpufreq.c > +++ b/drivers/cpufreq/maple-cpufreq.c > @@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void) > > rc = cpufreq_register_driver(&maple_cpufreq_driver); > > - of_node_put(cpunode); > - > - return rc; > - > bail_noprops: > of_node_put(cpunode); Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> I'm assuming this to land in your tree.
On 08-04-19, 12:41, Rafael J. Wysocki wrote: > On Monday, April 8, 2019 12:17:06 PM CEST Viresh Kumar wrote: > > The success path and error path both look the same, don't duplicate the > > code. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > drivers/cpufreq/maple-cpufreq.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/cpufreq/maple-cpufreq.c > > b/drivers/cpufreq/maple-cpufreq.c index a05f1342ec02..a94355723ef8 100644 > > --- a/drivers/cpufreq/maple-cpufreq.c > > +++ b/drivers/cpufreq/maple-cpufreq.c > > @@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void) > > > > rc = cpufreq_register_driver(&maple_cpufreq_driver); > > > > - of_node_put(cpunode); > > - > > - return rc; > > - > > bail_noprops: > > of_node_put(cpunode); > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > I'm assuming this to land in your tree. Yes, applied now. Thanks. -- viresh
diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c index a05f1342ec02..a94355723ef8 100644 --- a/drivers/cpufreq/maple-cpufreq.c +++ b/drivers/cpufreq/maple-cpufreq.c @@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void) rc = cpufreq_register_driver(&maple_cpufreq_driver); - of_node_put(cpunode); - - return rc; - bail_noprops: of_node_put(cpunode);
The success path and error path both look the same, don't duplicate the code. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/maple-cpufreq.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.21.0.rc0.269.g1a574e7a288b