| Message ID | b991a4d0e6c4253bc08b2794c6084be55fc72e1d.1554851834.git.crobinso@redhat.com |
|---|---|
| State | Accepted |
| Commit | aded9dfa74a83f8b235df1bd3a874e48e197c78e |
| Headers | show |
| Series | migration: savevm: fix error code with migration blockers | expand |
* Cole Robinson (crobinso@redhat.com) wrote: > The only caller that checks the error code is looking for != 0, > so returning false is incorrect. > > Fixes: 5aaac467938 "migration: savevm: consult migration blockers" > > Signed-off-by: Cole Robinson <crobinso@redhat.com> Thanks, this was in 3.1.0 so isn't a 4.0 regression, so it'll have to wait for 4.1. Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > migration/savevm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/savevm.c b/migration/savevm.c > index 34bcad3807..a3dae4cf02 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp) > AioContext *aio_context; > > if (migration_is_blocked(errp)) { > - return false; > + return ret; > } > > if (!replay_can_snapshot()) { > -- > 2.21.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Cole Robinson <crobinso@redhat.com> wrote: > The only caller that checks the error code is looking for != 0, > so returning false is incorrect. > > Fixes: 5aaac467938 "migration: savevm: consult migration blockers" > > Signed-off-by: Cole Robinson <crobinso@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
* Cole Robinson (crobinso@redhat.com) wrote: > The only caller that checks the error code is looking for != 0, > so returning false is incorrect. > > Fixes: 5aaac467938 "migration: savevm: consult migration blockers" > > Signed-off-by: Cole Robinson <crobinso@redhat.com> Queued > --- > migration/savevm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/savevm.c b/migration/savevm.c > index 34bcad3807..a3dae4cf02 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp) > AioContext *aio_context; > > if (migration_is_blocked(errp)) { > - return false; > + return ret; > } > > if (!replay_can_snapshot()) { > -- > 2.21.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/migration/savevm.c b/migration/savevm.c index 34bcad3807..a3dae4cf02 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp) AioContext *aio_context; if (migration_is_blocked(errp)) { - return false; + return ret; } if (!replay_can_snapshot()) {
The only caller that checks the error code is looking for != 0, so returning false is incorrect. Fixes: 5aaac467938 "migration: savevm: consult migration blockers" Signed-off-by: Cole Robinson <crobinso@redhat.com> --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.21.0