| Message ID | 20190416123148.3502045-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | kmemleak: fix unused-function warning | expand |
On Tue, Apr 16, 2019 at 02:31:24PM +0200, Arnd Bergmann wrote: > The only references outside of the #ifdef have been removed, > so now we get a warning in non-SMP configurations: > > mm/kmemleak.c:1404:13: error: unused function 'scan_large_block' [-Werror,-Wunused-function] > > Add a new #ifdef around it. > > Fixes: 298a32b13208 ("kmemleak: powerpc: skip scanning holes in the .bss section") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 6c318f5ac234..2e435b8142e5 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1401,6 +1401,7 @@ static void scan_block(void *_start, void *_end, /* * Scan a large memory block in MAX_SCAN_SIZE chunks to reduce the latency. */ +#ifdef CONFIG_SMP static void scan_large_block(void *start, void *end) { void *next; @@ -1412,6 +1413,7 @@ static void scan_large_block(void *start, void *end) cond_resched(); } } +#endif /* * Scan a memory block corresponding to a kmemleak_object. A condition is
The only references outside of the #ifdef have been removed, so now we get a warning in non-SMP configurations: mm/kmemleak.c:1404:13: error: unused function 'scan_large_block' [-Werror,-Wunused-function] Add a new #ifdef around it. Fixes: 298a32b13208 ("kmemleak: powerpc: skip scanning holes in the .bss section") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- mm/kmemleak.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.0