[3/7] mmc: meson-gx: irq is not shared

Message ID 20190417204355.469-4-jbrunet@baylibre.com
State New
Headers show
Series
  • mmc: meson-gx: clean up and tuning update
Related show

Commit Message

Jerome Brunet April 17, 2019, 8:43 p.m.
There is no reason for another device to request the MMC irq. It should
only be used the MMC device.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

---
 drivers/mmc/host/meson-gx-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Martin Blumenstingl April 18, 2019, 7:52 p.m. | #1
Hi Jerome,

On Wed, Apr 17, 2019 at 10:44 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
>

> There is no reason for another device to request the MMC irq. It should

> only be used the MMC device.

>

> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>

> ---

>  drivers/mmc/host/meson-gx-mmc.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c

> index 8b690ecde4c5..3df50b53f834 100644

> --- a/drivers/mmc/host/meson-gx-mmc.c

> +++ b/drivers/mmc/host/meson-gx-mmc.c

> @@ -1328,7 +1328,7 @@ static int meson_mmc_probe(struct platform_device *pdev)

>                host->regs + SD_EMMC_IRQ_EN);

>

>         ret = request_threaded_irq(host->irq, meson_mmc_irq,

> -                                  meson_mmc_irq_thread, IRQF_SHARED,

> +                                  meson_mmc_irq_thread, IRQF_ONESHOT,

>                                    dev_name(&pdev->dev), host);

the commit message reads as if the intention is to remove the IRQF_SHARED flag.
however, the commit message doesn't mention IRQF_ONESHOT (which was
not set before).

if you used IRQF_ONESHOT on purpose then please mention it in the
patch description.


Martin

Patch

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 8b690ecde4c5..3df50b53f834 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1328,7 +1328,7 @@  static int meson_mmc_probe(struct platform_device *pdev)
 	       host->regs + SD_EMMC_IRQ_EN);
 
 	ret = request_threaded_irq(host->irq, meson_mmc_irq,
-				   meson_mmc_irq_thread, IRQF_SHARED,
+				   meson_mmc_irq_thread, IRQF_ONESHOT,
 				   dev_name(&pdev->dev), host);
 	if (ret)
 		goto err_init_clk;