| Message ID | 20190423211932.4906-1-ndesaulniers@google.com |
|---|---|
| State | Accepted |
| Commit | 95b6204dbf703f2b6da27cec4c8280f43da8977d |
| Headers | show |
| Series | nds32: vdso: drop unnecessary cc-ldoption | expand |
Hi Nick & Yamada, Nick Desaulniers <ndesaulniers@google.com> 於 2019年4月24日 週三 上午5:19寫道： > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > of binutils for the kernel according to > Documentation/process/changes.rst is 2.20. > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > Cc: clang-built-linux@googlegroups.com > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/nds32/kernel/vdso/Makefile | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile > index e6c50a701313..d379645cad74 100644 > --- a/arch/nds32/kernel/vdso/Makefile > +++ b/arch/nds32/kernel/vdso/Makefile > @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o > targets := $(obj-vdso) vdso.so vdso.so.dbg > obj-vdso := $(addprefix $(obj)/, $(obj-vdso)) > > -ccflags-y := -shared -fno-common -fno-builtin > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \ > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > -ccflags-y += -fPIC -Wl,-shared -g > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \ > + -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv > > # Disable gcov profiling for VDSO code > GCOV_PROFILE := n Thank you. Acked-by: Greentime Hu <greentime@andestech.com>
On Wed, Apr 24, 2019 at 3:59 PM Greentime Hu <green.hu@gmail.com> wrote: > > Hi Nick & Yamada, > > Nick Desaulniers <ndesaulniers@google.com> 於 2019年4月24日 週三 上午5:19寫道： > > > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > > of binutils for the kernel according to > > Documentation/process/changes.rst is 2.20. > > > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > > Cc: clang-built-linux@googlegroups.com > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > --- > > arch/nds32/kernel/vdso/Makefile | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile > > index e6c50a701313..d379645cad74 100644 > > --- a/arch/nds32/kernel/vdso/Makefile > > +++ b/arch/nds32/kernel/vdso/Makefile > > @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o > > targets := $(obj-vdso) vdso.so vdso.so.dbg > > obj-vdso := $(addprefix $(obj)/, $(obj-vdso)) > > > > -ccflags-y := -shared -fno-common -fno-builtin > > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \ > > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > > -ccflags-y += -fPIC -Wl,-shared -g > > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \ > > + -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv > > > > # Disable gcov profiling for VDSO code > > GCOV_PROFILE := n > > Thank you. > Acked-by: Greentime Hu <greentime@andestech.com> Who do you expect to pick up this patch? You are the NDS32 maintainer according to MAINTAINERS. ANDES ARCHITECTURE M: Greentime Hu <green.hu@gmail.com> M: Vincent Chen <deanbo422@gmail.com> T: git https://github.com/andestech/linux.git S: Supported F: arch/nds32/ F: Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt F: Documentation/devicetree/bindings/nds32/ K: nds32 N: nds32 You do not maintain https://github.com/andestech/linux.git any more, do you? -- Best Regards Masahiro Yamada
Masahiro Yamada <yamada.masahiro@socionext.com> 於 2019年4月24日 週三 下午3:54寫道： > > On Wed, Apr 24, 2019 at 3:59 PM Greentime Hu <green.hu@gmail.com> wrote: > > > > Hi Nick & Yamada, > > > > Nick Desaulniers <ndesaulniers@google.com> 於 2019年4月24日 週三 上午5:19寫道： > > > > > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > > > of binutils for the kernel according to > > > Documentation/process/changes.rst is 2.20. > > > > > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > > > Cc: clang-built-linux@googlegroups.com > > > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > > --- > > > arch/nds32/kernel/vdso/Makefile | 6 ++---- > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile > > > index e6c50a701313..d379645cad74 100644 > > > --- a/arch/nds32/kernel/vdso/Makefile > > > +++ b/arch/nds32/kernel/vdso/Makefile > > > @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o > > > targets := $(obj-vdso) vdso.so vdso.so.dbg > > > obj-vdso := $(addprefix $(obj)/, $(obj-vdso)) > > > > > > -ccflags-y := -shared -fno-common -fno-builtin > > > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \ > > > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > > > -ccflags-y += -fPIC -Wl,-shared -g > > > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \ > > > + -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv > > > > > > # Disable gcov profiling for VDSO code > > > GCOV_PROFILE := n > > > > Thank you. > > Acked-by: Greentime Hu <greentime@andestech.com> > > > Who do you expect to pick up this patch? > > You are the NDS32 maintainer > according to MAINTAINERS. > > > ANDES ARCHITECTURE > M: Greentime Hu <green.hu@gmail.com> > M: Vincent Chen <deanbo422@gmail.com> > T: git https://github.com/andestech/linux.git > S: Supported > F: arch/nds32/ > F: Documentation/devicetree/bindings/interrupt-controller/andestech,ativic32.txt > F: Documentation/devicetree/bindings/nds32/ > K: nds32 > N: nds32 > > > You do not maintain https://github.com/andestech/linux.git any more, do you? Hi Yamada, I think I should update this MAINTAINERS file. I will pick it in this repo https://git.kernel.org/pub/scm/linux/kernel/git/greentime/linux.git
diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile index e6c50a701313..d379645cad74 100644 --- a/arch/nds32/kernel/vdso/Makefile +++ b/arch/nds32/kernel/vdso/Makefile @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o targets := $(obj-vdso) vdso.so vdso.so.dbg obj-vdso := $(addprefix $(obj)/, $(obj-vdso)) -ccflags-y := -shared -fno-common -fno-builtin -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \ - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) -ccflags-y += -fPIC -Wl,-shared -g +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \ + -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv # Disable gcov profiling for VDSO code GCOV_PROFILE := n
Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20. Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html Cc: clang-built-linux@googlegroups.com Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/nds32/kernel/vdso/Makefile | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.21.0.593.g511ec345e18-goog