ASoC: Intel: bytcht_es8316: fix cast warning

Message ID 20190424114114.27073-1-anders.roxell@linaro.org
State New
Headers show
Series
  • ASoC: Intel: bytcht_es8316: fix cast warning
Related show

Commit Message

Anders Roxell April 24, 2019, 11:41 a.m.
When building bytcht_es8316 the following warning shows up:

../sound/soc/intel/boards/bytcht_es8316.c: In function ‘snd_byt_cht_es8316_mc_probe’:
../sound/soc/intel/boards/bytcht_es8316.c:508:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   quirk = (int)dmi_id->driver_data;
           ^

Rework to use uintptr_t instead of int.

Fixes: a8d218f4fe81 ("ASoC: Intel: bytcht_es8316: Add quirk for the Teclast X98+ II")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 sound/soc/intel/boards/bytcht_es8316.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Pierre-Louis Bossart April 24, 2019, 11:13 p.m. | #1
On 4/24/19 6:41 AM, Anders Roxell wrote:
> When building bytcht_es8316 the following warning shows up:

> 

> ../sound/soc/intel/boards/bytcht_es8316.c: In function ‘snd_byt_cht_es8316_mc_probe’:

> ../sound/soc/intel/boards/bytcht_es8316.c:508:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

>     quirk = (int)dmi_id->driver_data;

>             ^

> 

> Rework to use uintptr_t instead of int.

> 

> Fixes: a8d218f4fe81 ("ASoC: Intel: bytcht_es8316: Add quirk for the Teclast X98+ II")

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>


I submitted an alternate fix last Friday to alsa-devel, along with 2 
additional patches to handle the quirk_override in the same way between 
machine drivers.
Anders Roxell April 25, 2019, 7:08 a.m. | #2
On Thu, 25 Apr 2019 at 01:13, Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>

> On 4/24/19 6:41 AM, Anders Roxell wrote:

> > When building bytcht_es8316 the following warning shows up:

> >

> > ../sound/soc/intel/boards/bytcht_es8316.c: In function ‘snd_byt_cht_es8316_mc_probe’:

> > ../sound/soc/intel/boards/bytcht_es8316.c:508:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

> >     quirk = (int)dmi_id->driver_data;

> >             ^

> >

> > Rework to use uintptr_t instead of int.

> >

> > Fixes: a8d218f4fe81 ("ASoC: Intel: bytcht_es8316: Add quirk for the Teclast X98+ II")

> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

>

> I submitted an alternate fix last Friday to alsa-devel, along with 2

> additional patches to handle the quirk_override in the same way between

> machine drivers.


OK, yes your patch address the problem.

Cheers,
Anders

Patch

diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
index 38975827e276..68136ba1519e 100644
--- a/sound/soc/intel/boards/bytcht_es8316.c
+++ b/sound/soc/intel/boards/bytcht_es8316.c
@@ -505,7 +505,7 @@  static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
 	/* Check for BYTCR or other platform and setup quirks */
 	dmi_id = dmi_first_match(byt_cht_es8316_quirk_table);
 	if (dmi_id) {
-		quirk = (int)dmi_id->driver_data;
+		quirk = (uintptr_t)dmi_id->driver_data;
 	} else if (x86_match_cpu(baytrail_cpu_ids) &&
 	    mach->mach_params.acpi_ipc_irq_index == 0) {
 		/* On BYTCR default to SSP0, internal-mic-in2-map, mono-spk */