[01/14] soundwire: fix kconfig help format

Message ID 20190502105930.9889-2-vkoul@kernel.org
State Accepted
Commit 92fd75f103248f9dff32ad8ca8cc6d1c05756712
Headers show
Series
  • soundwire: more code cleanups
Related show

Commit Message

Vinod Koul May 2, 2019, 10:59 a.m.
Move to help format instead of --help-- as that is not recommended and
this makes file consistent with other instance

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---
 drivers/soundwire/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Comments

Greg Kroah-Hartman May 2, 2019, 3:07 p.m. | #1
On Thu, May 02, 2019 at 04:29:17PM +0530, Vinod Koul wrote:
> Move to help format instead of --help-- as that is not recommended and

> this makes file consistent with other instance

> 

> Signed-off-by: Vinod Koul <vkoul@kernel.org>

> ---

>  drivers/soundwire/Kconfig | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig

> index 84876a74874f..53b55b79c4af 100644

> --- a/drivers/soundwire/Kconfig

> +++ b/drivers/soundwire/Kconfig

> @@ -28,7 +28,7 @@ config SOUNDWIRE_INTEL

>  	select SOUNDWIRE_CADENCE

>  	select SOUNDWIRE_BUS

>  	depends on X86 && ACPI && SND_SOC

> -	---help---

> +	help

>  	  SoundWire Intel Master driver.

>  	  If you have an Intel platform which has a SoundWire Master then

>  	  enable this config option to get the SoundWire support for that

> -- 

> 2.20.1

> 


Huh?

Pierre-Louis sent this patch before you did.  Why did you just rewrite
the changelog text a bit and then ignore his authorship and
signed-off-by?

That's a really really shitty thing to do, I'm going to go take his
version of these patches instead, let me see how they line up...

greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Vinod Koul May 2, 2019, 3:15 p.m. | #2
On 02-05-19, 17:07, Greg KH wrote:
> On Thu, May 02, 2019 at 04:29:17PM +0530, Vinod Koul wrote:

> > Move to help format instead of --help-- as that is not recommended and

> > this makes file consistent with other instance

> > 

> > Signed-off-by: Vinod Koul <vkoul@kernel.org>

> > ---

> >  drivers/soundwire/Kconfig | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > 

> > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig

> > index 84876a74874f..53b55b79c4af 100644

> > --- a/drivers/soundwire/Kconfig

> > +++ b/drivers/soundwire/Kconfig

> > @@ -28,7 +28,7 @@ config SOUNDWIRE_INTEL

> >  	select SOUNDWIRE_CADENCE

> >  	select SOUNDWIRE_BUS

> >  	depends on X86 && ACPI && SND_SOC

> > -	---help---

> > +	help

> >  	  SoundWire Intel Master driver.

> >  	  If you have an Intel platform which has a SoundWire Master then

> >  	  enable this config option to get the SoundWire support for that

> > -- 

> > 2.20.1

> > 

> 

> Huh?

> 

> Pierre-Louis sent this patch before you did.  Why did you just rewrite

> the changelog text a bit and then ignore his authorship and

> signed-off-by?


This is not *that* instance! The one Pierre changed was for symbol
"SOUNDWIRE" and is already applied [1] this is for SOUNDWIRE_INTEL which
is another instance. If you have looked or cared, even the log mentions
"makes file consistent with other instance" 

This series is on *top* on the "whole" series from Pierre

> That's a really really shitty thing to do, I'm going to go take his

> version of these patches instead, let me see how they line up...


Honestly, this is a terrible accusation, seems everyone is quick to jump
and yell at others. I asking for an apology.

-- 
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Greg Kroah-Hartman May 2, 2019, 3:15 p.m. | #3
On Thu, May 02, 2019 at 05:07:54PM +0200, Greg KH wrote:
> On Thu, May 02, 2019 at 04:29:17PM +0530, Vinod Koul wrote:

> > Move to help format instead of --help-- as that is not recommended and

> > this makes file consistent with other instance

> > 

> > Signed-off-by: Vinod Koul <vkoul@kernel.org>

> > ---

> >  drivers/soundwire/Kconfig | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > 

> > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig

> > index 84876a74874f..53b55b79c4af 100644

> > --- a/drivers/soundwire/Kconfig

> > +++ b/drivers/soundwire/Kconfig

> > @@ -28,7 +28,7 @@ config SOUNDWIRE_INTEL

> >  	select SOUNDWIRE_CADENCE

> >  	select SOUNDWIRE_BUS

> >  	depends on X86 && ACPI && SND_SOC

> > -	---help---

> > +	help

> >  	  SoundWire Intel Master driver.

> >  	  If you have an Intel platform which has a SoundWire Master then

> >  	  enable this config option to get the SoundWire support for that

> > -- 

> > 2.20.1

> > 

> 

> Huh?

> 

> Pierre-Louis sent this patch before you did.  Why did you just rewrite

> the changelog text a bit and then ignore his authorship and

> signed-off-by?

> 

> That's a really really shitty thing to do, I'm going to go take his

> version of these patches instead, let me see how they line up...


Ok, my apologies, that was incorrect.  Your patch was against a
different file than his.

Way to go and make this a total mess to try to figure out, let me see
what I can do...

greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Greg Kroah-Hartman May 2, 2019, 3:20 p.m. | #4
On Thu, May 02, 2019 at 08:45:02PM +0530, Vinod Koul wrote:
> > That's a really really shitty thing to do, I'm going to go take his

> > version of these patches instead, let me see how they line up...

> 

> Honestly, this is a terrible accusation, seems everyone is quick to jump

> and yell at others. I asking for an apology.


Our emails crossed, I already sent it, sorry about that.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Vinod Koul May 2, 2019, 3:21 p.m. | #5
On 02-05-19, 17:15, Greg KH wrote:
> On Thu, May 02, 2019 at 05:07:54PM +0200, Greg KH wrote:

> > On Thu, May 02, 2019 at 04:29:17PM +0530, Vinod Koul wrote:

> > > Move to help format instead of --help-- as that is not recommended and

> > > this makes file consistent with other instance

> > > 

> > > Signed-off-by: Vinod Koul <vkoul@kernel.org>

> > > ---

> > >  drivers/soundwire/Kconfig | 2 +-

> > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > 

> > > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig

> > > index 84876a74874f..53b55b79c4af 100644

> > > --- a/drivers/soundwire/Kconfig

> > > +++ b/drivers/soundwire/Kconfig

> > > @@ -28,7 +28,7 @@ config SOUNDWIRE_INTEL

> > >  	select SOUNDWIRE_CADENCE

> > >  	select SOUNDWIRE_BUS

> > >  	depends on X86 && ACPI && SND_SOC

> > > -	---help---

> > > +	help

> > >  	  SoundWire Intel Master driver.

> > >  	  If you have an Intel platform which has a SoundWire Master then

> > >  	  enable this config option to get the SoundWire support for that

> > > -- 

> > > 2.20.1

> > > 

> > 

> > Huh?

> > 

> > Pierre-Louis sent this patch before you did.  Why did you just rewrite

> > the changelog text a bit and then ignore his authorship and

> > signed-off-by?

> > 

> > That's a really really shitty thing to do, I'm going to go take his

> > version of these patches instead, let me see how they line up...

> 

> Ok, my apologies, that was incorrect.  Your patch was against a

> different file than his.


Yes and our emails crossed, apology accepted.
> 

> Way to go and make this a total mess to try to figure out, let me see

> what I can do...


If you can hold off for a bit longer, I have patches in next (pierre's
full series and couple of then split and ofcourse authorship retain
(https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git/log/?h=next)
and mine on top
(https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git/log/?h=checkpatch_fixes)

I can send you a signed PR for both and you can merged them. otherwise
the style changes will conflict and defeat the whole purpose..

Let me know if that is okay, thanks

-- 
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Greg Kroah-Hartman May 2, 2019, 4:35 p.m. | #6
On Thu, May 02, 2019 at 08:51:46PM +0530, Vinod Koul wrote:
> On 02-05-19, 17:15, Greg KH wrote:

> > On Thu, May 02, 2019 at 05:07:54PM +0200, Greg KH wrote:

> > > On Thu, May 02, 2019 at 04:29:17PM +0530, Vinod Koul wrote:

> > > > Move to help format instead of --help-- as that is not recommended and

> > > > this makes file consistent with other instance

> > > > 

> > > > Signed-off-by: Vinod Koul <vkoul@kernel.org>

> > > > ---

> > > >  drivers/soundwire/Kconfig | 2 +-

> > > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > > 

> > > > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig

> > > > index 84876a74874f..53b55b79c4af 100644

> > > > --- a/drivers/soundwire/Kconfig

> > > > +++ b/drivers/soundwire/Kconfig

> > > > @@ -28,7 +28,7 @@ config SOUNDWIRE_INTEL

> > > >  	select SOUNDWIRE_CADENCE

> > > >  	select SOUNDWIRE_BUS

> > > >  	depends on X86 && ACPI && SND_SOC

> > > > -	---help---

> > > > +	help

> > > >  	  SoundWire Intel Master driver.

> > > >  	  If you have an Intel platform which has a SoundWire Master then

> > > >  	  enable this config option to get the SoundWire support for that

> > > > -- 

> > > > 2.20.1

> > > > 

> > > 

> > > Huh?

> > > 

> > > Pierre-Louis sent this patch before you did.  Why did you just rewrite

> > > the changelog text a bit and then ignore his authorship and

> > > signed-off-by?

> > > 

> > > That's a really really shitty thing to do, I'm going to go take his

> > > version of these patches instead, let me see how they line up...

> > 

> > Ok, my apologies, that was incorrect.  Your patch was against a

> > different file than his.

> 

> Yes and our emails crossed, apology accepted.

> > 

> > Way to go and make this a total mess to try to figure out, let me see

> > what I can do...

> 

> If you can hold off for a bit longer, I have patches in next (pierre's

> full series and couple of then split and ofcourse authorship retain

> (https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git/log/?h=next)

> and mine on top

> (https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire.git/log/?h=checkpatch_fixes)

> 

> I can send you a signed PR for both and you can merged them. otherwise

> the style changes will conflict and defeat the whole purpose..

> 

> Let me know if that is okay, thanks


Send me the pull request and let's see how bad things are messed up :)

thanks,

greg k-h
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Patch

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index 84876a74874f..53b55b79c4af 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -28,7 +28,7 @@  config SOUNDWIRE_INTEL
 	select SOUNDWIRE_CADENCE
 	select SOUNDWIRE_BUS
 	depends on X86 && ACPI && SND_SOC
-	---help---
+	help
 	  SoundWire Intel Master driver.
 	  If you have an Intel platform which has a SoundWire Master then
 	  enable this config option to get the SoundWire support for that