From patchwork Mon May 6 17:28:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 163417 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:81:0:0:0:0 with SMTP id l1csp248501ilm; Mon, 6 May 2019 10:31:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqym0S6QE4ufAmQcImeCG5Iym1yCBLda2hihDpBrIwLsVsMij2alkta+m/4fFfKn4c4Q1ApU X-Received: by 2002:a63:fd16:: with SMTP id d22mr34061572pgh.426.1557163872925; Mon, 06 May 2019 10:31:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557163872; cv=none; d=google.com; s=arc-20160816; b=wsOeKRinCYxjJrDajJUe3uojAHugQuX+LegOwinCDCXgrxTIK+aP+KDnSzUfIUWgT2 CZs2gUrDbSwKVJA+48g9TjeG765eqvjYIdXwMAKD8GxI8WJU1VTynnLRR9wrn5jOIc9p YH0zs64HVnaoeVfp9lPOOEAV7Vnu+qJvxzffkzzqhp3neOivQjv7JBXoayHThpX5Zwgk uC8beSa4uK3Yx8y0vl9VRriFcF8I8VZXZz8F7vJKKDKzy+x5KwWxWGuP4eCdRpl7OAMH QzRZT63/qp1fKy1tu/gGidmGdYMfhSfR2P5WsYv/C+1nES9KaJD692+yzt2xZL1LrYcB iZLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=rLUuRSyxYbwt0UVs9QzxFKJlZ9BtLeDXvLxtcsNawRY=; b=IpBZwtPz1RM+Uoe1UcP5eu9WNa5McawDBVSQNE31ajuCKBd7Jw9rNCxgMHT17sGREF D1NkY9sk+TRvZPdUvcfq7H2bAw2VNi4DCXRf1fbyh+w90KCpbwMSLNCjy82zUnyoyyFb B4r40Wvodv/065KBf8pWdJWFiJX2+JVAgfHflTkduY923jqiUd2dD3DjkvNmd/r7DZxp sBo8J9W9+HxAcZkDLR4NOOPVJQTtYiLrYWtvUwPgshFgL5dw47347sCNo9BhXmndI1Ft uykbi8XrvL1H/fGJiduuvsY7zeTeblEuTonRlgQyzDbrfPXimeNkt2LuTQj200p78SJg 1cdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=JKXYbZcb; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2si15266311plp.26.2019.05.06.10.31.12; Mon, 06 May 2019 10:31:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=JKXYbZcb; spf=pass (google.com: best guess record for domain of linux-omap-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726481AbfEFRbL (ORCPT + 5 others); Mon, 6 May 2019 13:31:11 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:41344 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbfEFRbL (ORCPT ); Mon, 6 May 2019 13:31:11 -0400 Received: from grover.flets-west.jp (softbank126125154139.bbtec.net [126.125.154.139]) (authenticated) by conuserg-10.nifty.com with ESMTP id x46HSZCi022951; Tue, 7 May 2019 02:28:36 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x46HSZCi022951 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1557163716; bh=rLUuRSyxYbwt0UVs9QzxFKJlZ9BtLeDXvLxtcsNawRY=; h=From:To:Cc:Subject:Date:From; b=JKXYbZcbzekTUoL6mu+jZH4TU3MaGysbzm7unONRIccBJk6/UgXh6Bh9aTWwiW+Ky A2ptFGi+J9bV+RT6ywYeX1Qnt4A6lFmUkq00Nd5GMuTOaW2tNCVATIqA4Fq/HRXLYr WU81SQYU6DOjxjrRMurBKpCpPe/E/INWCawblX04Pp9cEBtDKms2OUowjOq9pQSTQC GFNUMVWSuzcZ8Ufn0cOstMMRyrcrn34nrEuVi3uWWQ5qtTUX1Xyls6gAdGc4C672QN 4zLbnoRXV6315fHrM4TXSMkwwXikidN8W/U5/s7ksKIdmrtuC6xMxxiKny2sqkCqN3 eyh2vCnHuXi3w== X-Nifty-SrcIP: [126.125.154.139] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Stephen Rothwell , Alexey Gladkov , Masahiro Yamada , linux-kernel@vger.kernel.org, Thomas Gleixner , Tony Lindgren , Lee Jones , Aaro Koskinen , linux-omap@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Daniel Lezcano Subject: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro Date: Tue, 7 May 2019 02:28:17 +0900 Message-Id: <1557163697-17882-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org These files do not define (USBHS_)DRIVER_NAME. Yet, they can be successfully compiled because they are never built as a module by anyone, i.e, the MODULE_ALIAS() calls are always no-op. A problem showed up when a patch "moduleparam: Save information about built-in modules in separate file" is applied. With this new feature, MODULE_*() are populated even if the callers are built-in. To avoid the build errors, the lines referencing to the undefined macro must be removed. The complete fix is to remove all MODULE_* and #include like many "make ... explicitly non-modular" commits did. For now, I am touching the offending lines. Reported-by: Stephen Rothwell Signed-off-by: Masahiro Yamada --- I will insert this commit before "moduleparam: Save information about built-in modules in separate file" arch/arm/plat-omap/dma.c | 1 - drivers/clocksource/timer-ti-dm.c | 1 - drivers/mfd/omap-usb-tll.c | 1 - 3 files changed, 3 deletions(-) -- 2.7.4 Acked-by: Daniel Lezcano diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index d4012d6..5ca4c5f 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -1449,7 +1449,6 @@ static void __exit omap_system_dma_exit(void) MODULE_DESCRIPTION("OMAP SYSTEM DMA DRIVER"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:" DRIVER_NAME); MODULE_AUTHOR("Texas Instruments Inc"); /* diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c index 3352da6..2b7cee81 100644 --- a/drivers/clocksource/timer-ti-dm.c +++ b/drivers/clocksource/timer-ti-dm.c @@ -998,5 +998,4 @@ module_platform_driver(omap_dm_timer_driver); MODULE_DESCRIPTION("OMAP Dual-Mode Timer Driver"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:" DRIVER_NAME); MODULE_AUTHOR("Texas Instruments Inc"); diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index 446713d..93177d8 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -459,7 +459,6 @@ EXPORT_SYMBOL_GPL(omap_tll_disable); MODULE_AUTHOR("Keshava Munegowda "); MODULE_AUTHOR("Roger Quadros "); -MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");