| Message ID | 20190509064549.1302-1-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 8289f913fe12644a9358c12df3da5bd4e7767df0 |
| Headers | show |
| Series | kbuild: add -Wvla flag unconditionally | expand |
On Thu, May 9, 2019 at 8:46 AM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > This flag is documented in the GCC 4.6 manual, and recognized by > Clang as well. Let's rip off the cc-option switch. > [ CC Kees who did the VLA removal/cleanup ] Looks good to me. Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index c71ffb6f55b5..3f5e8a0f4561 100644 > --- a/Makefile > +++ b/Makefile > @@ -841,7 +841,7 @@ NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) > KBUILD_CFLAGS += -Wdeclaration-after-statement > > # Variable Length Arrays (VLAs) should not be used anywhere in the kernel > -KBUILD_CFLAGS += $(call cc-option,-Wvla) > +KBUILD_CFLAGS += -Wvla > > # disable pointer signed / unsigned warnings in gcc 4.0 > KBUILD_CFLAGS += -Wno-pointer-sign > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To post to this group, send email to clang-built-linux@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20190509064549.1302-1-yamada.masahiro%40socionext.com. > For more options, visit https://groups.google.com/d/optout.
On Thu, May 09, 2019 at 03:45:49PM +0900, Masahiro Yamada wrote: > This flag is documented in the GCC 4.6 manual, and recognized by > Clang as well. Let's rip off the cc-option switch. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> > --- > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index c71ffb6f55b5..3f5e8a0f4561 100644 > --- a/Makefile > +++ b/Makefile > @@ -841,7 +841,7 @@ NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) > KBUILD_CFLAGS += -Wdeclaration-after-statement > > # Variable Length Arrays (VLAs) should not be used anywhere in the kernel > -KBUILD_CFLAGS += $(call cc-option,-Wvla) > +KBUILD_CFLAGS += -Wvla > > # disable pointer signed / unsigned warnings in gcc 4.0 > KBUILD_CFLAGS += -Wno-pointer-sign > -- > 2.17.1 >
On Wed, May 8, 2019 at 11:46 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > This flag is documented in the GCC 4.6 manual, and recognized by > Clang as well. Let's rip off the cc-option switch. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Kees Cook <keescook@chromium.org> -- Kees Cook
> On Wed, May 8, 2019 at 11:46 PM Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > > This flag is documented in the GCC 4.6 manual, and recognized by > > Clang as well. Let's rip off the cc-option switch. Checked w/ godbolt w/ Clang 4 and GCC 4.6.4. Tested-by: Nick Desaulniers <ndesaulniers@google.com> -- Thanks, ~Nick Desaulniers
On Fri, May 10, 2019 at 1:52 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > > On Wed, May 8, 2019 at 11:46 PM Masahiro Yamada > > <yamada.masahiro@socionext.com> wrote: > > > This flag is documented in the GCC 4.6 manual, and recognized by > > > Clang as well. Let's rip off the cc-option switch. > > Checked w/ godbolt w/ Clang 4 and GCC 4.6.4. > Tested-by: Nick Desaulniers <ndesaulniers@google.com> > > -- > Thanks, > ~Nick Desaulniers Applied to linux-kbuild. -- Best Regards Masahiro Yamada
diff --git a/Makefile b/Makefile index c71ffb6f55b5..3f5e8a0f4561 100644 --- a/Makefile +++ b/Makefile @@ -841,7 +841,7 @@ NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) KBUILD_CFLAGS += -Wdeclaration-after-statement # Variable Length Arrays (VLAs) should not be used anywhere in the kernel -KBUILD_CFLAGS += $(call cc-option,-Wvla) +KBUILD_CFLAGS += -Wvla # disable pointer signed / unsigned warnings in gcc 4.0 KBUILD_CFLAGS += -Wno-pointer-sign
This flag is documented in the GCC 4.6 manual, and recognized by Clang as well. Let's rip off the cc-option switch. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1