| Message ID | 20190515043123.9106-1-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 5249495da04956f251acda59f840696d85994f55 |
| Headers | show |
| Series | staging: erofs: drop unneeded -Wall addition | expand |
On 2019/5/15 12:31, Masahiro Yamada wrote: > The top level Makefile adds -Wall globally: > > KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ > > I see two "-Wall" added for compiling objects in drivers/staging/erofs/. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Looks good to me and sorry about adding this flag... Reviewed-by: Gao Xiang <gaoxiang25@huawei.com> Thanks, Gao Xiang > --- > > drivers/staging/erofs/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/erofs/Makefile b/drivers/staging/erofs/Makefile > index 38ab344a285e..a34248a2a16a 100644 > --- a/drivers/staging/erofs/Makefile > +++ b/drivers/staging/erofs/Makefile > @@ -2,7 +2,7 @@ > > EROFS_VERSION = "1.0pre1" > > -ccflags-y += -Wall -DEROFS_VERSION=\"$(EROFS_VERSION)\" > +ccflags-y += -DEROFS_VERSION=\"$(EROFS_VERSION)\" > > obj-$(CONFIG_EROFS_FS) += erofs.o > # staging requirement: to be self-contained in its own directory >
On 2019/5/15 12:31, Masahiro Yamada wrote: > The top level Makefile adds -Wall globally: > > KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ > > I see two "-Wall" added for compiling objects in drivers/staging/erofs/. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Thanks,
diff --git a/drivers/staging/erofs/Makefile b/drivers/staging/erofs/Makefile index 38ab344a285e..a34248a2a16a 100644 --- a/drivers/staging/erofs/Makefile +++ b/drivers/staging/erofs/Makefile @@ -2,7 +2,7 @@ EROFS_VERSION = "1.0pre1" -ccflags-y += -Wall -DEROFS_VERSION=\"$(EROFS_VERSION)\" +ccflags-y += -DEROFS_VERSION=\"$(EROFS_VERSION)\" obj-$(CONFIG_EROFS_FS) += erofs.o # staging requirement: to be self-contained in its own directory
The top level Makefile adds -Wall globally: KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ I see two "-Wall" added for compiling objects in drivers/staging/erofs/. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/staging/erofs/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1