diff mbox series

[3/4] s390: drop redundant directory creation from tools Makefile

Message ID 20190517075428.13496-3-yamada.masahiro@socionext.com
State Accepted
Commit c3bce92531ac4f4ed18008545d54b15f2166ddb4
Headers show
Series [1/4] s390: do not pass $(LINUXINCLUDE) to gen_opcode_table.c | expand

Commit Message

Masahiro Yamada May 17, 2019, 7:54 a.m. UTC
As you can see in scripts/Kbuild.include, the filechk creates the
parent directory of the target as needed.

This Makefile does not need to explicitly create the directory.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 arch/s390/tools/Makefile | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.17.1

Comments

Heiko Carstens June 1, 2019, 10:21 a.m. UTC | #1
On Fri, May 17, 2019 at 04:54:26PM +0900, Masahiro Yamada wrote:
> As you can see in scripts/Kbuild.include, the filechk creates the

> parent directory of the target as needed.

> 

> This Makefile does not need to explicitly create the directory.

> 

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---

> 

>  arch/s390/tools/Makefile | 3 ---

>  1 file changed, 3 deletions(-)

> 

> diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile

> index 8fb66c99840a..4864ea5e6ceb 100644

> --- a/arch/s390/tools/Makefile

> +++ b/arch/s390/tools/Makefile

> @@ -16,9 +16,6 @@ hostprogs-y		    += gen_opcode_table

> 

>  HOSTCFLAGS_gen_facilities.o += $(LINUXINCLUDE)

> 

> -# Ensure output directory exists

> -_dummy := $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)')

> -


Applied, thanks.
diff mbox series

Patch

diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
index 8fb66c99840a..4864ea5e6ceb 100644
--- a/arch/s390/tools/Makefile
+++ b/arch/s390/tools/Makefile
@@ -16,9 +16,6 @@  hostprogs-y		    += gen_opcode_table
 
 HOSTCFLAGS_gen_facilities.o += $(LINUXINCLUDE)
 
-# Ensure output directory exists
-_dummy := $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)')
-
 filechk_facility-defs.h = $(obj)/gen_facilities
 
 filechk_dis-defs.h = \