From patchwork Fri May 17 21:18:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kumar Gala X-Patchwork-Id: 164432 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp2707688ili; Fri, 17 May 2019 15:22:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpvUt3yOH12KDDQrKdFSBbykjk9Fxcm8Z8GmDke7EF5t+lDSzRKYJelEMKrkSPSn8rkOES X-Received: by 2002:aa7:c391:: with SMTP id k17mr60143916edq.166.1558131746615; Fri, 17 May 2019 15:22:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558131746; cv=none; d=google.com; s=arc-20160816; b=yzelupB+Y0GX7tcETRWIG0VrySkxq/NCaunAPOhRqIzQ270KOG+S8KUfq5ovB2WhrW CvLJn6VryGMDFr33Alqe1ZtCwsmoQfHrSTXC5XEq/Extr//mWIU/QKhWgKr5vkdIVeSA iaxuUPhKfTDyUB/PtguBCpczjzD+98w1FuIBgSXxg/oHP5eybibDZYgppoRefB2oc0F3 a3SmNuhdZa1siN5aP4fuVnJGuzVk0TxknTe9/stxlMjsVMBSJbvXTxyqoVY32t13Jmwv xIxhJF7s44MWjTdyDU+j/pITiy4BAobfTRphDHvsAhm/sJI4JPyhVi2haCVvZOlIHDPa Yd0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from :dkim-signature; bh=JaZpasU5CpUK6qq8mRcZdxOWtWzK03H7UDQhpXUaq6w=; b=VKeXZufnCTH16gp9BR1o8/kAVMuM5pJriusx8a5/6BHwDboYXhLjkHTfSsVDJcSF1y fER6EnnWhFO/iYXmm40Bfees4zKzgTUEr+6xRyDnDwHKDzfhArblhbPJ3uafe41Wq+QJ wClvHjNC9CKgPq9p8iosA6YqZl13+UiXQnAzv2IR9EUi6SRi0/YwunV1I2xufdQ+sMrO s63lXPiK5Y5ZQqz3j5KYafqOHNMZkHpn0K+m79UQxwS1F2ATixpJYI1MFo5+w0D6FBLn +1T/Skb+5KdLHZXHProM4w9eDuauLFrItCYNfvnrQAuEgyP0lgiS5tvZzn5Dt+Qjo4tG 9s3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=rW9a0FsR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 51si393625eds.200.2019.05.17.15.22.26 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 17 May 2019 15:22:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=rW9a0FsR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:54451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRlFB-0003e3-JI for patch@linaro.org; Fri, 17 May 2019 18:22:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRkFD-0004wu-Q5 for qemu-devel@nongnu.org; Fri, 17 May 2019 17:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRkFC-0005Bj-QJ for qemu-devel@nongnu.org; Fri, 17 May 2019 17:18:23 -0400 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:43710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRkFB-00059k-IH for qemu-devel@nongnu.org; Fri, 17 May 2019 17:18:22 -0400 Received: by mail-oi1-x235.google.com with SMTP id t187so6160000oie.10 for ; Fri, 17 May 2019 14:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JaZpasU5CpUK6qq8mRcZdxOWtWzK03H7UDQhpXUaq6w=; b=rW9a0FsRSZHwDEinext4Y427fZ9YAmYk4ynMerFgM2lApu8fRKqX+K9n7OIBOVspgk y2hyjzsdFBa+VR9Nn9P3jSnW3iBBfmuz40L1S0rNv9TzcXvdSYVlJe6NInV39cnonwWy 1jhUml8YYDpy6TsJ0Cpz7PDSG/xReJbLlQeOgDimMGjflp0zcrci71ZEveY2dK3OU/FU syJvoxujzed77+/azRIDvowIW6Xt3v34zDHjuFh2qC5Bibut95zY//4vzMjZ+2gXb1p7 o0w+1nTas63qdvuBJESaF8GB69d2dtKFuYRwFyENLdvTBrVL1FEu7BV2wPH8wJxEMiPV gP4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JaZpasU5CpUK6qq8mRcZdxOWtWzK03H7UDQhpXUaq6w=; b=rxDVoKnOZoaXPwgR0zfRgM0rOw8MKdKJSP7jpBNF2THtcdKySqkzSZw0GkcYe5joOs IEyRt8LyF2ssw4MQldW0JNSwg0j57E22HIsjecyIsnCtm4QteiCHslJRY5UZeQISqpUC 2pdF5/DwNglOwB8UbFoyZJ8JOcHFG/Ts7s2wzKoanEL3S6W3Scvq8RERGz/BnNbKkK1a DX08QpDP177/Kv24gj2Yx5dL6jhNLULRDgGHnJ/d5mG8kYcbWvRK5LnF3KtlOZytME++ BqYe9fsv42vai8NUD38FUMEvImxNWmhrVC1xn7GPwlWL7/LZifMqzC1Jg8yNusgGu6tc 9wIg== X-Gm-Message-State: APjAAAXti9+VXJYqAIsMa1jNWfJ1c5d0kIALvt2gAN1CFM5db+qRSqIT BEJOIzX/akHCp9wZoU7y8/O/rwpXA04ggA== X-Received: by 2002:aca:4c83:: with SMTP id z125mr15213057oia.60.1558127897989; Fri, 17 May 2019 14:18:17 -0700 (PDT) Received: from localhost.localdomain (108-248-84-146.lightspeed.austtx.sbcglobal.net. [108.248.84.146]) by smtp.gmail.com with ESMTPSA id t14sm3137973otm.15.2019.05.17.14.18.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 May 2019 14:18:17 -0700 (PDT) From: Kumar Gala To: qemu-devel@nongnu.org Date: Fri, 17 May 2019 16:18:05 -0500 Message-Id: <20190517211805.31918-1-kumar.gala@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::235 X-Mailman-Approved-At: Fri, 17 May 2019 18:22:11 -0400 Subject: [Qemu-devel] [PATCH] configure: Only enable iconv if curses is enabled X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Kumar Gala , kraxel@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" iconv is only used with if curses is enabled, there's no need to do any configure checking for iconv, if curses is disabled. Also, ignore --enable-iconv if curses is already disabled. Signed-off-by: Kumar Gala --- configure | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) -- 2.20.1 diff --git a/configure b/configure index d2fc346302..a1b60fa977 100755 --- a/configure +++ b/configure @@ -1235,13 +1235,18 @@ for opt do ;; --disable-stack-protector) stack_protector="no" ;; - --disable-curses) curses="no" + --disable-curses) + curses="no" + iconv="no" ;; --enable-curses) curses="yes" ;; --disable-iconv) iconv="no" ;; - --enable-iconv) iconv="yes" + --enable-iconv) + if test "$curses" != "no" ; then + iconv="yes" + fi ;; --disable-curl) curl="no" ;;