From patchwork Mon May 20 12:00:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 164601 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp192772ili; Mon, 20 May 2019 05:00:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqzAFN4LtFltfxI3BT6cb2b4OwbOJG94Ev/Z9sv5rBeBRU/cemBaKJq3DFeXDku0M7243xPV X-Received: by 2002:a63:5014:: with SMTP id e20mr74182447pgb.2.1558353654326; Mon, 20 May 2019 05:00:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558353654; cv=none; d=google.com; s=arc-20160816; b=UgtDImXo84jrdyZu+3qx32WPybhn+/wI37O1XcIZsKZvE/TDWxNfzxCS2gErD0Ns5p 7TgrknS7MkAvIcp8Z7VIYCxl7g5vVbAZlj9nISnrcw8tI4mR7SeFo/Cb9n6UFV8QgBoT 1FyenR3nFBj61OiulO9mRzcsseH/iADLa2GU6bwBmEUIoadkHWC46Ar5vwZ6j9mICU9Q NhsT+nohoMNSuoF0qOsM5VEoM9I5YFfc489sNkUQDgYgCIVtyRwGNyZzOT9UOfF9GD8v gez5ELZBMuIeSr+gC3iV0rnB423iytt85tN20RrvAQk+s+nbpcYaf79PPMPhUwb8mYrj widw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:subject:message-id:date:from:mime-version:dkim-signature :delivered-to:sender:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature; bh=5wW6SqcN39mzdgDrqg5OKOu7lVDxO+7cafMqObSLayo=; b=ocOuX077Wsq3ofCJTA7yJQI+dJ2bXnqjKBaHBnKjkPXfxvCo1Nfzp91HhvHYRFZjzx 20NpeNtWd+RIk+iEC/Nus6XsTO1GElkWd//qVMKW9Zf7pLsxCG8opBWqYBWmOLKqQuvl aXRwkBvDh9ZGaQ9piQuLOzUR1Un/+hBBIArikRFuappmvasX+kVdaQrzohMFBKSWS6lp 2tVx/UyWnCv006e1gLp2UcgEFUp6KvikHAcxmFWFks6ZlNuJQniCDRb1dI8LRAEUNBpm j+ho+YMETC5tncK42NGVV2zXYOORLOa6e991LI8tIFJ68Uqj5KNoyJ9viLUMQzp+AKsh RRFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=UuEMhiAk; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=scNRk3mL; spf=pass (google.com: domain of gcc-patches-return-501187-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-501187-patch=linaro.org@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id q16si17523035plr.238.2019.05.20.05.00.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 05:00:54 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-501187-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=UuEMhiAk; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=scNRk3mL; spf=pass (google.com: domain of gcc-patches-return-501187-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-501187-patch=linaro.org@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=Ar6WUOZ3pG64FdQStlI+9h4tu2SoUoRKvY/bjg46lHqJr2 yFBzmoy9oJY0ph2k7HO/xIe4y3fQvo95ZEgCkjwGffFRjrGnxSB7/RUqnGCuLsw7 kll3KHSww8hY6dK9C9cpLE4puz4K6kLNBKK5Fu5UBPMojpWPQymuvJHCIovF4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=Tfcyg/Np6HTed1nM7/QVejxQmvg=; b=UuEMhiAkYhOwwLVvgVrt 84vCU5Vbmhho0tCwr319vatm4QIcSsoX3UlkOrVdUbGXDnRVGJa4EqB/jUmdY2du dICx4N+nQlTwDHv5SW5tyzBSJPMVVhzMiKgh/GagjZS4K9m4yGR1z3LB7ND2UmQe yYCj457Ns1IsZtDy00f7cew= Received: (qmail 27680 invoked by alias); 20 May 2019 12:00:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 27666 invoked by uid 89); 20 May 2019 12:00:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1576, dumps X-HELO: mail-vs1-f50.google.com Received: from mail-vs1-f50.google.com (HELO mail-vs1-f50.google.com) (209.85.217.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 May 2019 12:00:38 +0000 Received: by mail-vs1-f50.google.com with SMTP id z11so8691807vsq.9 for ; Mon, 20 May 2019 05:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=ZF8uL0VuvoxUCqCRKbg0cX6YAxrhIOB1ZpoDIAHE1FE=; b=scNRk3mLdjiOLhYoEnLzy4tFELfaNZ8D5rp6UtzZv7z5gz5Vu8/U1AcxiQAgsxJtGf MzAka2utmt8vP3LrjCFcl22GE1gRErCPkRLctaGREd5uqN0Ke81KijpBv4VY++jnhpcy dWftUCIt2BkxNJx9NbqxllD5o7hwibgmT3/0gyequV2VYUc1ipygQ7r9Snwj/K1aOJ4K J9yo0DjPqeg9ztfRz7A5TMtH4e4oSW5g5gp50Zy3Pp5CReGqZSVd/x8cYqDuk78FF2qm daHMX0cJJSK7KMWMfjnOS+5Rf338c0EIhTV73zYK0dv3WH4s5BvYTdgxVAZFb/vSk/WY FNxA== MIME-Version: 1.0 From: Christophe Lyon Date: Mon, 20 May 2019 14:00:24 +0200 Message-ID: Subject: [testsuite] PR90106 Fix cdce3.c testcase To: gcc Patches X-IsSubscribed: yes Hi, As discussed in the PR, the new cdce3.c test fails on arm-linux-gnueabi, and passes on arm-linux-gnueabihf. On arm-linux-gnueabi, the generated code is: .arm .fpu softvfp .type foo, %function foo: b sqrtf on arm-liunx-gnueabihf, it is: .arm .fpu neon .type foo, %function foo: vcmp.f32 s0, #0 vmrs APSR_nzcv, FPSCR vmov.f32 s15, s0 bmi .L10 vsqrt.f32 s0, s15 bx lr .L10: b sqrtf Actually both generate a tail-call, but only the latter says "function call is shrink-wrapped into error conditions." in the dumps. According to what JunMa says in the PR, it seems we want to restrict this testcase to hard-float cases, so that's what this small patch does. OK? Christophe 2019-05-20 Christophe Lyon PR tree-optimization/90106 * gcc.dg/cdce3.c: Add hard_float effective target. diff --git a/gcc/testsuite/gcc.dg/cdce3.c b/gcc/testsuite/gcc.dg/cdce3.c index 8a74379..7e85d8a 100644 --- a/gcc/testsuite/gcc.dg/cdce3.c +++ b/gcc/testsuite/gcc.dg/cdce3.c @@ -1,6 +1,7 @@ /* { dg-do compile } */ +/* { dg-require-effective-target hard_float } */ /* { dg-options "-O2 -fmath-errno -fdump-tree-cdce-details -fdump-tree-optimized" } */ -/* { dg-final { scan-tree-dump "cdce3.c:9: \[^\n\r]* function call is shrink-wrapped into error conditions\." "cdce" } } */ +/* { dg-final { scan-tree-dump "cdce3.c:10: \[^\n\r]* function call is shrink-wrapped into error conditions\." "cdce" } } */ /* { dg-final { scan-tree-dump "sqrtf \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ float sqrtf (float);