From patchwork Mon May 20 13:53:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 164643 Delivered-To: patch@linaro.org Received: by 2002:ac9:2a84:0:0:0:0:0 with SMTP id p4csp281269oca; Mon, 20 May 2019 06:54:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZa6/VpkU7A+UOFStEX88Nb/xp1bLojKsIkRoaC2jsqZnDbRCOoDMAWZIEWL4avutn5mNN X-Received: by 2002:a62:4d03:: with SMTP id a3mr82139421pfb.2.1558360445495; Mon, 20 May 2019 06:54:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558360445; cv=none; d=google.com; s=arc-20160816; b=Pzaxfd42XSdcrUxS+uzYizqFkD0DWI6AtJ8piZfAkNakte4c2JXpsrY1qKgpj712ew nbp3A0E/MFiAb+MyHXQ57+dgROkNMIegWlgNJOjOzAklc8MEb6twklgXsXK8jh272E0n ocW3DywqGP1EiYC1LJyEbYMnDItA8F5pxhh3AsQ53lJ34s3Tgxm4veduSYnWfYSxEnBM lu4v9kwcU8wUOWRSt5mc4DODTn9LfkhZieB06RkUfZxn03WI6vYoqIRuCE0toHikhFuZ 8awjVCw4ncO3NqMMnKnZjO1ywSBlmuKybABbbNnIMWKWo6QyOANCfC+xTo213OBo0qOX KmOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qLnbwDX9nYp0llQixdztrdIhtIxceeBj4sRkANMpAsM=; b=tE1q20PUCxL5+BtT2uwvhlpBU1tpXQGgXBHePkqe+RHjdAIuQK2UEAaxYqNU4a9IsL uIYMn7/BlUwsUsVd5oyAnxHpsgZXmBKL/g5Qa6UshxZpWpRfwm44Y6D8EAW8Qgh0/xZ1 XnjlvDlnANfMBIT3ZYFcLEMfjgCD6FobnBAroqbkcGOG1jcK+8oIHYbCILik6Kh8P2lr Vv4Wvxz2c/eWtAxT6sAtm7iVEhUw/2QZ1F5wlCtc5kfKBjSugYayZxFe9fOKPMSap1SZ nm4DhugX8Aw/EaBUTAOtFWeUrAjcSoPp4iZJytshJ1SzX0mCEyKRUqg6rNfCJF7cgSeN Et2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GjImSPDJ; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si1105703pfn.53.2019.05.20.06.54.05; Mon, 20 May 2019 06:54:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GjImSPDJ; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732383AbfETNyD (ORCPT + 9 others); Mon, 20 May 2019 09:54:03 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:33957 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732359AbfETNyC (ORCPT ); Mon, 20 May 2019 09:54:02 -0400 Received: by mail-io1-f65.google.com with SMTP id g84so11097115ioa.1 for ; Mon, 20 May 2019 06:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qLnbwDX9nYp0llQixdztrdIhtIxceeBj4sRkANMpAsM=; b=GjImSPDJy8ShaSr+Kmu8fSik802cD/opDqpkNym+Rodro2w5D8/smsz5ZmejQAI+3y rsMqynEsw+xD73XJE5d+sP0np/oEVRcnrXkMM30Bicl9+VFtXV9SuzefGaTp0w4dWx2d gi5l9+EIC4mBj33w5DZLCU64lejWFarf0dO7qDS6jpd6go9WsencnubQbU03VtsuVQGB Wi/mc7Rfz9MNa5VQGnlpXL+mSKXz08kZGb2y304tqMZ88wLNA/kRxIWRufMs4aVFw1eg THnozwMZuhU1xKj5vFnIDhkCPEcKJuuwv5I1KzcdIDa2FRbX69m2+OO9aXrAu/pemwyP obCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qLnbwDX9nYp0llQixdztrdIhtIxceeBj4sRkANMpAsM=; b=V0Bc4FFxT0wIX8NjC0ys/pTZCDLPbNEC2dEI57W7SJ2Dr2LYImydQnyKa074iARx0c DbWKx0kDpJy+cl2ivXBn3T5uBur41JOx+T8QVe4cNRPZqH4g30OnRvHfJvArPDwKlw7g ZfPlgJQSPpn6kbmdPAADc1tiFULLhHdof2phgsRVZTArujc5rgZ0zQi6BrAQZjcSzvjj nV/C4626Xoh/5KOi+4rl2x//NiYTcDnIR/T+RzfHfCWW3GSx1y4JBr8TfKWTxCriHVk0 UXesONjZk9gnCZ16TEsmhbWaO0a4ktneg/QJox7iTqPkfnLoIJoXbmamppEPIuE9BY3w ZtGQ== X-Gm-Message-State: APjAAAVxTr9BHKxe/HtJLNjyifCA/Q574q+QGg+qiCo/u7llYH8nMbJB ImfPiQxKOQoAvIFrL/wSf2Wocw== X-Received: by 2002:a6b:f305:: with SMTP id m5mr40986039ioh.271.1558360441814; Mon, 20 May 2019 06:54:01 -0700 (PDT) Received: from localhost.localdomain (c-71-195-29-92.hsd1.mn.comcast.net. [71.195.29.92]) by smtp.gmail.com with ESMTPSA id n17sm6581185ioa.0.2019.05.20.06.54.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 06:54:01 -0700 (PDT) From: Alex Elder To: arnd@arndb.de, subashab@codeaurora.org, david.brown@linaro.org, agross@kernel.org, davem@davemloft.net Cc: bjorn.andersson@linaro.org, ilias.apalodimas@linaro.org, cpratapa@codeaurora.org, syadagir@codeaurora.org, evgreen@chromium.org, benchan@google.com, ejcaruso@google.com, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header Date: Mon, 20 May 2019 08:53:47 -0500 Message-Id: <20190520135354.18628-2-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190520135354.18628-1-elder@linaro.org> References: <20190520135354.18628-1-elder@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The C bit-fields in the first byte of the rmnet_map_header structure are defined in the wrong order. The first byte should be formatted this way: +------- reserved_bit | +----- cd_bit | | v v +-----------+-+-+ | pad_len |R|C| +-----------+-+-+ 7 6 5 4 3 2 1 0 <-- bit position But the C bit-fields that define the first byte are defined this way: u8 pad_len:6; u8 reserved_bit:1; u8 cd_bit:1; And although this isn't portable, I can state that when I build it the result puts the bit-fields in the wrong location (e.g., the cd_bit is in bit position 7, when it should be position 0). Fix this by reordering the definitions of these struct members. Upcoming patches will reimplement these definitions portably. Signed-off-by: Alex Elder --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1 diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h index 884f1f52dcc2..b1ae9499c0b2 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h @@ -40,9 +40,9 @@ enum rmnet_map_commands { }; struct rmnet_map_header { - u8 pad_len:6; - u8 reserved_bit:1; u8 cd_bit:1; + u8 reserved_bit:1; + u8 pad_len:6; u8 mux_id; __be16 pkt_len; } __aligned(1);