| Message ID | 20190521040327.432-1-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 3dd0aade5911d21abb35fbd4f71c3f52c25891d1 |
| Headers | show |
| Series | MIPS: remove a space after -I to cope with header search paths for VDSO | expand |
Hello, Masahiro Yamada wrote: > Commit 9cc342f6c4a0 ("treewide: prefix header search paths with > $(srctree)/") caused a build error for MIPS VDSO. > > CC arch/mips/vdso/gettimeofday.o > In file included from ../arch/mips/vdso/vdso.h:26, > from ../arch/mips/vdso/gettimeofday.c:11: > ../arch/mips/include/asm/page.h:12:10: fatal error: spaces.h: No such file or directory > #include <spaces.h> > ^~~~~~~~~~ > > The cause of the error is a missing space after the compiler flag -I . > > Kbuild used to have a global restriction "no space after -I", but > commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter") got > rid of it. Having a space after -I is no longer a big deal as far as > Kbuild is concerned. > > It is still a big deal for MIPS because arch/mips/vdso/Makefile > filters the header search paths, like this: > > ccflags-vdso := $(filter -I%,$(KBUILD_CFLAGS)) > ..., which relies on the assumption that there is no space after -I . > > Fixes: 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Applied to mips-fixes. Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paul.burton@mips.com to report it. ]
diff --git a/arch/mips/pnx833x/Platform b/arch/mips/pnx833x/Platform index 6b1a847d593f..287260669551 100644 --- a/arch/mips/pnx833x/Platform +++ b/arch/mips/pnx833x/Platform @@ -1,5 +1,5 @@ # NXP STB225 platform-$(CONFIG_SOC_PNX833X) += pnx833x/ -cflags-$(CONFIG_SOC_PNX833X) += -I $(srctree)/arch/mips/include/asm/mach-pnx833x +cflags-$(CONFIG_SOC_PNX833X) += -I$(srctree)/arch/mips/include/asm/mach-pnx833x load-$(CONFIG_NXP_STB220) += 0xffffffff80001000 load-$(CONFIG_NXP_STB225) += 0xffffffff80001000
Commit 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/") caused a build error for MIPS VDSO. CC arch/mips/vdso/gettimeofday.o In file included from ../arch/mips/vdso/vdso.h:26, from ../arch/mips/vdso/gettimeofday.c:11: ../arch/mips/include/asm/page.h:12:10: fatal error: spaces.h: No such file or directory #include <spaces.h> ^~~~~~~~~~ The cause of the error is a missing space after the compiler flag -I . Kbuild used to have a global restriction "no space after -I", but commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter") got rid of it. Having a space after -I is no longer a big deal as far as Kbuild is concerned. It is still a big deal for MIPS because arch/mips/vdso/Makefile filters the header search paths, like this: ccflags-vdso := \ $(filter -I%,$(KBUILD_CFLAGS)) \ ..., which relies on the assumption that there is no space after -I . Fixes: 9cc342f6c4a0 ("treewide: prefix header search paths with $(srctree)/") Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/mips/pnx833x/Platform | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1