[v5,1/6] regulator: lm363x: Make the gpio register enable flexible

Message ID 20190604174345.14841-2-dmurphy@ti.com
State New
Headers show
Series
  • LM36274 Introduction
Related show

Commit Message

Dan Murphy June 4, 2019, 5:43 p.m.
The use of and enablement of the GPIO can be used across devices.
Use the enable_reg in the regulator descriptor for the register to
write.

Signed-off-by: Dan Murphy <dmurphy@ti.com>

Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

---

v5 - No changes to the patch changes requested in this patch were done in
patch 4 of this series - https://lore.kernel.org/patchwork/patch/1077408/

 drivers/regulator/lm363x-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.21.0.5.gaeb582a983

Comments

Mark Brown June 5, 2019, 10:01 a.m. | #1
On Tue, Jun 04, 2019 at 12:43:40PM -0500, Dan Murphy wrote:
> The use of and enablement of the GPIO can be used across devices.

> Use the enable_reg in the regulator descriptor for the register to

> write.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

> ---

> 

> v5 - No changes to the patch changes requested in this patch were done in

> patch 4 of this series - https://lore.kernel.org/patchwork/patch/1077408/


I was expecting this patch to just be completely dropped?  It looks like
the end result is very similar, we're still using enable_reg to get the
register and I don't see new validation added in patch 4.
Dan Murphy June 5, 2019, 12:47 p.m. | #2
Mark

On 6/5/19 7:02 AM, Dan Murphy wrote:
> Mark

>

> On 6/5/19 5:01 AM, Mark Brown wrote:

>> On Tue, Jun 04, 2019 at 12:43:40PM -0500, Dan Murphy wrote:

>>> The use of and enablement of the GPIO can be used across devices.

>>> Use the enable_reg in the regulator descriptor for the register to

>>> write.

>>>

>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>

>>> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

>>> ---

>>>

>>> v5 - No changes to the patch changes requested in this patch were 

>>> done in

>>> patch 4 of this series - 

>>> https://lore.kernel.org/patchwork/patch/1077408/

>> I was expecting this patch to just be completely dropped?  It looks like

>> the end result is very similar, we're still using enable_reg to get the

>> register and I don't see new validation added in patch 4.

>

> I can squash patch 1 into 4.

>

> Also not sure what you mean by new validation.

>

Disregard I understand.  The patch is missing the validation code.


> Please comment on patch 4 to what you are looking for

>

> Dan

>

Patch

diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c
index e02fdd1dd092..1b5d7d2f26b8 100644
--- a/drivers/regulator/lm363x-regulator.c
+++ b/drivers/regulator/lm363x-regulator.c
@@ -263,8 +263,8 @@  static int lm363x_regulator_probe(struct platform_device *pdev)
 
 	if (gpiod) {
 		cfg.ena_gpiod = gpiod;
-
-		ret = regmap_update_bits(regmap, LM3632_REG_BIAS_CONFIG,
+		ret = regmap_update_bits(regmap,
+					 lm363x_regulator_desc[id].enable_reg,
 					 LM3632_EXT_EN_MASK,
 					 LM3632_EXT_EN_MASK);
 		if (ret) {