[1/8] i2c: i2c-qcom-geni: Provide support for ACPI

Message ID 20190605114302.22509-1-lee.jones@linaro.org
State New
Headers show
Series
  • [1/8] i2c: i2c-qcom-geni: Provide support for ACPI
Related show

Commit Message

Lee Jones June 5, 2019, 11:42 a.m.
Add a match table to allow automatic probing of ACPI device
QCOM0220.  Ignore clock attainment errors.  Set default clock
frequency value.

Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/i2c/busses/i2c-qcom-geni.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

-- 
2.17.1

Comments

Bjorn Andersson June 8, 2019, 4:06 a.m. | #1
On Wed 05 Jun 04:42 PDT 2019, Lee Jones wrote:

> When booting MSM based platforms with Device Tree or some ACPI

> implementations, it is possible to provide a list of reserved pins

> via the 'gpio-reserved-ranges' and 'gpios' properties respectively.

> However some ACPI tables are not populated with this information,

> thus it has to come from a knowledgable device driver instead.

> 

> Here we provide the MSM common driver with additional support to

> parse this informtion and correctly populate the widely used

> 'valid_mask'.

> 

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/pinctrl/qcom/pinctrl-msm.c | 18 ++++++++++++++++++

>  drivers/pinctrl/qcom/pinctrl-msm.h |  1 +

>  2 files changed, 19 insertions(+)

> 

> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c

> index ee8119879c4c..3ac740b36508 100644

> --- a/drivers/pinctrl/qcom/pinctrl-msm.c

> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c

> @@ -607,8 +607,23 @@ static int msm_gpio_init_valid_mask(struct gpio_chip *chip)

>  	int ret;

>  	unsigned int len, i;

>  	unsigned int max_gpios = pctrl->soc->ngpios;

> +	const int *reserved = pctrl->soc->reserved_gpios;

>  	u16 *tmp;

>  

> +	/* Driver provided reserved list overrides DT and ACPI */

> +	if (reserved) {

> +		bitmap_fill(chip->valid_mask, max_gpios);

> +		for (i = 0; reserved[i] >= 0; i++) {

> +			if (i >= max_gpios || reserved[i] >= max_gpios) {


reserved is a list of GPIOs to reserve, I don't see a reason to check
if that list is longer than the number of GPIOs (i.e. the first half of
the condition).

It wouldn't make sense to be, but there's no logical issue with it and I
had to read the conditional a few extra times to be sure what was going
on.


Apart from that you have my

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Regards,
Bjorn

> +				dev_err(pctrl->dev, "invalid list of reserved GPIOs\n");

> +				return -EINVAL;

> +			}

> +			clear_bit(reserved[i], chip->valid_mask);

> +		}

> +

> +		return 0;

> +	}

> +

>  	/* The number of GPIOs in the ACPI tables */

>  	len = ret = device_property_read_u16_array(pctrl->dev, "gpios", NULL,

>  						   0);

> @@ -964,6 +979,9 @@ static void msm_gpio_irq_handler(struct irq_desc *desc)

>  

>  static bool msm_gpio_needs_valid_mask(struct msm_pinctrl *pctrl)

>  {

> +	if (pctrl->soc->reserved_gpios)

> +		return true;

> +

>  	return device_property_read_u16_array(pctrl->dev, "gpios", NULL, 0) > 0;

>  }

>  

> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.h b/drivers/pinctrl/qcom/pinctrl-msm.h

> index c12048e54a6f..23b93ae92269 100644

> --- a/drivers/pinctrl/qcom/pinctrl-msm.h

> +++ b/drivers/pinctrl/qcom/pinctrl-msm.h

> @@ -121,6 +121,7 @@ struct msm_pinctrl_soc_data {

>  	bool pull_no_keeper;

>  	const char *const *tiles;

>  	unsigned int ntiles;

> +	const int *reserved_gpios;

>  };

>  

>  extern const struct dev_pm_ops msm_pinctrl_dev_pm_ops;

> -- 

> 2.17.1

>
Lee Jones June 10, 2019, 7:57 a.m. | #2
On Fri, 07 Jun 2019, Bjorn Andersson wrote:

> On Fri 07 Jun 16:02 PDT 2019, Linus Walleij wrote:

> 

> > On Wed, Jun 5, 2019 at 1:43 PM Lee Jones <lee.jones@linaro.org> wrote:

> > 

> > > When booting MSM based platforms with Device Tree or some ACPI

> > > implementations, it is possible to provide a list of reserved pins

> > > via the 'gpio-reserved-ranges' and 'gpios' properties respectively.

> > > However some ACPI tables are not populated with this information,

> > > thus it has to come from a knowledgable device driver instead.

> > >

> > > Here we provide the MSM common driver with additional support to

> > > parse this informtion and correctly populate the widely used

> > > 'valid_mask'.

> > >

> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>

> > 

> > Exactly how we should use of the API, so if Björn can supply an

> > ACK to patches 3 and 4 I'm happy to apply them.

> > 

> > Björn?

> > 

> 

> I'm waiting for a version that does not specify the reserved_gpios for

> struct msm_pinctrl_soc_data sdm845_pinctrl {}, as this would override

> the ability of getting these from DT.

> 

> I haven't seen such revision yet, will review it once I find it.


Just testing it now.  It should be on the list by the time you start.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index db075bc0d952..0fa93b448e8d 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -1,6 +1,7 @@ 
 // SPDX-License-Identifier: GPL-2.0
 // Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
 
+#include <linux/acpi.h>
 #include <linux/clk.h>
 #include <linux/dma-mapping.h>
 #include <linux/err.h>
@@ -483,6 +484,12 @@  static const struct i2c_algorithm geni_i2c_algo = {
 	.functionality	= geni_i2c_func,
 };
 
+static const struct acpi_device_id geni_i2c_acpi_match[] = {
+	{ "QCOM0220"},
+	{ },
+};
+MODULE_DEVICE_TABLE(acpi, geni_i2c_acpi_match);
+
 static int geni_i2c_probe(struct platform_device *pdev)
 {
 	struct geni_i2c_dev *gi2c;
@@ -502,7 +509,7 @@  static int geni_i2c_probe(struct platform_device *pdev)
 		return PTR_ERR(gi2c->se.base);
 
 	gi2c->se.clk = devm_clk_get(&pdev->dev, "se");
-	if (IS_ERR(gi2c->se.clk)) {
+	if (IS_ERR(gi2c->se.clk) && !ACPI_HANDLE(&pdev->dev)) {
 		ret = PTR_ERR(gi2c->se.clk);
 		dev_err(&pdev->dev, "Err getting SE Core clk %d\n", ret);
 		return ret;
@@ -510,12 +517,19 @@  static int geni_i2c_probe(struct platform_device *pdev)
 
 	ret = device_property_read_u32(&pdev->dev, "clock-frequency",
 							&gi2c->clk_freq_out);
-	if (ret) {
+	if (ret && !ACPI_HANDLE(&pdev->dev)) {
 		dev_info(&pdev->dev,
 			"Bus frequency not specified, default to 100kHz.\n");
 		gi2c->clk_freq_out = KHZ(100);
 	}
 
+	if (ACPI_HANDLE(&pdev->dev)) {
+		ACPI_COMPANION_SET(&gi2c->adap.dev, ACPI_COMPANION(&pdev->dev));
+
+		/* Using default, same as the !ACPI case above */
+		gi2c->clk_freq_out = KHZ(100);
+	}
+
 	gi2c->irq = platform_get_irq(pdev, 0);
 	if (gi2c->irq < 0) {
 		dev_err(&pdev->dev, "IRQ error for i2c-geni\n");
@@ -660,6 +674,7 @@  static struct platform_driver geni_i2c_driver = {
 		.name = "geni_i2c",
 		.pm = &geni_i2c_pm_ops,
 		.of_match_table = geni_i2c_dt_match,
+		.acpi_match_table = ACPI_PTR(geni_i2c_acpi_match),
 	},
 };