[6/6] Thermal: spear: Remove redundant platform_set_drvdata()

Message ID 1367575034-18432-6-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat May 3, 2013, 9:57 a.m.
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
---
 drivers/thermal/spear_thermal.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Eduardo Valentin May 3, 2013, 12:51 p.m. | #1
On 03-05-2013 05:57, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Vincenzo Frascino <vincenzo.frascino@st.com>


Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

> ---
>  drivers/thermal/spear_thermal.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
> index 3c5ee56..1a14eaa 100644
> --- a/drivers/thermal/spear_thermal.c
> +++ b/drivers/thermal/spear_thermal.c
> @@ -174,7 +174,6 @@ static int spear_thermal_exit(struct platform_device *pdev)
>  	struct spear_thermal_dev *stdev = spear_thermal->devdata;
>  
>  	thermal_zone_device_unregister(spear_thermal);
> -	platform_set_drvdata(pdev, NULL);
>  
>  	/* Disable SPEAr Thermal Sensor */
>  	actual_mask = readl_relaxed(stdev->thermal_base);
>
Viresh Kumar May 4, 2013, 6:15 a.m. | #2
On Fri, May 3, 2013 at 3:27 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
> ---
>  drivers/thermal/spear_thermal.c |    1 -
>  1 file changed, 1 deletion(-)

For SPEAr,

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Patch

diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c
index 3c5ee56..1a14eaa 100644
--- a/drivers/thermal/spear_thermal.c
+++ b/drivers/thermal/spear_thermal.c
@@ -174,7 +174,6 @@  static int spear_thermal_exit(struct platform_device *pdev)
 	struct spear_thermal_dev *stdev = spear_thermal->devdata;
 
 	thermal_zone_device_unregister(spear_thermal);
-	platform_set_drvdata(pdev, NULL);
 
 	/* Disable SPEAr Thermal Sensor */
 	actual_mask = readl_relaxed(stdev->thermal_base);