diff mbox series

[v2,01/42] decodetree: Fix comparison of Field

Message ID	20190611105351.9871-2-peter.maydell@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: Peter Maydell <peter.maydell@linaro.org> To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Tue, 11 Jun 2019 11:53:10 +0100 Message-Id: <20190611105351.9871-2-peter.maydell@linaro.org> In-Reply-To: <20190611105351.9871-1-peter.maydell@linaro.org> References: <20190611105351.9871-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v2 01/42] decodetree: Fix comparison of Field Precedence: list Cc: Richard Henderson <richard.henderson@linaro.org> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patch=linaro.org@nongnu.org>
Series	target/arm: Convert VFP decoder to decodetree \| expand [v2,00/42] target/arm: Convert VFP decoder to decodetree [v2,01/42] decodetree: Fix comparison of Field [v2,02/42] target/arm: Add stubs for AArch32 VFP decodetree [v2,03/42] target/arm: Factor out VFP access checking code [v2,04/42] target/arm: Fix Cortex-R5F MVFR values [v2,05/42] target/arm: Explicitly enable VFP short-vectors for aarch32 -cpu max [v2,06/42] target/arm: Convert the VSEL instructions to decodetree [v2,07/42] target/arm: Convert VMINNM, VMAXNM to decodetree [v2,08/42] target/arm: Convert VRINTA/VRINTN/VRINTP/VRINTM to decodetree [v2,09/42] target/arm: Convert VCVTA/VCVTN/VCVTP/VCVTM to decodetree [v2,10/42] target/arm: Move the VFP trans_* functions to translate-vfp.inc.c [v2,11/42] target/arm: Add helpers for VFP register loads and stores [v2,12/42] target/arm: Convert "double-precision" register moves to decodetree [v2,13/42] target/arm: Convert "single-precision" register moves to decodetree [v2,14/42] target/arm: Convert VFP two-register transfer insns to decodetree [v2,15/42] target/arm: Convert VFP VLDR and VSTR to decodetree [v2,16/42] target/arm: Convert the VFP load/store multiple insns to decodetree [v2,17/42] target/arm: Remove VLDR/VSTR/VLDM/VSTM use of cpu_F0s and cpu_F0d [v2,18/42] target/arm: Convert VFP VMLA to decodetree [v2,19/42] target/arm: Convert VFP VMLS to decodetree [v2,20/42] target/arm: Convert VFP VNMLS to decodetree [v2,21/42] target/arm: Convert VFP VNMLA to decodetree [v2,22/42] target/arm: Convert VMUL to decodetree [v2,23/42] target/arm: Convert VNMUL to decodetree [v2,24/42] target/arm: Convert VADD to decodetree [v2,25/42] target/arm: Convert VSUB to decodetree [v2,26/42] target/arm: Convert VDIV to decodetree [v2,27/42] target/arm: Convert VFP fused multiply-add insns to decodetree [v2,28/42] target/arm: Convert VMOV (imm) to decodetree [v2,29/42] target/arm: Convert VABS to decodetree [v2,30/42] target/arm: Convert VNEG to decodetree [v2,31/42] target/arm: Convert VSQRT to decodetree [v2,32/42] target/arm: Convert VMOV (register) to decodetree [v2,33/42] target/arm: Convert VFP comparison insns to decodetree [v2,34/42] target/arm: Convert the VCVT-from-f16 insns to decodetree [v2,35/42] target/arm: Convert the VCVT-to-f16 insns to decodetree [v2,36/42] target/arm: Convert VFP round insns to decodetree [v2,37/42] target/arm: Convert double-single precision conversion insns to decodetree [v2,38/42] target/arm: Convert integer-to-float insns to decodetree [v2,39/42] target/arm: Convert VJCVT to decodetree [v2,40/42] target/arm: Convert VCVT fp/fixed-point conversion insns to decodetree [v2,41/42] target/arm: Convert float-to-integer VCVT insns to decodetree [v2,42/42] target/arm: Fix short-vector increment behaviour

Commit Message

Peter Maydell June 11, 2019, 10:53 a.m. UTC

From: Richard Henderson <richard.henderson@linaro.org>


Typo comparing the sign of the field, twice, instead of also comparing
the mask of the field (which itself encodes both position and length).

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Message-id: 20190604154225.26992-1-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

---
 scripts/decodetree.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

diff mbox series

Patch

diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 81874e22cc7..d7a59d63ac3 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -184,7 +184,7 @@  class Field:
         return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len)
 
     def __eq__(self, other):
-        return self.sign == other.sign and self.sign == other.sign
+        return self.sign == other.sign and self.mask == other.mask
 
     def __ne__(self, other):
         return not self.__eq__(other)