[v2] drivers: regulator: 88pm800: fix warning same module names

Message ID 20190612081158.1424-1-anders.roxell@linaro.org
State Accepted
Commit 6f10419187d0d5fe395e2a2f2a64370961bf02a3
Headers show
Series
  • [v2] drivers: regulator: 88pm800: fix warning same module names
Related show

Commit Message

Anders Roxell June 12, 2019, 8:11 a.m.
When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800
enabled as loadable modules, we see the following warning:

warning: same module names found:
  drivers/regulator/88pm800.ko
  drivers/mfd/88pm800.ko

Rework so that the file is named 88pm800-regulator.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 drivers/regulator/{88pm800.c => 88pm800-regulator.c} | 0
 drivers/regulator/Makefile                           | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/regulator/{88pm800.c => 88pm800-regulator.c} (100%)

-- 
2.20.1

Comments

Mark Brown June 12, 2019, 12:21 p.m. | #1
On Wed, Jun 12, 2019 at 10:11:58AM +0200, Anders Roxell wrote:
> When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800

> enabled as loadable modules, we see the following warning:


Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.
Anders Roxell June 12, 2019, 2:14 p.m. | #2
On Wed, 12 Jun 2019 at 14:21, Mark Brown <broonie@kernel.org> wrote:
>

> On Wed, Jun 12, 2019 at 10:11:58AM +0200, Anders Roxell wrote:

> > When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800

> > enabled as loadable modules, we see the following warning:

>

> Please use subject lines matching the style for the subsystem.  This

> makes it easier for people to identify relevant patches.


I should have payed more attention, sorry.

Do you want me to send a v3 to fix the subject line for this patch?

Cheers,
Anders
Mark Brown June 12, 2019, 4:53 p.m. | #3
On Wed, Jun 12, 2019 at 04:14:38PM +0200, Anders Roxell wrote:
> On Wed, 12 Jun 2019 at 14:21, Mark Brown <broonie@kernel.org> wrote:


> > Please use subject lines matching the style for the subsystem.  This

> > makes it easier for people to identify relevant patches.


> I should have payed more attention, sorry.


> Do you want me to send a v3 to fix the subject line for this patch?


It's OK, I fixed it up by hand.

Patch

diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800-regulator.c
similarity index 100%
rename from drivers/regulator/88pm800.c
rename to drivers/regulator/88pm800-regulator.c
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 76e78fa449a2..c15b0b613766 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -11,7 +11,7 @@  obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
 obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o
 
 obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
 obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o
 obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o
 obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o