[v2,3/3] drivers: media: coda: fix warning same module names

Message ID 20190612081550.2255-1-anders.roxell@linaro.org
State Accepted
Commit 1296987d2baf7f56748359b8dd42c425b9e7ee3a
Headers show
Series
  • Untitled series #21036
Related show

Commit Message

Anders Roxell June 12, 2019, 8:15 a.m.
When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
loadable modules, we see the following warning:

warning: same module names found:
  fs/coda/coda.ko
  drivers/media/platform/coda/coda.ko

Rework so media/platform/coda is named coda-vpu. Leaving CODA_FS as is
since that's a well known module.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 drivers/media/platform/coda/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.20.1

Comments

Philipp Zabel June 12, 2019, 8:27 a.m. | #1
On Wed, 2019-06-12 at 10:15 +0200, Anders Roxell wrote:
> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as

> loadable modules, we see the following warning:

> 

> warning: same module names found:

>   fs/coda/coda.ko

>   drivers/media/platform/coda/coda.ko

> 

> Rework so media/platform/coda is named coda-vpu. Leaving CODA_FS as is

> since that's a well known module.

> 

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> ---

>  drivers/media/platform/coda/Makefile | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile

> index 54e9a73a92ab..5fd5efa35159 100644

> --- a/drivers/media/platform/coda/Makefile

> +++ b/drivers/media/platform/coda/Makefile

> @@ -1,6 +1,6 @@

>  # SPDX-License-Identifier: GPL-2.0-only

>  

> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o

> +coda-vpu-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o

>  

> -obj-$(CONFIG_VIDEO_CODA) += coda.o

> +obj-$(CONFIG_VIDEO_CODA) += coda-vpu.o


Thanks,
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>


regards
Philipp

Patch

diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
index 54e9a73a92ab..5fd5efa35159 100644
--- a/drivers/media/platform/coda/Makefile
+++ b/drivers/media/platform/coda/Makefile
@@ -1,6 +1,6 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
 
-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
+coda-vpu-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
 
-obj-$(CONFIG_VIDEO_CODA) += coda.o
+obj-$(CONFIG_VIDEO_CODA) += coda-vpu.o
 obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o