[2/6] phy: renesas: rcar-gen2: Fix memory leak at error paths

Message ID 20190612102803.25398-3-kishon@ti.com
State Accepted
Commit d4a36e82924d3305a17ac987a510f3902df5a4b2
Headers show
  • [1/6] phy: qcom-qusb2: fix missing assignment of ret when calling clk_prepare_enable
Related show

Commit Message

Kishon Vijay Abraham I June 12, 2019, 10:27 a.m.
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

This patch fixes memory leak at error paths of the probe function.
In for_each_child_of_node, if the loop returns, the driver should
call of_put_node() before returns.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Fixes: 1233f59f745b237 ("phy: Renesas R-Car Gen2 PHY driver")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

 drivers/phy/renesas/phy-rcar-gen2.c | 2 ++
 1 file changed, 2 insertions(+)



diff --git a/drivers/phy/renesas/phy-rcar-gen2.c b/drivers/phy/renesas/phy-rcar-gen2.c
index 8dc5710d9c98..2926e4937301 100644
--- a/drivers/phy/renesas/phy-rcar-gen2.c
+++ b/drivers/phy/renesas/phy-rcar-gen2.c
@@ -391,6 +391,7 @@  static int rcar_gen2_phy_probe(struct platform_device *pdev)
 		error = of_property_read_u32(np, "reg", &channel_num);
 		if (error || channel_num > 2) {
 			dev_err(dev, "Invalid \"reg\" property\n");
+			of_node_put(np);
 			return error;
 		channel->select_mask = select_mask[channel_num];
@@ -406,6 +407,7 @@  static int rcar_gen2_phy_probe(struct platform_device *pdev)
 			if (IS_ERR(phy->phy)) {
 				dev_err(dev, "Failed to create PHY\n");
+				of_node_put(np);
 				return PTR_ERR(phy->phy);
 			phy_set_drvdata(phy->phy, phy);