From patchwork Thu Jun 13 11:42:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 166608 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp650880ilk; Thu, 13 Jun 2019 04:46:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzc0LygmxDW70CiwT+0y6rFsZG8clX3XlTR4hgNKFJEJ1ZSX1cmLz0NYQGz/R9o5kU6SHMx X-Received: by 2002:a7b:cb94:: with SMTP id m20mr3307648wmi.144.1560426363588; Thu, 13 Jun 2019 04:46:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560426363; cv=none; d=google.com; s=arc-20160816; b=Zf5t9oW3S23lqhWasqRSGua3X9MEjOdqQqAinE/F/OhzF69Mh2YEpkwMgnRQ1riq5X J1msBhc+GcR7DXbmiWAix0uPQS+da+IkOaD0YF8UWtr68iU7aFYdyTYZMNsWj7l1T/RI KlHnTr/+FDTnFsibAi9hNV9ayoZNRo7AxWpxp247u3mTu1vpvWtKIfWZcFcm4EodaL7+ tbn4jBHhmk1/wXLVP49yvydrxyriRWNSmsk19Wn3O3FxbGCPH89Va6z+oQjlA8n6EURd qY1nCOmk62UsqMivTdQD6cOoevA3FIdlTGoPIkRS2qAp/e/t+fe5AsEqvT7Ok1vHLxGs t5Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :cc:mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-filter:delivered-to:dkim-signature:dkim-filter; bh=F7So5VzqYs8AsLBSEAKWC1meobqUygbkMzw+Zblz/H4=; b=Ixlo4Lzr1v8UjbUsmmQZ3pFa+hyK+8zNw77Do+dg5b/tb/0CcI/7zLeBZCPwuI8Jld lddH4XRgVEUa0m1qAy4obQ32nwVeDuOW8ZqZc1zp64zNNYNardpAuFbVwkHaSpPg5KLD SjQOF6tOL2zF0JNZ8X/ZY0/k/IlJcYL6TGCb1dmKzo0HN0lTlEXK40OXbyDnavzg81cG lsuYR7OoP6VzaKSaaLLr2VQL8ETByDv6ZjyEUn0vPcbH74OPS9XbE4T89S6LP3hEODBZ ytSKHKbdRpt+JWpS2d4gUqh5hrl5+gvbRtTcgEAG6+qOJXpVS0uV3Oc/ztoIBSRpnLAT +HJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alsa-project.org header.s=default header.b=s1LqboGu; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ARq6OKiJ; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTPS id m9si2579410wrx.197.2019.06.13.04.46.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 04:46:03 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=pass header.i=@alsa-project.org header.s=default header.b=s1LqboGu; dkim=neutral (body hash did not verify) header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=ARq6OKiJ; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B148B182E; Thu, 13 Jun 2019 13:45:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B148B182E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1560426362; bh=uQ96amlyZ42rL/XtjVyaHlhOH/7exK7pOVQIx0EJKC8=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=s1LqboGubugZ6jk12eWChhqtFcG3BZB7tRwX8Wqe9YsqQ9ephEVkVAQmQ54EXpALn PveekgQLrP9c9CQb2GsPNicN0Zc/BdPLYj/LCOnKTJdfu8BBVcMglbcMzzNr72+2J7 B4rC4lMKXLEEa2lli0CyXVh5IbXeeU4+hupyqeM8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 221EDF89736; Thu, 13 Jun 2019 13:42:50 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6B571F8970F; Thu, 13 Jun 2019 13:42:45 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D1213F80794 for ; Thu, 13 Jun 2019 13:42:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D1213F80794 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ARq6OKiJ" Received: by mail-wr1-x443.google.com with SMTP id f9so20373141wre.12 for ; Thu, 13 Jun 2019 04:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TExrEtVR1Qp+m2eA960X7wRJwZP76vaDnZqCemHrZMo=; b=ARq6OKiJiNJ8rcawe7B7CKa+kO25GegV4OLzlT2aC16bZB7ZbGOeh4KfbetAfkiOk3 YmtzX9XOJh2s/leNI5KQNSwKtxxkdQjzpdv8KAotEvXsQ7oqgwqaUX6IhwnhwJULiEzw HQINex/o0ZH99njmn2fOFSgGPlL6gLGHjJxPe1kpQMtpPZAoo0d79nsOVRjthp0VlL/6 exoH2sc5NANWn1mm4wVjEwCcQknz0R7B57hFUlVQDaYC8nALkbz73efD7CqPRVL9NhQ1 XRALVm86xKQJFghDjinxQgkadLhBSdqqAw2EQXBtQw/hKgK7S1lvbkzlqzbIo6KxT59B aS9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TExrEtVR1Qp+m2eA960X7wRJwZP76vaDnZqCemHrZMo=; b=KxvLHICgwqkrN9+q1REUklAoRxhb2+HfqOkhiSTr6OJQc3o0gilI+vTFeJb5B8Ogab ql3D92nff+M4G39/HrHGc+CteoOvQIOMHZl9OwhQeeBAS0VxMDNuFldS38zzDb8RJeVK HHztZmI13SfhO4mOTl0QVR+McmTPOpV2fbfExMiBwgk79P8dJQoFubPZWF7GBOHcOncD D7snX6c3YyePnQYOlJMti/qnfKz7vFjDFdUb8VQJTZH4ZgjPPfn0SDHR4KeNTCL565hN OKlxoravNI3/mqI327rpJWfvzMek+ZVM6nxfIkNnq+wmUaZ3OAvpygyNTOrG0Vu7o05P CKSA== X-Gm-Message-State: APjAAAVACsEL49rcZLcBIzUGWBcbiTzWdC9In0ls1sYWqwzpwFBtQ/lD VbYE6WXuiXUvmyjpYDBwIV6TEw== X-Received: by 2002:adf:eb09:: with SMTP id s9mr57922277wrn.127.1560426162128; Thu, 13 Jun 2019 04:42:42 -0700 (PDT) Received: from boomer.local (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id b5sm2598490wru.69.2019.06.13.04.42.41 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 04:42:41 -0700 (PDT) From: Jerome Brunet To: Mark Brown , Liam Girdwood , Kevin Hilman Date: Thu, 13 Jun 2019 13:42:32 +0200 Message-Id: <20190613114233.21130-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613114233.21130-1-jbrunet@baylibre.com> References: <20190613114233.21130-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet Subject: [alsa-devel] [PATCH 3/4] ASoC: meson: axg-tdm: fix sample clock inversion X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The content of SND_SOC_DAIFMT_FORMAT_MASK is a number, not a bitfield, so the test to check if the format is i2s is wrong. Because of this the clock setting may be wrong. For example, the sample clock gets inverted in DSP B mode, when it should not. Fix the lrclk invert helper function Fixes: 1a11d88f499c ("ASoC: meson: add tdm formatter base driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/meson/axg-tdm.h b/sound/soc/meson/axg-tdm.h index e578b6f40a07..5774ce0916d4 100644 --- a/sound/soc/meson/axg-tdm.h +++ b/sound/soc/meson/axg-tdm.h @@ -40,7 +40,7 @@ struct axg_tdm_iface { static inline bool axg_tdm_lrclk_invert(unsigned int fmt) { - return (fmt & SND_SOC_DAIFMT_I2S) ^ + return ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_I2S) ^ !!(fmt & (SND_SOC_DAIFMT_IB_IF | SND_SOC_DAIFMT_NB_IF)); }