[PULL,07/48] decodetree: Fix comparison of Field

Message ID 20190613121433.5246-8-peter.maydell@linaro.org
State Accepted
Commit 2c7d442743854d2c1f5475446e088bd523f4bb20
Headers show
  • target-arm queue
Related show

Commit Message

Peter Maydell June 13, 2019, 12:13 p.m.
From: Richard Henderson <richard.henderson@linaro.org>

Typo comparing the sign of the field, twice, instead of also comparing
the mask of the field (which itself encodes both position and length).

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Message-id: 20190604154225.26992-1-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

 scripts/decodetree.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 81874e22cc7..d7a59d63ac3 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -184,7 +184,7 @@  class Field:
         return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len)
     def __eq__(self, other):
-        return self.sign == other.sign and self.sign == other.sign
+        return self.sign == other.sign and self.mask == other.mask
     def __ne__(self, other):
         return not self.__eq__(other)