From patchwork Thu Jun 13 12:14:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 166637 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp725571ilk; Thu, 13 Jun 2019 05:57:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqyGv8XEARFP6vWqp6NUl7b2hVXhhaZGEWRO08RyFxivfdLrZ83vAAFKdXBIpKDqPzcIVZ3M X-Received: by 2002:ae9:c10c:: with SMTP id z12mr17661321qki.110.1560430679806; Thu, 13 Jun 2019 05:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560430679; cv=none; d=google.com; s=arc-20160816; b=dww6ayi1MmC3pPXa0FqYMnx5ngyHWWMJzp8PMBVlP8rFwG5M4RAHskxf/aissiqlri c7Qt1N28EPgnz3l6HWO+W8Oj3W4oYaDiX23amrY0M4CRH7EZuaZvIEybm9AzgzNud06U ycmYrDWddXzkxlc6x7mkiAl0SKq96UQ7mLaA5Vx1H/DY0OgjpXbjkv4ghPytqkDbKJle 4olZb9oGf3URENG4LBseD1Wbq4nXSB2yFcywgR1qEQwHpcO8mXQrPR0XTDzFhAzpJp4Y IWoToPXA3o8OcNcbDgge7KTpU2nfpmpyvKhCx+jpEaj5cFKGsqdA7BJ1X+e5/xtN4Emb uxyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=eYuZ4JfNpv8LMEYu119hBSFj+2/7pHYpoxLLGG2Y2VU=; b=ohYsdQWog0NbS/2MVpLlSLuY0zGXT4qfFTy5V4XQebyj9Ucww5Hx9hu51KYOcRHr2y YqwEL73jgqnKwK+DT5jA9L9X86sPW/YeJRfwij4m389d5I22AqP+MjxpiO4sx0NUf8KY 7qEGV6z1a9E1bxO2LdRYsDb19zCCZAv6oQcJ/rs1bZ+fBNIPOCa24QtGQRWzqHnxrg0+ vE/i2FHl6fVT0LTyWPcOJy3mb0YQWNWSCsFWaAWoqbvfc7KegN+ZV46l+/39Zr2hOU6L P3e7EdEZPXkhowM9kT2GP4UHs/1LdGFoEqre0lfYumW8cz8942yEdST1IH6A8xN8YK7n zRfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=SZodAsV8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g13si1527197qke.211.2019.06.13.05.57.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Jun 2019 05:57:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=SZodAsV8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbPIl-0005PC-8j for patch@linaro.org; Thu, 13 Jun 2019 08:57:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59396) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbOda-0008Hl-BS for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:15:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbOdV-0004d4-Bi for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:15:26 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:52170) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbOdU-0004M0-Rz for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:15:21 -0400 Received: by mail-wm1-x331.google.com with SMTP id 207so2082006wma.1 for ; Thu, 13 Jun 2019 05:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=eYuZ4JfNpv8LMEYu119hBSFj+2/7pHYpoxLLGG2Y2VU=; b=SZodAsV8Mr+FemOgPqb1thHU4CE03OhOyF8GRtm8hvpuNipUfkkkScpoip3ZrWiWpF A3y7fUnTKppe7Dka6MiDphUxq86znav0/VPJXpS0YRMxItRUCPLWQgI+IZH/WNe2f8uR GyFyTN/l+P0jUDLtMEzDYMTkZBIspoH7UXv83u6l2Cn/zTnDI2GCL9pyz7sskoMCb5Wl 1p/nl+6deTSNzrePLhYS5tJF534S7w2ByyBIYEL/PmshFLX6j0mRXvFuxdGc0PdYH+aF LfIRYfCQPGSF8oR2BcWOnOIAD9qD0FyfCKMRmJ6V5UBWG27hOTZCLWS6bgJVVVh/A30O KgnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eYuZ4JfNpv8LMEYu119hBSFj+2/7pHYpoxLLGG2Y2VU=; b=c5j5f9p4abbpNeMAaoyq/t00l70bEP9AfyVwMcC6kIlKDeiNFMpSPr40c+J8xkeAv5 83IPGP/CQhTlStOpl2HqjrJ6Mnn8F+xzMP0aelj5shEITS+WLqLRxcEPur5i6BbRChEp BBmAzHhPjz/89nq+Lh36L0aYwO7Ok8CoXRtjrPFTf8cV7XBfmh0FNKLtkEGLP3EV+pQr zj/UjOoIHnNCeDME8V3uCXn+HEKNxjHo3UrcV68Q1OXeqnSUgPMGiiXxZTodY27nIh90 OGKm53cnze0DNURHx/PFWK8ugcFQ9oLqm6+F4gJtYrfqTClJuyslwwZ9dfbCbLRpX1NU ATZw== X-Gm-Message-State: APjAAAUoYx9PWZxTeVNa3R4NIW7BZiPhs8E2GwmXRa+c/YrwI8ODXr/A PSdTOd2m7Hs/JSV25zUEB54YiI8RuEqq4w== X-Received: by 2002:a1c:f205:: with SMTP id s5mr3777869wmc.14.1560428108144; Thu, 13 Jun 2019 05:15:08 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id y6sm2010576wrp.12.2019.06.13.05.15.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 05:15:07 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 13 Jun 2019 13:14:15 +0100 Message-Id: <20190613121433.5246-31-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613121433.5246-1-peter.maydell@linaro.org> References: <20190613121433.5246-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 Subject: [Qemu-devel] [PULL 30/48] target/arm: Convert VADD to decodetree X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Convert the VADD instruction to decodetree. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/translate-vfp.inc.c | 10 ++++++++++ target/arm/translate.c | 6 +----- target/arm/vfp.decode | 5 +++++ 3 files changed, 16 insertions(+), 5 deletions(-) -- 2.20.1 diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c index 4c684f033b6..14aeb25f597 100644 --- a/target/arm/translate-vfp.inc.c +++ b/target/arm/translate-vfp.inc.c @@ -1451,3 +1451,13 @@ static bool trans_VNMUL_dp(DisasContext *s, arg_VNMUL_sp *a) { return do_vfp_3op_dp(s, gen_VNMUL_dp, a->vd, a->vn, a->vm, false); } + +static bool trans_VADD_sp(DisasContext *s, arg_VADD_sp *a) +{ + return do_vfp_3op_sp(s, gen_helper_vfp_adds, a->vd, a->vn, a->vm, false); +} + +static bool trans_VADD_dp(DisasContext *s, arg_VADD_sp *a) +{ + return do_vfp_3op_dp(s, gen_helper_vfp_addd, a->vd, a->vn, a->vm, false); +} diff --git a/target/arm/translate.c b/target/arm/translate.c index cf03672db8c..2341479a7c2 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -1386,7 +1386,6 @@ static inline void gen_vfp_##name(int dp) \ tcg_temp_free_ptr(fpst); \ } -VFP_OP2(add) VFP_OP2(sub) VFP_OP2(div) @@ -3111,7 +3110,7 @@ static int disas_vfp_insn(DisasContext *s, uint32_t insn) rn = VFP_SREG_N(insn); switch (op) { - case 0 ... 5: + case 0 ... 6: /* Already handled by decodetree */ return 1; default: @@ -3297,9 +3296,6 @@ static int disas_vfp_insn(DisasContext *s, uint32_t insn) for (;;) { /* Perform the calculation. */ switch (op) { - case 6: /* add: fn + fm */ - gen_vfp_add(dp); - break; case 7: /* sub: fn - fm */ gen_vfp_sub(dp); break; diff --git a/target/arm/vfp.decode b/target/arm/vfp.decode index 3063fcac23f..d911f12dfd0 100644 --- a/target/arm/vfp.decode +++ b/target/arm/vfp.decode @@ -127,3 +127,8 @@ VNMUL_sp ---- 1110 0.10 .... .... 1010 .1.0 .... \ vm=%vm_sp vn=%vn_sp vd=%vd_sp VNMUL_dp ---- 1110 0.10 .... .... 1011 .1.0 .... \ vm=%vm_dp vn=%vn_dp vd=%vd_dp + +VADD_sp ---- 1110 0.11 .... .... 1010 .0.0 .... \ + vm=%vm_sp vn=%vn_sp vd=%vd_sp +VADD_dp ---- 1110 0.11 .... .... 1011 .0.0 .... \ + vm=%vm_dp vn=%vn_dp vd=%vd_dp