From patchwork Thu Jun 13 12:14:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 166649 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp753215ilk; Thu, 13 Jun 2019 06:18:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqy7bzATiaog+babAVqbcNFevuC3adkMM1XgedaTwzVopeyc2MtO4yJvSmhf30X3IaR2x1cM X-Received: by 2002:ac8:4a10:: with SMTP id x16mr1772865qtq.282.1560431914923; Thu, 13 Jun 2019 06:18:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560431914; cv=none; d=google.com; s=arc-20160816; b=Gv1azFD+QngrTCXbW10alsaBMQW+95WRyC7SEnwXGsGm6EJsYNDObGiqFl9Gd1MC3m hHuOAvF5FMyyEy2IYns0qKYB1jhLM3XXVX61SjHI2GOr/u9PBWv32yw2JsEYzlQUKmNA 1ma4cqKAQiIllbO98e5KZGikLVM4QDtHTCQQ/+f+oMW2R2HkM4KBxAaiQ1KiuK1cLQQF oNLePaZ/e0fJGogb9QkRGW4lex2SLOsdUCI7k2ntAyYpaFSkMOTDsJ+3BA1wOdFogoK6 V1Sb64NEN+a/Tn5p0O63vuqxx2KX/u6tcZnvNbrHCjHIghrXAJi8Y/Peh5MlNtqwG7Ld NN7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=RdrTqHHHmaF6iJZ3JzcpCUEEhs68e3HO51ReGF+FJxk=; b=ZIAGa+Spgf1IYll9ZhQW+NSqD+7dGbdLXMYchQAwJ1/W0nDH+otfsD0kkzXO+hJjBW X/LBr3XYmNxymuRHvcNlrhBV8SS0nzUPvtvmsnPtD9K+RRQyD6RXu2K8q843/0R72rBk b+KpQMDLfiZw9bHoWUNhXFBRm6ZmrYLl0goEPN517xbiaoYiRjBzIN4RvMbVNO0g/WZX qb5ErnM5V1+YX/eZCiu+t5sJ5SYjXV+9OA2w932q689PJTv2NMIiXiL7uWqDm0vFGYUt b9UsWvlA0ZknXOplmSE061Rc1oz8/MYKn1KyjbJmZ7MjxDWbXJ0qh7v0xVnmZmGMRV7W aa5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FrF6EXLB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q19si1883235qtj.324.2019.06.13.06.18.34 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Jun 2019 06:18:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FrF6EXLB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbPcg-0002YA-Ep for patch@linaro.org; Thu, 13 Jun 2019 09:18:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59371) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbOda-0008HD-0f for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:15:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbOdU-0004aI-Kc for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:15:25 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:35887) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbOdU-0004Ta-5q for qemu-devel@nongnu.org; Thu, 13 Jun 2019 08:15:20 -0400 Received: by mail-wm1-x32c.google.com with SMTP id u8so9889522wmm.1 for ; Thu, 13 Jun 2019 05:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=RdrTqHHHmaF6iJZ3JzcpCUEEhs68e3HO51ReGF+FJxk=; b=FrF6EXLBlhmi/P/C603R3jpIcAxrN0lBj9lMba00Au+xRY8Ju/9A9PV2aamyblfIMK 8AG4Z34icAHqpHFeh+AvtmMWoTb8N4P14bbmfemeaTP2PXRgtI1ACWVQaZFyMA8TATCP GaQO2ZUG79U4gEhwjJHDWBtVmt0HIS3FQnIHvPwHlb9/KT6ahQG7VKQH8bO4QFRBJHDF ZrkDkuR7GdDeFGvmUIpAIYdXWM0qU7eTxvA2pMGJ6Ql8JlbCC8jTWb7Ke3gAVcyQ+AKt MELQ5uecAZ1LWWpOYJb2Ix0FRuFxS0kZAgs+fZSgkSiJnHH+CplIK9Ofq4aT9UGVAKJT ZP/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RdrTqHHHmaF6iJZ3JzcpCUEEhs68e3HO51ReGF+FJxk=; b=fNvxnB8CtGcdA9Xj9OI1bYhWLrGEUqRPpnFthxsDG34C6kUrmylb019c6hIROQWWfe 1JscZtKsIktTXAD1T4fzidAbXcE7cKXhFUlMi8mnmV1lAahHOqht53Iv87+ZXwcH7Plq DsBZP77tOOvILbEGmkJoGKkJLsdTvYZj/KxuBAUypXMIL7RBC4GFqnZt2lmpRuJmt2zW K4nx/57PZr930Wa9fkAnVKgmCFL5LVkFQlF2m13EgWY1t16OdnO+rOy5rB259uRbjJGh 4Sy7nG5U+pT16uVbjj7eAH/LcKAt2TK9ZC3qAMPuchz6AKG7e/lZLiXSRIDfthRy22Mp 5tww== X-Gm-Message-State: APjAAAXKCkdJ7AR9/rNiF02iE7Gu8a6ym4yGvgXeH/Tm+YgH+aa3hTtp 8r/Rzxrb6cEvsbbc+I66zSpSEeD1sI3dbA== X-Received: by 2002:a1c:452:: with SMTP id 79mr3640062wme.149.1560428116130; Thu, 13 Jun 2019 05:15:16 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id y6sm2010576wrp.12.2019.06.13.05.15.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 05:15:15 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 13 Jun 2019 13:14:23 +0100 Message-Id: <20190613121433.5246-39-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613121433.5246-1-peter.maydell@linaro.org> References: <20190613121433.5246-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32c Subject: [Qemu-devel] [PULL 38/48] target/arm: Convert VMOV (register) to decodetree X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/translate-vfp.inc.c | 10 ++++++++++ target/arm/translate.c | 8 +------- target/arm/vfp.decode | 5 +++++ 3 files changed, 16 insertions(+), 7 deletions(-) -- 2.20.1 diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c index ae2f77a873b..a7e4ae31985 100644 --- a/target/arm/translate-vfp.inc.c +++ b/target/arm/translate-vfp.inc.c @@ -1889,6 +1889,16 @@ static bool trans_VMOV_imm_dp(DisasContext *s, arg_VMOV_imm_dp *a) return true; } +static bool trans_VMOV_reg_sp(DisasContext *s, arg_VMOV_reg_sp *a) +{ + return do_vfp_2op_sp(s, tcg_gen_mov_i32, a->vd, a->vm); +} + +static bool trans_VMOV_reg_dp(DisasContext *s, arg_VMOV_reg_dp *a) +{ + return do_vfp_2op_dp(s, tcg_gen_mov_i64, a->vd, a->vm); +} + static bool trans_VABS_sp(DisasContext *s, arg_VABS_sp *a) { return do_vfp_2op_sp(s, gen_helper_vfp_abss, a->vd, a->vm); diff --git a/target/arm/translate.c b/target/arm/translate.c index b0fd4051f1f..b26242d3498 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -3090,7 +3090,7 @@ static int disas_vfp_insn(DisasContext *s, uint32_t insn) return 1; case 15: switch (rn) { - case 1 ... 3: + case 0 ... 3: /* Already handled by decodetree */ return 1; default: @@ -3103,9 +3103,6 @@ static int disas_vfp_insn(DisasContext *s, uint32_t insn) if (op == 15) { /* rn is opcode, encoded as per VFP_SREG_N. */ switch (rn) { - case 0x00: /* vmov */ - break; - case 0x04: /* vcvtb.f64.f16, vcvtb.f32.f16 */ case 0x05: /* vcvtt.f64.f16, vcvtt.f32.f16 */ /* @@ -3278,9 +3275,6 @@ static int disas_vfp_insn(DisasContext *s, uint32_t insn) switch (op) { case 15: /* extension space */ switch (rn) { - case 0: /* cpy */ - /* no-op */ - break; case 4: /* vcvtb.f32.f16, vcvtb.f64.f16 */ { TCGv_ptr fpst = get_fpstatus_ptr(false); diff --git a/target/arm/vfp.decode b/target/arm/vfp.decode index 2780e1ed9ea..b72ab8b8067 100644 --- a/target/arm/vfp.decode +++ b/target/arm/vfp.decode @@ -157,6 +157,11 @@ VMOV_imm_sp ---- 1110 1.11 imm4h:4 .... 1010 0000 imm4l:4 \ VMOV_imm_dp ---- 1110 1.11 imm4h:4 .... 1011 0000 imm4l:4 \ vd=%vd_dp +VMOV_reg_sp ---- 1110 1.11 0000 .... 1010 01.0 .... \ + vd=%vd_sp vm=%vm_sp +VMOV_reg_dp ---- 1110 1.11 0000 .... 1011 01.0 .... \ + vd=%vd_dp vm=%vm_dp + VABS_sp ---- 1110 1.11 0000 .... 1010 11.0 .... \ vd=%vd_sp vm=%vm_sp VABS_dp ---- 1110 1.11 0000 .... 1011 11.0 .... \