From patchwork Thu Jun 13 14:37:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 166704 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp931738ilk; Thu, 13 Jun 2019 08:58:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqyoIUPOR41eyMNiBNmAIU+PhtyEIY8eCTqlneLAfsN0H14qDHVBDT9AnoM/KI0axFj+ZylV X-Received: by 2002:a37:6f81:: with SMTP id k123mr36474954qkc.321.1560441483240; Thu, 13 Jun 2019 08:58:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560441483; cv=none; d=google.com; s=arc-20160816; b=W4Mt9iCeUfd8GHxePf3rrKz/5buU4SDd2CxprYlVHiv6ELouFH/4RSvVbttxHOWQMb h2ia8hD6JNThmVuLlIL2lX0jXoa9df2Wz0xoWBfur4N1q4+5a5xfJhFraEVtA+NWDw1X H5FoAPX0ir3PP9YVIFDHQcpHiL7SQtZlwU6klgtfgSLcH/A1ytZ3WT039AFpQf0gHQ2R uuUGDwppL+tH0fFtShly/4kRezAmqoo2qJBwg97iN285+I/uHXBggzaeSs7hhVJoQv3m aRDDV955IUT7YPe81drEZl1EhXz2T2JV2ZKsGlRYoEDamMSEJy75b3u5fiHCTv4Z3pqy DsZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from :dkim-signature; bh=vg7Xo5/UC1VbFfsv57lBg2sMr1tbPeBB7dgbx/Rj6+I=; b=IRwjvoaWiF6TtRP1LWwRUDDNy63yXqiZlUzEu/wjm+5xJ2diCbUT2/tYkCSjBYu7Kl BknE2NRM8Ueg1zLsJBFWQGZstLBCF8AW/vgrA6mwsREhSaSf6ZmMLHRm3xgVYr4Q6VH/ aq/UlwBTULS7mWiA4Z9GUEoX70LnSayi6hrTfa+mQNhzy+nP98SPYvRZjChDjtJJlG9x jEo5euJkVVbb0iMB6Hj4ipWJhHDVbqfIOHM1+PjNT7v5d5GvfR/OSKgqzfTX6T9Fj+/t 9M1tOyqxsC+hyokoBhEvGJdCuBSYfB26LeUuiTTmYmkuLzUEjFdmpvXoXRcNU4tiVrLG nfsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PpQysJr3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i50si163714qta.170.2019.06.13.08.58.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Jun 2019 08:58:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=PpQysJr3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbS70-0002qn-Pr for patch@linaro.org; Thu, 13 Jun 2019 11:58:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43486) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbQrO-0002bJ-77 for qemu-devel@nongnu.org; Thu, 13 Jun 2019 10:37:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbQrM-0002oF-2T for qemu-devel@nongnu.org; Thu, 13 Jun 2019 10:37:49 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:39884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbQrK-0002lb-7I for qemu-devel@nongnu.org; Thu, 13 Jun 2019 10:37:47 -0400 Received: by mail-wr1-x442.google.com with SMTP id x4so18408980wrt.6 for ; Thu, 13 Jun 2019 07:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vg7Xo5/UC1VbFfsv57lBg2sMr1tbPeBB7dgbx/Rj6+I=; b=PpQysJr3UfhlfG8/PoFpVoWNqOdZpq+eqslUhspPaWdgr+li5AzXV1FXe1fmmNBgwz AclDX0N/iPz4q0+k+zSQ63PuQIBONq6zSN3qfyHhQncfeYjwEpXRYhAoO+BgHdzT/oI+ xk+MB+h3NE+mWSMpkWRsnAjlqEKwhihAnl6PJERaLCNYVbYQfPe/l2auV+VufFNuqHGO FqJCY+RNadEJJU2cilCvG0nTKSCTkBIfmFbVL6plz94u8SZFq+3CsiO5mBwsXyqe4smo Yj3pWoB9ozWNOMnxPeLe0bwVCwPj7drlWEHnpRC6QdkEx2cOrXh4vXSMYXWEBNlUOL44 ITlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vg7Xo5/UC1VbFfsv57lBg2sMr1tbPeBB7dgbx/Rj6+I=; b=s+sSIjl7JOwGpoLIQwl4r8q3tAQv39zLpTQ69THFkvzEkJVUgg3AwqB6z6yx8luE8J btAXJXH29IaU1FDyd7cpGmt57U+mf+BIhAn6KDHt7G/3Q2WXuLMU6hxSgR7wy24/NtzB +5d1caQ2vlVZ8ZR24jtztzjWrJYWSDP5KwA49lKVikWEOroIsyVe2eL3eE081SHmDIuv u9wjaCrJY1OBp4vYEdvtqhY8Btj+2hHl9cDC+I4aQfyy5novyIiLjwnPY+q9xYm2Gfzy XV1CMOpWfoMiSlG1VSnk23z5aqHpOJtW0SSRGn4ANWxmL5kENsurvLU6ywOKNbwBpQUo VEBA== X-Gm-Message-State: APjAAAUFtEnRWkCvelx8jVbvbFw4d2DyZWgpdwHik6VE4SBXsMcFidqc ESP8FB08Umo3T52T/UBKfkH1MQ== X-Received: by 2002:adf:9023:: with SMTP id h32mr60639641wrh.95.1560436663820; Thu, 13 Jun 2019 07:37:43 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id l12sm3080344wrb.81.2019.06.13.07.37.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 07:37:43 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Thu, 13 Jun 2019 15:37:41 +0100 Message-Id: <20190613143741.15128-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [RISU PATCH] arm.risu: Avoid VTRN with Vd == Vm X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The AArch32 VTRN instruction is specified to give an UNKNOWN result if Vd and Vm are the same register; avoid generating this in risu output, as we already do for VUZP and VZIP. Signed-off-by: Peter Maydell --- Alex: this pattern error is why we don't pass your testcases/aarch32-all/insn_VTRN__INC.risu.bin when compared with a real Cortex-A7. You probably want to update that. arm.risu | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/arm.risu b/arm.risu index 9009e6b..c16d245 100644 --- a/arm.risu +++ b/arm.risu @@ -613,7 +613,8 @@ VCLT0 A1 1111 0011 1 d 11 sz:2 01 vd:4 0 f 100 q m 0 vm:4 VABS A1 1111 0011 1 d 11 sz:2 01 vd:4 0 f 110 q m 0 vm:4 VNEG A1 1111 0011 1 d 11 sz:2 01 vd:4 0 f 111 q m 0 vm:4 VSWP A1 1111 0011 1 d 11 sz:2 10 vd:4 00000 q m 0 vm:4 -VTRN A1 1111 0011 1 d 11 sz:2 10 vd:4 00001 q m 0 vm:4 +# d == m gives UNKNOWN results, so avoid it +VTRN A1 1111 0011 1 d 11 sz:2 10 vd:4 00001 q m 0 vm:4 { ($d != $m) || ($vd != $vm); } # d == m gives UNKNOWN results, so avoid it VUZP A1 1111 0011 1 d 11 sz:2 10 vd:4 00010 q m 0 vm:4 { ($d != $m) || ($vd != $vm); } VZIP A1 1111 0011 1 d 11 sz:2 10 vd:4 00011 q m 0 vm:4 { ($d != $m) || ($vd != $vm); }