From patchwork Thu Jun 13 16:39:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 166724 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp1096976ilk; Thu, 13 Jun 2019 11:41:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqySjPIzdix1+3xy/Dthed8fgtNStxNbOhs1gzkcXC/eHS9Xym8xbnzoKUo+25jgdqIzk2rX X-Received: by 2002:ac8:5458:: with SMTP id d24mr37809689qtq.329.1560451273164; Thu, 13 Jun 2019 11:41:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560451273; cv=none; d=google.com; s=arc-20160816; b=gaRrXvcYVi+Wzt7JKYLh+SvK17Iw8A6E5RwJMYBxf8Aho6dtwtopOZ+JwlEbs9+cDt rkxMTl8oIB7SHYrjo8VQ/FPiSQ1bJrpImSKA34qZoeUx5WpKhIwBaoWT+unYUoFH8X3t cXIfOSkw43AzM+k4QMZCtjQdf1oTKC1/Ogs+kX0jP18zuf5V2Sy1YXBCjfDr3VLLPAzq 0UnJElAg9qu9twtUPHJs9xNjv03882gtoQOODB6iSJxGlSmwoo7c7YldSRcL0kyqMHc/ +eVqY1MMYOUT7kChr9KqYWIDIneILhv3N+ekVSAYFk4pCJcUYaeRVSCJk3qWBAguwqJH MjDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=qQmS7fDlwcZP6vIBxbHDINfjc+89reFKqPWwOYK60Kw=; b=qwAzUCuzpjtilCVNWilvoQPSn/4i/Bh5R8+Ru2iyuKo2nIhIqAgK/I+D2Z33ieIFWp o4SA9hT6ywefq8/b/WnnIQj27lMagxJsxwYOu/cpM6Ha546rfwzH5s4N56S+qu6NKcMX TTIHNpymIqiRGCJRaB8U1Wngv0vYfSzXN9O6ucwFqmCHCC1T4NSvj9H9m7zxhTuHi/Pb V1w4bdM0oN/T3S19aZOJ4yz+OeleqYMSieFOCVGEew5d5Knwmli4A5ueD3ZssnHruwaC AVedN7o7WDT+A1OLfLwz8FCmSKXzSK+WapNUl7WKxBDantXIHNSjAh0Q+tkjPddnPluk LrBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QnQyS2gW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c8si268813qkm.170.2019.06.13.11.41.12 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Jun 2019 11:41:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=QnQyS2gW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:43564 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbUeu-0004ML-D1 for patch@linaro.org; Thu, 13 Jun 2019 14:41:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53683) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbSlF-0003w4-F5 for qemu-devel@nongnu.org; Thu, 13 Jun 2019 12:39:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbSlA-00033x-MP for qemu-devel@nongnu.org; Thu, 13 Jun 2019 12:39:35 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:38271) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbSl6-0002Af-Ej for qemu-devel@nongnu.org; Thu, 13 Jun 2019 12:39:29 -0400 Received: by mail-wr1-x441.google.com with SMTP id d18so21500527wrs.5 for ; Thu, 13 Jun 2019 09:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qQmS7fDlwcZP6vIBxbHDINfjc+89reFKqPWwOYK60Kw=; b=QnQyS2gW36bnd6wnT+pgY0HZvam4SnFDo8x+J+U42SyswUpYxC5kMsF21UMuvCCjj6 YltiJgyuxWAOEI4oOA35JGtRo2UxTb7XWL3iazQgEpacyGkp1csmzew5cIPTHaQer+Na 2r5X40QFKU9XqPu9E0WP5sOHJ4ZCgFgTIUGgsyoKh+emPMB2la2bC9roKu3hDRLOWz42 CBUa1OE7r0A4jLGXByW5dlxnrm2iiQJ5NfWKgpG3AKVZLXKqjY1vEetKoH4x/wBPFNDd 0uKaT4EQSKDCvMaRxsqUgTdwIpHk1osdZKVg5tgZEg5vmi7Nt33wgzmVr4OTG1fzRKPd i2FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qQmS7fDlwcZP6vIBxbHDINfjc+89reFKqPWwOYK60Kw=; b=Lep0E6vldjO4Wm0c6Cr0L26bVqXV/xl8tPdx6L6C2YO7LhvWFYhMp1GlvSDGOANzYx tWrS5ohh/3BCglpMfxhbTcRPubSK5WPA+M1ZxW9P41QMUtfWHfPrwst4TIf/DS1k9ptN MuwHUHiHwB4AL0cQhYMJKG1CoCHJE737co+OXu0OHLv4VdiGJWzXdwrp0FBjv1hPg7rR XqK9ZABUxDmnnnJaPqe2U8JakaP/kZcK/D0nIEgqW7orUQ+a90jj5nJjxuXLtSVObLZL X3YrgHw9w0UBgSVwjw0Z53j1cbkNTqEZ4EsA2jhwWlyME73TzuQ6/TM0MBzAxCxCVXTv boNA== X-Gm-Message-State: APjAAAWDuLVBbR4JXcUR+0cNbq0xEuH11MYM77K3rYXZsW0AyZ97PeB/ oTnxtX94n52QulJu6dU5gjW5cg== X-Received: by 2002:adf:a509:: with SMTP id i9mr49822524wrb.269.1560443963612; Thu, 13 Jun 2019 09:39:23 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id f197sm358747wme.39.2019.06.13.09.39.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 09:39:23 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Thu, 13 Jun 2019 17:39:09 +0100 Message-Id: <20190613163917.28589-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190613163917.28589-1-peter.maydell@linaro.org> References: <20190613163917.28589-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH 04/12] target/arm: Stop using cpu_F0s for NEON_2RM_VNEG_F X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Switch NEON_2RM_VABS_F away from using cpu_F0s. Signed-off-by: Peter Maydell --- target/arm/translate.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/target/arm/translate.c b/target/arm/translate.c index a10fded1f39..a006ab498e7 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -1374,14 +1374,6 @@ static TCGv_ptr get_fpstatus_ptr(int neon) return statusptr; } -static inline void gen_vfp_neg(int dp) -{ - if (dp) - gen_helper_vfp_negd(cpu_F0d, cpu_F0d); - else - gen_helper_vfp_negs(cpu_F0s, cpu_F0s); -} - #define VFP_GEN_ITOF(name) \ static inline void gen_vfp_##name(int dp, int neon) \ { \ @@ -4189,8 +4181,7 @@ static int neon_2rm_is_float_op(int op) * what we are asking here is "does the code for this case in * the Neon for-each-pass loop use cpu_F0s?". */ - return (op == NEON_2RM_VNEG_F || - (op >= NEON_2RM_VRINTN && op <= NEON_2RM_VRINTZ) || + return ((op >= NEON_2RM_VRINTN && op <= NEON_2RM_VRINTZ) || op == NEON_2RM_VRINTM || (op >= NEON_2RM_VRINTP && op <= NEON_2RM_VCVTMS) || op >= NEON_2RM_VRECPE_F); @@ -6761,7 +6752,7 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) gen_helper_vfp_abss(tmp, tmp); break; case NEON_2RM_VNEG_F: - gen_vfp_neg(0); + gen_helper_vfp_negs(tmp, tmp); break; case NEON_2RM_VSWP: tmp2 = neon_load_reg(rd, pass);