[1/3] media: meson: include linux/kthread.h

Message ID 20190617111718.2277220-1-arnd@arndb.de
State New
Headers show
Series
  • [1/3] media: meson: include linux/kthread.h
Related show

Commit Message

Arnd Bergmann June 17, 2019, 11:16 a.m.
Without this header, we get a compilation error in some configurations:

drivers/staging/media/meson/vdec/vdec.c: In function 'vdec_recycle_thread':
drivers/staging/media/meson/vdec/vdec.c:59:10: error: implicit declaration of function 'kthread_should_stop' [-Werror=implicit-function-declaration]

Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/staging/media/meson/vdec/vdec.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.0

Comments

Sean Young June 25, 2019, 10:56 a.m. | #1
On Mon, Jun 17, 2019 at 01:16:53PM +0200, Arnd Bergmann wrote:
> The ttpci driver now uses the rc-core, so we need to ensure it

> is enabled:

> 

> ERROR: "rc_unregister_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> ERROR: "rc_allocate_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> ERROR: "rc_free_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> ERROR: "rc_keydown" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> ERROR: "rc_register_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> 

> Fixes: 71f49a8bf5c5 ("media: ttpci: use rc-core for the IR receiver")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Thank you for the patch, unfortunately this was already fixed in
commit 12e23ebb396e6ffea88b8c5e483059a297326afb (which was accepted
after you sent your patch).

Thanks
Sean
Arnd Bergmann June 25, 2019, 11:19 a.m. | #2
On Tue, Jun 25, 2019 at 12:56 PM Sean Young <sean@mess.org> wrote:
>

> On Mon, Jun 17, 2019 at 01:16:53PM +0200, Arnd Bergmann wrote:

> > The ttpci driver now uses the rc-core, so we need to ensure it

> > is enabled:

> >

> > ERROR: "rc_unregister_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> > ERROR: "rc_allocate_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> > ERROR: "rc_free_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> > ERROR: "rc_keydown" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> > ERROR: "rc_register_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

> >

> > Fixes: 71f49a8bf5c5 ("media: ttpci: use rc-core for the IR receiver")

> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>

> Thank you for the patch, unfortunately this was already fixed in

> commit 12e23ebb396e6ffea88b8c5e483059a297326afb (which was accepted

> after you sent your patch).


That seems like a better fix, thanks for addressing the issue!

      Arnd

Patch

diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
index 0a1a04fd5d13..eb335a0f2bdd 100644
--- a/drivers/staging/media/meson/vdec/vdec.c
+++ b/drivers/staging/media/meson/vdec/vdec.c
@@ -8,6 +8,7 @@ 
 #include <linux/clk.h>
 #include <linux/io.h>
 #include <linux/module.h>
+#include <linux/kthread.h>
 #include <linux/platform_device.h>
 #include <linux/mfd/syscon.h>
 #include <linux/slab.h>