From patchwork Mon Jun 17 14:34:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 167069 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3012092ilk; Mon, 17 Jun 2019 08:36:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqy2sEr3N/j5Cz2M+hhTMH4dq9LPR8Z0ZlN+jcIBWMFcoVxPwOfz57UbnWvSxeSdGwg37r+F X-Received: by 2002:a17:906:838a:: with SMTP id p10mr4451902ejx.237.1560785762447; Mon, 17 Jun 2019 08:36:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560785762; cv=none; d=google.com; s=arc-20160816; b=N4JaXEe7PsdUBIc8SPIpudYbPV46tm+zhBmb90ByJnbbr8SybHO/qAoFhvDBwUFEDr T62tQcO38LgQrAo41mDIH8zqO3KmCAcJFO3+z+4pmdrkkX0+4lw/CIqp6WehOo3HvTrK sekV8KYOGDD+lx/zRlwb+xK8dp+QUp5nJFoRgoBAxntfCWYKrs6hYPWDpG8/QwvRfwhL VLsrt8nq+SdVWARVjX9AYlHCJJWbXER2kxajQAa7H0tVT8I4J04zPLczPBROSXBU7jH7 Ej4vJCl+zHb2Qp98bWPXMS6Yv/OwNTlSrSbybaKmRDDRHgqw5qzX7FJ1N2xSk6PrHifm 7Cpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=L1QAxhdOtIdBK1xtHMazBBt8aewsGSxHd8eF0bvtE2w=; b=Vy0RnOUquQ/WJL7Z5RpopNXUXlbq9DcZYpKTLQBmJCy8J4bQqu/JuZTIlPJSDQpnTb xRDpZ8rCMCxzTEPBRq9S0InQp5mNaH0UyUeYJlD6KzRjCvCA1wp4ksW8V8IMPEg4+b/3 XmVu0AuT8YFNohNsG5DRJx7UIc+pZDlf7oNcuPbMJ3UHtoS7lww+AIMkTGp22jtpP9ai Sv3ldoSPjHWQLdXA3U5WbUfq3X4yJg6CSYDqCo/Ixga4BcNs8hePFsg2TnM4uDETaN4Z 9N0KvjjMCQ/o5SsS8rO7ezYxODHsaRwVmjQRnRwQowjK+67lVu4BR0pVrAazOT4ewH/h yaSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gLi27PxJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r18si8895604eda.193.2019.06.17.08.36.02 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Jun 2019 08:36:02 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gLi27PxJ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hctft-00061w-F6 for patch@linaro.org; Mon, 17 Jun 2019 11:36:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46762) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcsiP-0003jO-0y for qemu-devel@nongnu.org; Mon, 17 Jun 2019 10:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcsiN-0008A4-ST for qemu-devel@nongnu.org; Mon, 17 Jun 2019 10:34:32 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:53422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcsiN-00088n-DG for qemu-devel@nongnu.org; Mon, 17 Jun 2019 10:34:31 -0400 Received: by mail-wm1-x341.google.com with SMTP id x15so9550666wmj.3 for ; Mon, 17 Jun 2019 07:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=L1QAxhdOtIdBK1xtHMazBBt8aewsGSxHd8eF0bvtE2w=; b=gLi27PxJkBunaTCfeqNp/HV3cboHFgmT6UlJo4uqXGs+5Hy5MfbaPe9KsxnL2Xn3CE lcdymT8iZwsOMiGigOYC4y7hkhEQMPnrzfztc9qVMTFF2yV20sWJw/u1jyOm1xNg/57D GDxtEX8yhyGLYtYuHLkXg2IF/CxkyCbPq4sLOK6Knbzyi6SXL55WOHlHbgdeyY0LrVJ7 TcXlURXqCooiqhVClQZW/EA8YVUT5KUr/8URPlPPwJLRy1x8UxXS2ExUOantpqjclGzQ cnI4Nc8p4hzxBlFZGDJTnchrRdUMXlWIUyXTO7r7BdzdGEyzy7aA0LAdjyFUBrTM5bXj yYSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L1QAxhdOtIdBK1xtHMazBBt8aewsGSxHd8eF0bvtE2w=; b=N+E0s+3LA8HPWk+M+BcoycLFAsx0B1z6Z2Qgzg3T4zfAmE98mhPMuKlCBjxzBTCfpj ORG59uwB9hKu435jsg/meakubdWwPmkj7cLR9ZDFRYhaVnhMjh/m5tz6F0MF7OnovtAz dr4ccotTx5z3BQX4s2QwBLTUCO/x5uvGXp9kYYLmmYeJZxOR7tg2zirR7tJ0FuN7jIUV waY2zyHxkq2boDvln+JEPQMDC+yX9UqaMsKNEPyFdtkKMbF46RMDh4E+akzFFxnn2zsy mgYd/IMkx42kOo9gNTlV1PLwbtOdzfhyOozVSVOAQcg4IGCWoHqVABWnZPbtJj9UywE0 voVg== X-Gm-Message-State: APjAAAXeuFUhj17zsrF7Iebmmyl6vj2gc8IG9rc4ZZ7dZ8mqe2pYOBY5 SJXXX40C5op1xU3zFjZ6yzqAnaKaOspTTg== X-Received: by 2002:a7b:cc16:: with SMTP id f22mr20892673wmh.115.1560782070131; Mon, 17 Jun 2019 07:34:30 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a67sm13819985wmh.40.2019.06.17.07.34.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 07:34:29 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 17 Jun 2019 15:34:02 +0100 Message-Id: <20190617143412.5734-15-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190617143412.5734-1-peter.maydell@linaro.org> References: <20190617143412.5734-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PULL 14/24] target/arm: Stop using cpu_F0s for NEON_2RM_VNEG_F X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Switch NEON_2RM_VABS_F away from using cpu_F0s. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-id: 20190613163917.28589-5-peter.maydell@linaro.org --- target/arm/translate.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) -- 2.20.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index a10fded1f39..a006ab498e7 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -1374,14 +1374,6 @@ static TCGv_ptr get_fpstatus_ptr(int neon) return statusptr; } -static inline void gen_vfp_neg(int dp) -{ - if (dp) - gen_helper_vfp_negd(cpu_F0d, cpu_F0d); - else - gen_helper_vfp_negs(cpu_F0s, cpu_F0s); -} - #define VFP_GEN_ITOF(name) \ static inline void gen_vfp_##name(int dp, int neon) \ { \ @@ -4189,8 +4181,7 @@ static int neon_2rm_is_float_op(int op) * what we are asking here is "does the code for this case in * the Neon for-each-pass loop use cpu_F0s?". */ - return (op == NEON_2RM_VNEG_F || - (op >= NEON_2RM_VRINTN && op <= NEON_2RM_VRINTZ) || + return ((op >= NEON_2RM_VRINTN && op <= NEON_2RM_VRINTZ) || op == NEON_2RM_VRINTM || (op >= NEON_2RM_VRINTP && op <= NEON_2RM_VCVTMS) || op >= NEON_2RM_VRECPE_F); @@ -6761,7 +6752,7 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) gen_helper_vfp_abss(tmp, tmp); break; case NEON_2RM_VNEG_F: - gen_vfp_neg(0); + gen_helper_vfp_negs(tmp, tmp); break; case NEON_2RM_VSWP: tmp2 = neon_load_reg(rd, pass);