From patchwork Mon Jun 17 14:34:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 167072 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3023949ilk; Mon, 17 Jun 2019 08:47:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpwP4xmyLj9cnAqvTR1L3JtfNCcaC4JCITxCfEhSvmqSPYzINBldpvQo+rNQDhXBL1ig/F X-Received: by 2002:a50:9456:: with SMTP id q22mr100979948eda.28.1560786448219; Mon, 17 Jun 2019 08:47:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560786448; cv=none; d=google.com; s=arc-20160816; b=x7biNFO8C4ggV1mlJM8U7SiADI87+c9DiRQsCSsY+0cxQDVJ5btveH8ow0CIIEhB1J oyMsnsRBlO9vW+YiqfqAwN+HEJbZIBHJk2yKv5lITY4HqdIZyJXTp5OmzrC5VJQveTWH grdEWrpRE6dtl4cjfXL0XjuDP3AmlJ4Tv7M/ISjlfjrnnzHiUGt2Rtu31pXP1pv/byop nfliSXRdlfxoD2YWLaMZh05AsjyOrTFSXs1NLrbDA0qvjL5cyV6ZE8CAtecdelhlHG4q 9xqXs0e4BZy0Bqa5TjsUhX8MczTZORnuFpMNfH4oyBh5q1qZZtIrl2DgGVWJuPMvek5b jkfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=XTL6vXsjTHflOLJ+e9+ddR0nb34AKoiPztLrrZicDQo=; b=PPTcYoYlhPwmeMICXgswmNoVT4iTCN6JTptDdxry5681drSyxwosmyDr17DX0JUsVN CSm2rW1yeCCzdODx8GXM5D8xX9sii5rmnusd0KCXrq0e9ilLej2NNhtuqOXTSoDYZraK Cpa2xWT0agx/lN4GO5PEPyFcq2CimqcKVAlC0U+yC2+NKkqFHNmL7cEgCuqZNKm3D6+c FqHFFWCgae6gPeX9CJVXiWfmk/oX3D2+/NF3W4OCZeMX3knFz9m2lA4/nrTOW5fVWnzE +N9KQeW25/0JNTsyITlbc+CSii7SSj4kzuesw0+kq5mUzAyRZLd/jzrl8vXjBpOgWLiE 3YTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jBRTNCWh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 4si9080887edz.269.2019.06.17.08.47.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Jun 2019 08:47:28 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jBRTNCWh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48698 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hctqx-0000aA-7l for patch@linaro.org; Mon, 17 Jun 2019 11:47:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46908) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcsib-0003ps-PD for qemu-devel@nongnu.org; Mon, 17 Jun 2019 10:34:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcsia-0008IH-4r for qemu-devel@nongnu.org; Mon, 17 Jun 2019 10:34:45 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:34687) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcsiY-0008EA-1T for qemu-devel@nongnu.org; Mon, 17 Jun 2019 10:34:43 -0400 Received: by mail-wm1-x342.google.com with SMTP id w9so112657wmd.1 for ; Mon, 17 Jun 2019 07:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=XTL6vXsjTHflOLJ+e9+ddR0nb34AKoiPztLrrZicDQo=; b=jBRTNCWhLhvz66UFl/CDCvq9ye4qNbrqs0vbk5HVUcOzk25C2Vgmkr1QRVFEygpBCX nwkuPy/gXBZKXSQFYFX3cZjpdSLarSBbW2gWrZcC30OEqTzJIv6zWLT9cBX2JnENsUK/ LwPmV44KniHuJAXbCmrItr0GMgRm+dByij/o39/ea23xEtNsguEerU2SuNwRuGgwY6vz G2EWY/KAPDspf2rCrx9ZmaAQPbgp+QqaBEPe0hj2R6XoyApwhTD+++yGJUZe6CBZ6GU3 hvYU+v/ULrG/Yo8zh5LPtNrIn/rgtj6CmQjOIU9TPspSMTmu5DsuEB/Pr9H0EORyRs6C nGNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XTL6vXsjTHflOLJ+e9+ddR0nb34AKoiPztLrrZicDQo=; b=UUsCR2fk/z34++HZ7sNstctF6Zw3XDAGr/1T0ASHHd+DSJUFhRDcMTvOcaAH4bpdXA fR85iMB0K9jt2RLNYdb72UfyKevUU21DIzQIvBO7LgWugSpkvELDLZK2O+7f+pExBJPd 1ZpfLEbBg4HnRMz21GIkDP5Tq1QOST3nMAU9eGLtmauphVZMxsrfYB+HiTGLpFIytqVm 9w2iqqNmdKgVEHbZMTJl0//DW+hKJEGgEziZAqOx6qqXeNaTOHKSyW2/+X462qaPW5Da L3u0V1ZbgPofzbSW0x86Xf4j6/whG2Tzb+cBA4/BerXqDNcnqLoy2zT9x7mef6zsVflD 3tiQ== X-Gm-Message-State: APjAAAWoBN/aO6qIyl3FPj51MQQIk0/TxSlAuxB1uR4JwQPtAAHgv3rV Cj0Kbnjz2HVGm2I8PSPemaRCCN5lvk2coA== X-Received: by 2002:a1c:8a:: with SMTP id 132mr19189066wma.44.1560782077170; Mon, 17 Jun 2019 07:34:37 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a67sm13819985wmh.40.2019.06.17.07.34.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 07:34:36 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 17 Jun 2019 15:34:09 +0100 Message-Id: <20190617143412.5734-22-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190617143412.5734-1-peter.maydell@linaro.org> References: <20190617143412.5734-1-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PULL 21/24] target/arm: Stop using deprecated functions in NEON_2RM_VCVT_F32_F16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Remove some old constructns from NEON_2RM_VCVT_F16_F32 code: * don't use CPU_F0s * don't use tcg_gen_st_f32 Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-id: 20190613163917.28589-12-peter.maydell@linaro.org --- target/arm/translate.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) -- 2.20.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index 2ba620ac1e1..8f124a953b6 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -1542,8 +1542,6 @@ static TCGv_ptr vfp_reg_ptr(bool dp, int reg) return ret; } -#define tcg_gen_st_f32 tcg_gen_st_i32 - #define ARM_CP_RW_BIT (1 << 20) /* Include the VFP decoder */ @@ -6460,20 +6458,18 @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) tmp = neon_load_reg(rm, 0); tmp2 = neon_load_reg(rm, 1); tcg_gen_ext16u_i32(tmp3, tmp); - gen_helper_vfp_fcvt_f16_to_f32(cpu_F0s, tmp3, fpst, ahp); - tcg_gen_st_f32(cpu_F0s, cpu_env, neon_reg_offset(rd, 0)); - tcg_gen_shri_i32(tmp3, tmp, 16); - gen_helper_vfp_fcvt_f16_to_f32(cpu_F0s, tmp3, fpst, ahp); - tcg_gen_st_f32(cpu_F0s, cpu_env, neon_reg_offset(rd, 1)); - tcg_temp_free_i32(tmp); + gen_helper_vfp_fcvt_f16_to_f32(tmp3, tmp3, fpst, ahp); + neon_store_reg(rd, 0, tmp3); + tcg_gen_shri_i32(tmp, tmp, 16); + gen_helper_vfp_fcvt_f16_to_f32(tmp, tmp, fpst, ahp); + neon_store_reg(rd, 1, tmp); + tmp3 = tcg_temp_new_i32(); tcg_gen_ext16u_i32(tmp3, tmp2); - gen_helper_vfp_fcvt_f16_to_f32(cpu_F0s, tmp3, fpst, ahp); - tcg_gen_st_f32(cpu_F0s, cpu_env, neon_reg_offset(rd, 2)); - tcg_gen_shri_i32(tmp3, tmp2, 16); - gen_helper_vfp_fcvt_f16_to_f32(cpu_F0s, tmp3, fpst, ahp); - tcg_gen_st_f32(cpu_F0s, cpu_env, neon_reg_offset(rd, 3)); - tcg_temp_free_i32(tmp2); - tcg_temp_free_i32(tmp3); + gen_helper_vfp_fcvt_f16_to_f32(tmp3, tmp3, fpst, ahp); + neon_store_reg(rd, 2, tmp3); + tcg_gen_shri_i32(tmp2, tmp2, 16); + gen_helper_vfp_fcvt_f16_to_f32(tmp2, tmp2, fpst, ahp); + neon_store_reg(rd, 3, tmp2); tcg_temp_free_i32(ahp); tcg_temp_free_ptr(fpst); break;