| Message ID | 20190618071514.2222319-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | ipsec: select CRYPTO_HASH for xfrm_algo | expand |
On Tue, Jun 18, 2019 at 09:14:51AM +0200, Arnd Bergmann wrote: > kernelci.org reports failed builds on arc because of what looks > like an old missed 'select' statement: > > net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': > xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' > > I don't see this in randconfig builds on other architectures, but > it's fairly clear we want to select the hash code for it, like we > do for all its other users. > > Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > net/xfrm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig > index c967fc3c38c8..a5c967efe5f4 100644 > --- a/net/xfrm/Kconfig > +++ b/net/xfrm/Kconfig > @@ -15,6 +15,7 @@ config XFRM_ALGO > tristate > select XFRM > select CRYPTO > + select CRYPTO_HASH You should also select CRYPTO_BLKCIPHER. Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index c967fc3c38c8..a5c967efe5f4 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -15,6 +15,7 @@ config XFRM_ALGO tristate select XFRM select CRYPTO + select CRYPTO_HASH if INET config XFRM_USER
kernelci.org reports failed builds on arc because of what looks like an old missed 'select' statement: net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' I don't see this in randconfig builds on other architectures, but it's fairly clear we want to select the hash code for it, like we do for all its other users. Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- net/xfrm/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0