selftests/tpm2: Install run-time Python modules

Message ID 20190620131822.28944-1-daniel.diaz@linaro.org
State New
Headers show
Series
  • selftests/tpm2: Install run-time Python modules
Related show

Commit Message

Daniel Díaz June 20, 2019, 1:18 p.m.
When ordinarily running the tests, upon `make install', the
following error is encountered:
  ImportError: No module named tpm2_tests
because the Python files are not installed at the moment.

Fix this by adding both Python modules as accompanying
TEST_FILES in the Makefile.

Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>

---
 tools/testing/selftests/tpm2/Makefile | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

Comments

Jarkko Sakkinen June 20, 2019, 9:40 p.m. | #1
On Thu, Jun 20, 2019 at 08:18:19AM -0500, Daniel Díaz wrote:
> When ordinarily running the tests, upon `make install', the

> following error is encountered:

>   ImportError: No module named tpm2_tests

> because the Python files are not installed at the moment.

> 

> Fix this by adding both Python modules as accompanying

> TEST_FILES in the Makefile.

> 

> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>


Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>


Question the kselftests maintainers: can I take this to [1] and
include to my 5.3 PR?

[1] git://git.infradead.org/users/jjs/linux-tpmdd.git

/Jarkko

Patch

diff --git a/tools/testing/selftests/tpm2/Makefile b/tools/testing/selftests/tpm2/Makefile
index 9dd848427a7b..bf401f725eef 100644
--- a/tools/testing/selftests/tpm2/Makefile
+++ b/tools/testing/selftests/tpm2/Makefile
@@ -2,3 +2,4 @@ 
 include ../lib.mk
 
 TEST_PROGS := test_smoke.sh test_space.sh
+TEST_FILES := tpm2.py tpm2_tests.py