| Message ID | 20190626084407.27976-2-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 8df9d7f70f87960b6ad2b4a90db755551d7ab7bd |
| Headers | show |
| Series | [1/5] gpio: siox: Do not call gpiochip_remove() on errorpath | expand |
On Wed, Jun 26, 2019 at 10:44:04AM +0200, Linus Walleij wrote: > The siox driver is hardcoding a default type of > IRQ_TYPE_EDGE_RISING to the irq helper, but this should only > be applicable to old boardfiles and odd device tree irqchips > with just onecell irq (no flags). I doubt this is the case > with the siox, I think all consumers specify the flags they > use in the device tree. > > Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
diff --git a/drivers/gpio/gpio-siox.c b/drivers/gpio/gpio-siox.c index 0b4450118865..40067e1535d3 100644 --- a/drivers/gpio/gpio-siox.c +++ b/drivers/gpio/gpio-siox.c @@ -247,7 +247,7 @@ static int gpio_siox_probe(struct siox_device *sdevice) } ret = gpiochip_irqchip_add(&ddata->gchip, &ddata->ichip, - 0, handle_level_irq, IRQ_TYPE_EDGE_RISING); + 0, handle_level_irq, IRQ_TYPE_NONE); if (ret) dev_err(&sdevice->dev, "Failed to register irq chip (%d)\n", ret);
The siox driver is hardcoding a default type of IRQ_TYPE_EDGE_RISING to the irq helper, but this should only be applicable to old boardfiles and odd device tree irqchips with just onecell irq (no flags). I doubt this is the case with the siox, I think all consumers specify the flags they use in the device tree. Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/gpio/gpio-siox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1