| Message ID | 20190626093418.6263-1-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 2229a3618abdaac40c9e32754509357ed78c90f5 |
| Headers | show |
| Series | unicore: Drop pointless include | expand |
On Wed, Jun 26, 2019 at 11:34 AM Linus Walleij <linus.walleij@linaro.org> wrote: > I can't see why this file includes <linux/gpio.h>, it is not > using any of the interfaces. Lots of things are named "gpio" > in the file but it is an irqchip driver and has nothing to > do with the GPIO interfaces. > > Cc: Guan Xuetao <gxt@pku.edu.cn> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Patch applied to the GPIO tree. Yours, Linus Walleij
diff --git a/arch/unicore32/kernel/irq.c b/arch/unicore32/kernel/irq.c index eb1fd0030359..8385e4fc0ff6 100644 --- a/arch/unicore32/kernel/irq.c +++ b/arch/unicore32/kernel/irq.c @@ -24,7 +24,6 @@ #include <linux/kallsyms.h> #include <linux/proc_fs.h> #include <linux/syscore_ops.h> -#include <linux/gpio.h> #include <mach/hardware.h>
I can't see why this file includes <linux/gpio.h>, it is not using any of the interfaces. Lots of things are named "gpio" in the file but it is an irqchip driver and has nothing to do with the GPIO interfaces. Cc: Guan Xuetao <gxt@pku.edu.cn> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- arch/unicore32/kernel/irq.c | 1 - 1 file changed, 1 deletion(-) -- 2.20.1