From patchwork Wed Jul 3 15:03:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liviu Dudau X-Patchwork-Id: 168421 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp1018289ilk; Wed, 3 Jul 2019 08:03:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVnbTkCBFKnSor2leS/pHETwBVezhVW5KobY4NW6mD6xehUpxGQifFneJiGNNRpFIcLcSz X-Received: by 2002:a63:b10f:: with SMTP id r15mr22973521pgf.230.1562166228701; Wed, 03 Jul 2019 08:03:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562166228; cv=none; d=google.com; s=arc-20160816; b=awMliblI9iuePgUMUX4l2FVB7ujMqboOACLWsRxaGmgR9TpdE0wtjJSG4hJPV2MUxQ 2UiGkVdL+lpt6a4JZjz85FjsT3y0ut3N0B1YbgtJYIIZQUhcsLuNnXC7CEpSQ+DUiG10 M7d0bfQWK4YsuwThrOAR+cQDQRc/kChmlApMxnI16NtRIrsSyDZhbpWGc9weyUUo4R+H 4ZWPkqYPQH9XohpDqM8SI9MnSv23ggJu6JNPYRMwzYEdI0FQpqd8AeBTfG0uvczSRL17 gbrgszVHFyeVY03PTRn1hVOu0BLJAz6/HqY/vbeezpQ9jpvKOyQjV78Rcm8KCcJPqpsT t7Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :delivered-to; bh=YGXC7KR7Bx8qhGLxEp2H2tb8XnhlxRNRsFLRsQ6PYw4=; b=erGrY1a6Mn3KNcfSW68RWUL20PQ81EhJqvGvpFSDeGwD+vMG6z5AkSlmq/zPMKbKve IPqvhq39vMBIRIIWEEPBlrStGsvBSj4Igt44EPPY8GcjRy3ihjrJMjE69DzRzmUJjUGJ 6g1wfhLccYcG8PCqIP4Xipnz1slxDJTPakq42gmEMZbPVEuTc+5ItOT936HbBlU/Xho5 bHuzso85EWN7jWuhg6QTuMhaFXmXEL92klaf1y2c5X8fRm2jAXwZlk/t50VGr9iDXs/T p+rMMPu+MwaOktZlYKLQICZtl7ZtXpIoEjIoYOv1JcbygJKQAd2HLHmRflvEi2hRM4z/ Ok5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id 5si2580812pfv.231.2019.07.03.08.03.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jul 2019 08:03:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A65A96E14E; Wed, 3 Jul 2019 15:03:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from cam-smtp0.cambridge.arm.com (unknown [217.140.106.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C2656E14E for ; Wed, 3 Jul 2019 15:03:46 +0000 (UTC) Received: from e110455-lin.cambridge.arm.com (e110455-lin.cambridge.arm.com [10.2.131.87]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id x63F3Uwx025553; Wed, 3 Jul 2019 16:03:30 +0100 From: Liviu Dudau To: Daniel Vetter Subject: [PATCH] drm/drm_debugfs_crc.c: Document that .verify_crc_source vfunc is required for enabling CRC support. Date: Wed, 3 Jul 2019 16:03:30 +0100 Message-Id: <20190703150330.21992-1-Liviu.Dudau@arm.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Sean Paul , Liviu Dudau , DRI devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" drm_debugfs_crtc_crc_add() function checks that both .set_crc_source and .verify_crc_source hooks are provided before enabling debugfs support for reading per-frame CRC data. Make that explicit in the documentation. Cc: Daniel Vetter Signed-off-by: Liviu Dudau Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_debugfs_crc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c index 7ca486d750e9..6604ed223160 100644 --- a/drivers/gpu/drm/drm_debugfs_crc.c +++ b/drivers/gpu/drm/drm_debugfs_crc.c @@ -66,9 +66,9 @@ * the reported CRCs of frames that should have the same contents. * * On the driver side the implementation effort is minimal, drivers only need to - * implement &drm_crtc_funcs.set_crc_source. The debugfs files are automatically - * set up if that vfunc is set. CRC samples need to be captured in the driver by - * calling drm_crtc_add_crc_entry(). + * implement &drm_crtc_funcs.set_crc_source and &drm_crtc_funcs.verify_crc_source. + * The debugfs files are automatically set up if those vfuncs are set. CRC samples + * need to be captured in the driver by calling drm_crtc_add_crc_entry(). */ static int crc_control_show(struct seq_file *m, void *data)