[4/7] ipsec: select crypto ciphers for xfrm_algo

Message ID 20190705082700.31107-5-steffen.klassert@secunet.com
State New
Headers show
Series
  • Untitled series #21667
Related show

Commit Message

Steffen Klassert July 5, 2019, 8:26 a.m.
From: Arnd Bergmann <arnd@arndb.de>


kernelci.org reports failed builds on arc because of what looks
like an old missed 'select' statement:

net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs':
xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash'

I don't see this in randconfig builds on other architectures, but
it's fairly clear we want to select the hash code for it, like we
do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER
is also required even though it has not popped up in build tests.

Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

---
 net/xfrm/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.17.1

Patch

diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig
index 1ec8071226b2..06a6928d0e62 100644
--- a/net/xfrm/Kconfig
+++ b/net/xfrm/Kconfig
@@ -14,6 +14,8 @@  config XFRM_ALGO
 	tristate
 	select XFRM
 	select CRYPTO
+	select CRYPTO_HASH
+	select CRYPTO_BLKCIPHER
 
 if INET
 config XFRM_USER