diff mbox series

drm/bridge/megachips: Drop GPIO header

Message ID 20190708112803.12432-1-linus.walleij@linaro.org
State Accepted
Commit b316c92e9a0ea156f91b79840f39a1d964aad55f
Headers show
Series drm/bridge/megachips: Drop GPIO header | expand

Commit Message

Linus Walleij July 8, 2019, 11:28 a.m. UTC
This file isn't using any interfaces from <linux/gpio.h> so
just drop the include.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Linus Walleij Aug. 5, 2019, 9:05 a.m. UTC | #1
On Mon, Jul 8, 2019 at 1:28 PM Linus Walleij <linus.walleij@linaro.org> wrote:

> This file isn't using any interfaces from <linux/gpio.h> so
> just drop the include.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

So what do I do with these simple patches as noone seems to
ACK or review them for a month?

I guess as last resort simply apply them to the GPIO tree, but
hey.

Yours,
Linus Walleij
Laurent Pinchart Aug. 5, 2019, 9:31 a.m. UTC | #2
Hi Linus,

On Mon, Aug 05, 2019 at 11:05:55AM +0200, Linus Walleij wrote:
> On Mon, Jul 8, 2019 at 1:28 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> 
> > This file isn't using any interfaces from <linux/gpio.h> so
> > just drop the include.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> So what do I do with these simple patches as noone seems to
> ACK or review them for a month?
> 
> I guess as last resort simply apply them to the GPIO tree, but
> hey.

They have a tendency to slip through the cracks :-S One ping is
sometimes all it takes though:

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

But if a ping doesn't help I think you can just apply them (although
probably to the drm-misc tree in this case, to minimise the risk of
conflicts, event if they're quite unlikely).
Linus Walleij Aug. 5, 2019, 9:40 a.m. UTC | #3
On Mon, Aug 5, 2019 at 11:31 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Aug 05, 2019 at 11:05:55AM +0200, Linus Walleij wrote:
> > On Mon, Jul 8, 2019 at 1:28 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > > This file isn't using any interfaces from <linux/gpio.h> so
> > > just drop the include.
> > >
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > So what do I do with these simple patches as noone seems to
> > ACK or review them for a month?
> >
> > I guess as last resort simply apply them to the GPIO tree, but
> > hey.
>
> They have a tendency to slip through the cracks :-S One ping is
> sometimes all it takes though:
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks Laurent! :)

It goes for all of them I assume.

Yours,
Linus Walleij
Neil Armstrong Aug. 5, 2019, 2:23 p.m. UTC | #4
Hi Linus,

On 05/08/2019 11:40, Linus Walleij wrote:
> On Mon, Aug 5, 2019 at 11:31 AM Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
>> On Mon, Aug 05, 2019 at 11:05:55AM +0200, Linus Walleij wrote:
>>> On Mon, Jul 8, 2019 at 1:28 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>>>
>>>> This file isn't using any interfaces from <linux/gpio.h> so
>>>> just drop the include.
>>>>
>>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>>
>>> So what do I do with these simple patches as noone seems to
>>> ACK or review them for a month?
>>>
>>> I guess as last resort simply apply them to the GPIO tree, but
>>> hey.
>>
>> They have a tendency to slip through the cracks :-S One ping is
>> sometimes all it takes though:
>>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Thanks Laurent! :)
> 
> It goes for all of them I assume.

Tell me if you need me to apply it.

Neil

> 
> Yours,
> Linus Walleij
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Daniel Vetter Aug. 5, 2019, 3:39 p.m. UTC | #5
On Mon, Aug 5, 2019 at 11:06 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Jul 8, 2019 at 1:28 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > This file isn't using any interfaces from <linux/gpio.h> so
> > just drop the include.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> So what do I do with these simple patches as noone seems to
> ACK or review them for a month?

Ping people explicitly for review/acks, either here or on irc. Keep a
record of who owes you, to make your ping convincing :-)

> I guess as last resort simply apply them to the GPIO tree, but
> hey.

The trouble is that with mailing lists it's essentially impossible to
track patches in need of review. Except if everyone would keep their
own stuff up to date, which almost noone does (plus you'd need to do
it on all the disjoint patchwork instances if you cc multiple list).
So defacto stuff just gets lost after about a week or so, and you need
to kick it again. "Maintainer updates patchwork all the time" doesn't
scale and leads to burnout. It sucks, but it is what it is. Waiting a
full month is definitely too much waiting, especially for a simple
patch like this one.
-Daniel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
index 823db80cbd19..b40ce484244a 100644
--- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
+++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
@@ -19,7 +19,6 @@ 
  *   Host -> LVDS|--(STDP4028)--|DP -> DP|--(STDP2690)--|DP++ -> Video output
  */
 
-#include <linux/gpio.h>
 #include <linux/i2c.h>
 #include <linux/module.h>
 #include <linux/of.h>