diff mbox series

[2/2] drm/pl111: Drop special pads config check

Message ID 20190724134959.2365-2-linus.walleij@linaro.org
State Accepted
Commit d6781e490179f7ba710dd924187109da70c185b0
Headers show
Series None | expand

Commit Message

Linus Walleij July 24, 2019, 1:49 p.m. UTC
This drops the check of the surplus "pads" configuration
from the device tree that is completely unused in the DRM
driver.

This was only used to work around limitations in the earlier
fbdev driver.

Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpu/drm/pl111/pl111_display.c | 16 ----------------
 1 file changed, 16 deletions(-)

Comments

Sam Ravnborg July 24, 2019, 6:54 p.m. UTC | #1
On Wed, Jul 24, 2019 at 03:49:59PM +0200, Linus Walleij wrote:
> This drops the check of the surplus "pads" configuration
> from the device tree that is completely unused in the DRM
> driver.
> 
> This was only used to work around limitations in the earlier
> fbdev driver.
> 
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Always good to delete code.

Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

> ---
>  drivers/gpu/drm/pl111/pl111_display.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index e42fb6353623..8595a676b084 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -572,24 +572,8 @@ int pl111_display_init(struct drm_device *drm)
>  {
>  	struct pl111_drm_dev_private *priv = drm->dev_private;
>  	struct device *dev = drm->dev;
> -	struct device_node *endpoint;
> -	u32 tft_r0b0g0[3];
>  	int ret;
>  
> -	endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
> -	if (!endpoint)
> -		return -ENODEV;
> -
> -	if (of_property_read_u32_array(endpoint,
> -				       "arm,pl11x,tft-r0g0b0-pads",
> -				       tft_r0b0g0,
> -				       ARRAY_SIZE(tft_r0b0g0)) != 0) {
> -		dev_err(dev, "arm,pl11x,tft-r0g0b0-pads should be 3 ints\n");
> -		of_node_put(endpoint);
> -		return -ENOENT;
> -	}
> -	of_node_put(endpoint);
> -
>  	ret = pl111_init_clock_divider(drm);
>  	if (ret)
>  		return ret;
> -- 
> 2.21.0
diff mbox series

Patch

diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
index e42fb6353623..8595a676b084 100644
--- a/drivers/gpu/drm/pl111/pl111_display.c
+++ b/drivers/gpu/drm/pl111/pl111_display.c
@@ -572,24 +572,8 @@  int pl111_display_init(struct drm_device *drm)
 {
 	struct pl111_drm_dev_private *priv = drm->dev_private;
 	struct device *dev = drm->dev;
-	struct device_node *endpoint;
-	u32 tft_r0b0g0[3];
 	int ret;
 
-	endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
-	if (!endpoint)
-		return -ENODEV;
-
-	if (of_property_read_u32_array(endpoint,
-				       "arm,pl11x,tft-r0g0b0-pads",
-				       tft_r0b0g0,
-				       ARRAY_SIZE(tft_r0b0g0)) != 0) {
-		dev_err(dev, "arm,pl11x,tft-r0g0b0-pads should be 3 ints\n");
-		of_node_put(endpoint);
-		return -ENOENT;
-	}
-	of_node_put(endpoint);
-
 	ret = pl111_init_clock_divider(drm);
 	if (ret)
 		return ret;